New issue
Advanced search Search tips

Issue 811506 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

debugd crash loop

Project Member Reported by yusukes@chromium.org, Feb 12 2018

Issue description

Chrome OS Version: self-built 10398.0.0-ish veyron_minnie test

Steps:
(1) Boot the device
(2) ssh, and run dmesg

Actual:
dmesg has lots of logs like this:
[  720.976074] Chromium OS LSM: Mount path with symlinks prohibited - pid=10727 cmdline="/sbin/debugd"

localhost ~ # dmesg | grep 'Chromium OS LSM: Mount path with symlinks prohibited' | wc -l
419

 

Comment 1 by vapier@chromium.org, Feb 13 2018

try https://chromium-review.googlesource.com/915801 and see if there's more details in the logs
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2018

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ed0e513d5d79953ef8683393eabcd2c34f44f4b0

commit ed0e513d5d79953ef8683393eabcd2c34f44f4b0
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Feb 15 10:33:10 2018

CHROMIUM: LSM: add more details to blocked symlink mount

In case of a failed mount, include the source/destination paths.

BUG= chromium:811506 
TEST=precq passes

Change-Id: Ibf93f82c51a5b40a41cb0031b9331d911ec3b943
Signed-off-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/915801
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>

[modify] https://crrev.com/ed0e513d5d79953ef8683393eabcd2c34f44f4b0/security/chromiumos/lsm.c

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2018

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/4d7eae3cfb9640834d88de108d70d87877a1e022

commit 4d7eae3cfb9640834d88de108d70d87877a1e022
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Feb 15 10:33:16 2018

CHROMIUM: LSM: add more details to blocked symlink mount

Rewrite the current sb_mount hook to use report_load as that'll do the
same amount of command line display and will show the source path, then
add another log line to include the mount type and mount flags.

BUG= chromium:811506 
TEST=precq passes

Change-Id: Ibf93f82c51a5b40a41cb0031b9331d911ec3b943
Signed-off-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/919190
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>

[modify] https://crrev.com/4d7eae3cfb9640834d88de108d70d87877a1e022/security/chromiumos/lsm.c

Comment 4 by vapier@chromium.org, Feb 15 2018

could you re-run your tests now with those CLs ?  the logs should include more details as to the bad mounts triggering the crashes.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 16 2018

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/382e278a60230097fdd3c6cfb5b8477c5ccdfdd3

commit 382e278a60230097fdd3c6cfb5b8477c5ccdfdd3
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Feb 16 23:12:29 2018

CHROMIUM: LSM: add more details to blocked symlink mount

Rewrite the current sb_mount hook to use report_load as that'll do the
same amount of command line display and will show the source path, then
add another log line to include the mount type and mount flags.

BUG= chromium:811506 
TEST=precq passes

Change-Id: Ibf93f82c51a5b40a41cb0031b9331d911ec3b943
Signed-off-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/919874
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>

[modify] https://crrev.com/382e278a60230097fdd3c6cfb5b8477c5ccdfdd3/security/chromiumos/lsm.c

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 17 2018

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/9996f9ce793e052f59f5ae7d1efaa2489e0ecd70

commit 9996f9ce793e052f59f5ae7d1efaa2489e0ecd70
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Feb 17 02:47:56 2018

CHROMIUM: LSM: add more details to blocked symlink mount

Rewrite the current sb_mount hook to use report_load as that'll do the
same amount of command line display and will show the source path, then
add another log line to include the mount type and mount flags.

BUG= chromium:811506 
TEST=precq passes

Change-Id: Ibf93f82c51a5b40a41cb0031b9331d911ec3b943
Signed-off-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/919872
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>

[modify] https://crrev.com/9996f9ce793e052f59f5ae7d1efaa2489e0ecd70/security/chromiumos/lsm.c

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1f5f3578cbcfb65dddad3fb70038249120107372

commit 1f5f3578cbcfb65dddad3fb70038249120107372
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Fri Feb 23 11:36:55 2018

CHROMIUM: LSM: Deny mounting filesystems as exec in unprivileged userns

This change makes chromiumos_security_sb_mount() forbid mounting
filesystems without the MS_NOEXEC flag outside of the init namespace.

BUG= chromium:811506 
TEST=ARC can still boot
TEST=`mount -t tmpfs tmpfs /mnt` fails in an unprivileged userns
Signed-off-by: Luis Hector Chavez <lhchavez@chromium.org>

Change-Id: I40d22bdd637b1113bb53db7856bdd06331083cbd
Reviewed-on: https://chromium-review.googlesource.com/917210
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 132548e180ca9dcbc01c4f38e862cada3f118521)
Reviewed-on: https://chromium-review.googlesource.com/931744

[modify] https://crrev.com/1f5f3578cbcfb65dddad3fb70038249120107372/security/chromiumos/lsm.c

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1f5f3578cbcfb65dddad3fb70038249120107372

commit 1f5f3578cbcfb65dddad3fb70038249120107372
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Fri Feb 23 11:36:55 2018

CHROMIUM: LSM: Deny mounting filesystems as exec in unprivileged userns

This change makes chromiumos_security_sb_mount() forbid mounting
filesystems without the MS_NOEXEC flag outside of the init namespace.

BUG= chromium:811506 
TEST=ARC can still boot
TEST=`mount -t tmpfs tmpfs /mnt` fails in an unprivileged userns
Signed-off-by: Luis Hector Chavez <lhchavez@chromium.org>

Change-Id: I40d22bdd637b1113bb53db7856bdd06331083cbd
Reviewed-on: https://chromium-review.googlesource.com/917210
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 132548e180ca9dcbc01c4f38e862cada3f118521)
Reviewed-on: https://chromium-review.googlesource.com/931744

[modify] https://crrev.com/1f5f3578cbcfb65dddad3fb70038249120107372/security/chromiumos/lsm.c

Comment 9 by vapier@chromium.org, Feb 23 2018

yusukes: can you retest with ToT and see if you can get better logs out of the system ?
Components: OS>Systems
Owner: vapier@chromium.org
Status: Fixed (was: Unconfirmed)
assuming resolved now

Sign in to add a comment