Migrate chrome/browser/printing/cloud_print/privet_traffic_detector.h to using udp_socket.mojom |
||||
Issue descriptionchrome/browser/printing/cloud_print/privet_traffic_detector.h uses net::DatagramServerSocket. As a part of network servicification, all interactions with //net needs to be done through mojo APIs. Network Service has a mojo API for UDP sockets (see //services/network/public/interfaces/udp_socket.mojom). chrome/browser/printing/cloud_print/privet_traffic_detector.h needs to be migrated to using it. An example of migrating to udp_socket.mojom can be found in https://chromium-review.googlesource.com/c/chromium/src/+/904266.
,
May 18 2018
,
Jun 7 2018
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf41b7c19a4f8a10a55399774265aa820a1826c6 commit bf41b7c19a4f8a10a55399774265aa820a1826c6 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Mon Jul 23 19:53:31 2018 Migrate PrivetTrafficDetector from net::DatagramServerSocket to network::mojom::UDPSocket As part of the network servicification project, this CL replaces the use of net/ sockets in the PrivetTrafficDetector class with the UDP socket interfaces in the network service. Bug: 811497 Change-Id: I0f0295f032684b0e6a32de222760cfeb409c7d21 Reviewed-on: https://chromium-review.googlesource.com/1127268 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#577225} [modify] https://crrev.com/bf41b7c19a4f8a10a55399774265aa820a1826c6/chrome/browser/printing/cloud_print/privet_notifications.cc [modify] https://crrev.com/bf41b7c19a4f8a10a55399774265aa820a1826c6/chrome/browser/printing/cloud_print/privet_traffic_detector.cc [modify] https://crrev.com/bf41b7c19a4f8a10a55399774265aa820a1826c6/chrome/browser/printing/cloud_print/privet_traffic_detector.h
,
Jul 23
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dxie@chromium.org
, May 15 2018Status: Available (was: Untriaged)