VR: Update GVR keyboard version to 2 |
||||
Issue descriptionCurrently, CJK suggestions on the Daydream keyboard is broken. We need to use an API added in M26 to make sure this feature works.
,
Feb 27 2018
Is this Fixed?
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d0c6d984519cb71ec308f226289756d576ebdf1 commit 3d0c6d984519cb71ec308f226289756d576ebdf1 Author: Yash Malik <ymalik@google.com> Date: Tue Feb 27 23:32:09 2018 VR: Send controller touch information to the Daydream Keyboard This CL also moves gvr_keyboard_shim to use versioned structs for the API methods that are loaded. Bug: 811494 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I516187517973ccefc3a7cd4df075936be8c9fe44 Reviewed-on: https://chromium-review.googlesource.com/939862 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#539580} [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/android/vr/gvr_keyboard_delegate.cc [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/android/vr/gvr_keyboard_delegate.h [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/android/vr/gvr_keyboard_shim.cc [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/elements/keyboard.cc [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/elements/keyboard.h [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/keyboard_delegate.h [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/model/controller_model.h [modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/ui_scene_creator.cc
,
Feb 28 2018
,
Mar 1 2018
CJK - Chinese, Japanese, Korean. At a minimum we need to ensure we have Localization coverage in our test plans and understand how we are going to test it.
,
Mar 14 2018
We have Localization test cases that cover Text Entry, Permissions, and Password Entry. These test check Japanese and RTL languages. This should cover what we need here. The test verify string, dialog/text controls, and keyboard entry. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Feb 23 2018