New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811494 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Update GVR keyboard version to 2

Project Member Reported by ymalik@chromium.org, Feb 12 2018

Issue description

Currently, CJK suggestions on the Daydream keyboard is broken. We need to use an API added in M26 to make sure this feature works. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a853575033aa54c51eec99e1a451b13a913e503

commit 5a853575033aa54c51eec99e1a451b13a913e503
Author: Yash Malik <ymalik@google.com>
Date: Fri Feb 23 22:34:50 2018

VR: Update header to Keyboard API v2

Bug:  811494 
Change-Id: I4db9912240ac54e1883259d1981e6254b3600818
Reviewed-on: https://chromium-review.googlesource.com/935472
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538926}
[modify] https://crrev.com/5a853575033aa54c51eec99e1a451b13a913e503/third_party/gvr-android-keyboard/README.chromium
[modify] https://crrev.com/5a853575033aa54c51eec99e1a451b13a913e503/third_party/gvr-android-keyboard/src/libraries/headers/vr/gvr/capi/include/gvr_keyboard.h

Comment 2 by sko...@chromium.org, Feb 27 2018

Is this Fixed?
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d0c6d984519cb71ec308f226289756d576ebdf1

commit 3d0c6d984519cb71ec308f226289756d576ebdf1
Author: Yash Malik <ymalik@google.com>
Date: Tue Feb 27 23:32:09 2018

VR: Send controller touch information to the Daydream Keyboard

This CL also moves gvr_keyboard_shim to use versioned structs for the API
methods that are loaded.

Bug:  811494 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I516187517973ccefc3a7cd4df075936be8c9fe44
Reviewed-on: https://chromium-review.googlesource.com/939862
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539580}
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/android/vr/gvr_keyboard_delegate.cc
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/android/vr/gvr_keyboard_delegate.h
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/android/vr/gvr_keyboard_shim.cc
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/elements/keyboard.cc
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/elements/keyboard.h
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/keyboard_delegate.h
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/model/controller_model.h
[modify] https://crrev.com/3d0c6d984519cb71ec308f226289756d576ebdf1/chrome/browser/vr/ui_scene_creator.cc

Comment 4 by ymalik@chromium.org, Feb 28 2018

Status: Fixed (was: Available)
Labels: Test-Manual
CJK - Chinese, Japanese, Korean.
At a minimum we need to ensure we have Localization coverage in our test plans and understand how we are going to test it.
Labels: -Test-Manual Test-Complete
We have Localization test cases that cover Text Entry, Permissions, and Password Entry.  These test check Japanese and RTL languages.  This should cover what we need here.  The test verify string, dialog/text controls, and keyboard entry.

Sign in to add a comment