New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811486 link

Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 417782



Sign in to add a comment

RLS composited layer clip is off with scroll.

Project Member Reported by vmp...@chromium.org, Feb 12 2018

Issue description

Steps to repro:
1. Copy the following in a file:

<!DOCTYPE html>
<style>
#ofhidden {
  overflow: hidden;
}
#gradient {
  will-change: transform;
  background: linear-gradient(blue, yellow);
  width: 200px;
  height: 500px;
}
#red {
  width: 200px;
  height: 300px;
  background-color: red;
}
</style>

<div id="ofhidden">
  <div id="gradient"></div>
</div>
<div id="red"></div>

2. Open the file.
3. Make the window small enough to scroll.
4. Scroll to the bottom.
5. Refresh the page.
6. Scroll up.

Expected: Scrolls back up revealing the same content as before
Actual: Scrolls with a clip applied hiding some of the content.
 
Labels: -Pri-2 ReleaseBlock-Stable Pri-1
The bug is that the ancestor clipping layer needs to not be stored in the clip
cache with scrolling offset.
Cc: skobes@chromium.org bokan@chromium.org sahel@chromium.org szager@chromium.org ccameron@chromium.org chrishtr@chromium.org
 Issue 811837  has been merged into this issue.
Issue 811196 has been merged into this issue.
 Issue 811248  has been merged into this issue.
I have a fix, adding test now.
 Issue 811836  has been merged into this issue.

Comment 8 by vmp...@chromium.org, Feb 13 2018

Blocking: 417782
Issue 811915 has been merged into this issue.
Issue 811742 has been merged into this issue.
Issue 811400 has been merged into this issue.
Cc: nyerramilli@chromium.org manoranj...@chromium.org rbasuvula@chromium.org pbomm...@chromium.org
 Issue 811197  has been merged into this issue.
Issue 811992 has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a4bc70992c31fa240b3782af6dab0a9d28bdc51

commit 0a4bc70992c31fa240b3782af6dab0a9d28bdc51
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Wed Feb 14 04:43:34 2018

[RLS] Don't include scroll offset in cached clip for the position
of the ancestor clipping layer.

This regressed when we stopped storing clearing clip caches after
scroll of the root layer. It was an oversight to miss this callsite.

Bug:  811486 
Change-Id: Ie7b58304bd1cabfb1cd727bcdf0996d1c91e2e2c
Reviewed-on: https://chromium-review.googlesource.com/916722
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536645}
[add] https://crrev.com/0a4bc70992c31fa240b3782af6dab0a9d28bdc51/third_party/WebKit/LayoutTests/compositing/scroll-with-ancestor-clip-expected.png
[add] https://crrev.com/0a4bc70992c31fa240b3782af6dab0a9d28bdc51/third_party/WebKit/LayoutTests/compositing/scroll-with-ancestor-clip-expected.txt
[add] https://crrev.com/0a4bc70992c31fa240b3782af6dab0a9d28bdc51/third_party/WebKit/LayoutTests/compositing/scroll-with-ancestor-clip.html
[modify] https://crrev.com/0a4bc70992c31fa240b3782af6dab0a9d28bdc51/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp

 Issue 812136  has been merged into this issue.
 Issue 812100  has been merged into this issue.
Cc: vamshi.kommuri@chromium.org
 Issue 811946  has been merged into this issue.
Status: Fixed (was: Assigned)

Comment 21 by karlf...@gmail.com, Feb 14 2018

HI. This issue is not just with youtube.com. I was just on vudu.com and it'
just images of the movies and it's doing the same things. Screenshots
attached.

And, it's still happening with youtube.com. Screenshots also attached.

So, status NOT FIXED. Sorry.


-Karlfred


Karl Ziemer • Principal & Creative
Karlfred Design LLC • Design & Branding
Chicago • Indianapolis • Everywhere
Karlfred.net • 312.554.5899
Re comment 21: what version of Chrome are you testing on?
Fix issue verified on latest webview version  66.0.3348.0 as per #4.

Tested devices:Htc Desire 630/6.0.1/MMB29M,Samsung Galaxy J5 SM-J500F/MMB29M

Thanks!
This issue is now not reproducible on latest M-66 on following steps mentioned @#11, verified on Pixel2/OPM1.171019.024

Comment 25 Deleted

Comment 26 by mar...@mwiacek.com, Feb 17 2018

66.0.3350.0, even more horrible effect visible: https://bugs.chromium.org/p/chromium/issues/detail?id=813329

fix for current issue should be there (pls duplicate 813329 then) or this is something new (and pls help with 813329 then)
Labels: TE-Verified-M66 TE-Verified-66.0.3350.3
Tested this issue on 66.0.3350.3/10427.0.0 dev-channel Daisy,Reks by following the steps mentioned 

Observed Scrolls back up revealing the same content as before
Attached is the screen shot for reference.

Hence adding TE-Verified labels as this is working as expected.

Thanks..
811197.webm
10.9 MB View Download
Issue 811219 has been merged into this issue.

Sign in to add a comment