New issue
Advanced search Search tips

Issue 811483 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl format inconsistent wrapping in .typemap files

Project Member Reported by lucmult@chromium.org, Feb 12 2018

Issue description

Running git cl format generated the following code excerpt: 

...
traits_headers =
    [ "//content/common/cache_storage/cache_storage_mojom_traits.h" ]
sources = [
  "//content/common/cache_storage/cache_storage_mojom_traits.cc",
]
deps = [
  "//mojo/public/cpp/bindings",
]
...

The handle of trailing comma and opening/closing brackets seems inconsistent between traits_headers and sources/deps.

I would expect the following output:
...
traits_headers = [ 
  "//content/common/cache_storage/cache_storage_mojom_traits.h",
]
sources = [
  "//content/common/cache_storage/cache_storage_mojom_traits.cc",
]
deps = [
  "//mojo/public/cpp/bindings",
]
...

OR: 
...
traits_headers = 
    [ "//content/common/cache_storage/cache_storage_mojom_traits.h" ]
sources =
    [ "//content/common/cache_storage/cache_storage_mojom_traits.cc" ]
deps = [ "//mojo/public/cpp/bindings" ]
...


 

Sign in to add a comment