New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 811472 link

Starred by 1 user
Status: Verified
Owner:
█ dcreager@chromium.org
Last visit > 30 days ago
Closed: Oct 4
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Reporting / Network Error Logging: Allow Cronet embedders to preload configs.

Project Member Reported by juliatut...@chromium.org, Feb 12 2018 
Apps that embed Cronet may (should?) want to preload Reporting and NEL configurations for their domains to avoid the "the network was broken the whole time so we never knew to report the errors" problem.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cba7d22660a7105ae9c4948ba4f338da03e92b33

commit cba7d22660a7105ae9c4948ba4f338da03e92b33
Author: Julia Tuttle <juliatuttle@chromium.org>
Date: Fri Feb 23 19:37:27 2018

Network Error Logging: Get rid of abstract Delegate.

Use Service directly, since it's all in //net anyway.

Bug:  811472 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If76628a56aa9e9e1b463f40f5ade4e3c50b506ed
Reviewed-on: https://chromium-review.googlesource.com/919421
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538862}
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/BUILD.gn
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/network_error_logging/network_error_logging_end_to_end_test.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/network_error_logging/network_error_logging_service.h
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/network_error_logging/network_error_logging_service_unittest.cc
[delete] https://crrev.com/e88d5af61c3a994f4b8b3a7198753f7cca0893fa/net/url_request/network_error_logging_delegate.cc
[delete] https://crrev.com/e88d5af61c3a994f4b8b3a7198753f7cca0893fa/net/url_request/network_error_logging_delegate.h
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/url_request/url_request.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/url_request/url_request_context.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/url_request/url_request_context.h
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/url_request/url_request_context_storage.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/url_request/url_request_context_storage.h
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/cba7d22660a7105ae9c4948ba4f338da03e92b33/services/network/network_context_unittest.cc

Comment 2 by juliatut...@chromium.org, May 23 2018

Owner: dcreager@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a220947e6eb373c5cf857808922919dc272c70e5

commit a220947e6eb373c5cf857808922919dc272c70e5
Author: Douglas Creager <dcreager@chromium.org>
Date: Thu Aug 23 20:08:53 2018

Cronet: Let embedders preload Reporting/NEL headers

This lets non-browser native apps preconfigure a list of domain names
under their control, and allow Reporting and NEL to collect reports
about those domains before receiving configuration headers from actual
responses.  (Note that once a policy header is received in an actual
response, that will take precedence over any preconfigured headers.)

Bug:  811472 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5e64020e5f75485c676dd0751f1dc444fb07e472
Reviewed-on: https://chromium-review.googlesource.com/1171112
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585596}
[modify] https://crrev.com/a220947e6eb373c5cf857808922919dc272c70e5/components/cronet/cronet_url_request_context.cc
[modify] https://crrev.com/a220947e6eb373c5cf857808922919dc272c70e5/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/a220947e6eb373c5cf857808922919dc272c70e5/components/cronet/url_request_context_config.h
[modify] https://crrev.com/a220947e6eb373c5cf857808922919dc272c70e5/components/cronet/url_request_context_config_unittest.cc

Comment 4 by dcreager@chromium.org, Oct 4

Status: Verified (was: Started)
►

Sign in to add a comment