New issue
Advanced search Search tips

Issue 811441 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: Feb 2018
Cc:
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a callback parameter to update_client::PingManager::Send

Project Member Reported by sorin@chromium.org, Feb 12 2018 
The callback is needed in some unit tests.

Also, it makes the API design for non-blocking public functions in update_client more consistent: they return void and take a callback as a parameter.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/560d5025dc7afae33b25f3ac3a2e2556f60ef73d

commit 560d5025dc7afae33b25f3ac3a2e2556f60ef73d
Author: Sorin Jianu <sorin@chromium.org>
Date: Mon Feb 12 23:11:54 2018

Add a callback parameter to update_client::PingManager::Send

In addition to this, refactor some of the related types to use ref counting
to avoid the self delete and ownership issues.

Bug:  811441 

Change-Id: Ib4bf139a74b63d34d4fb5359585db69d9261c362
Reviewed-on: https://chromium-review.googlesource.com/914408
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536235}
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/ping_manager.cc
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/ping_manager.h
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/update_client.cc
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/update_client_internal.h
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/update_engine.cc
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/update_engine.h
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/url_request_post_interceptor.cc
[modify] https://crrev.com/560d5025dc7afae33b25f3ac3a2e2556f60ef73d/components/update_client/url_request_post_interceptor.h

Comment 2 by sorin@chromium.org, Feb 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment