Users that +1 a CL are not highlighted properly after adding new reviewers |
||||||
Issue descriptionAffected Version: What steps will reproduce the problem? 1. Create a CL and get it LGTMed by one person. 2. Add a new reviewer whose user name sorts alphabetically before the old reviewer's. What is the expected output? The green highlight should stay on the original reviewer. What do you see instead? The green highlight stays in the first position and thus against the wrong reviewer. Can see this here: https://screenshot.googleplex.com/JmrbEr1Nukn.png Note it doesn't match the +1s below it. Those are correct. Also reloading the page fixes the problem.
,
Feb 12 2018
,
Feb 12 2018
,
Feb 12 2018
,
Feb 12 2018
,
Feb 14 2018
+sadrul for chromite butler
,
Feb 14 2018
I will attempt to fix this weekend. (it'd probably be a bit icky to update because of how gerrit doesn't do real navigations, so it'd likely be necessary to install MutationObservers to look for dom changes, which isn't super nice).
,
Jan 11
Setting defect without priority to Pri-2.
,
Jan 11
Setting defect without priority to Pri-2. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wyatta@google.com
, Feb 12 2018