Issue metadata
Sign in to add a comment
|
5.3% regression in blink_perf.image_decoder at 534399:534541 |
||||||||||||||||||||
Issue descriptionThis test looks bimodal, bisecting to see if there may actually be a land/revert pattern causing this.
,
Feb 12 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16dd2d2d840000
,
Feb 13 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/16dd2d2d840000
,
Feb 13 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12f21b8d840000
,
Feb 14 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/12f21b8d840000 [AFDO] Roll Android's profile to 66.0.3336.3_rc-r1 by gbiv@chromium.org https://chromium.googlesource.com/chromium/src/+/d07b07609f7b538fdbb09f6c06ccba20218f2e9b [CI] Make GraphicsLayer::client_ a reference by wangxianzhu@chromium.org https://chromium.googlesource.com/chromium/src/+/3e9396db587c6ada6fd6815b2bb6aa2a429b0708 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 14 2018
My CL just changed a pointer which is never null to a reference, which doesn't affect binary code except that some unnecessary null pointer checks are eliminated, so it should not affect performance.
,
Feb 14 2018
Prior work: https://bugs.chromium.org/p/chromium/issues/detail?id=799629. It was noted on said bug that blink benchmarks, from the perspective of AFDO, are heavily micro-benchmark-y. That said, I have some blink-related investigation to finish on that bug; I'll fold this into that. Keeping this in its own bug because this was introduced by a new profile, not by turning AFDO as a whole on.
,
Aug 15
Automatic message: All alerts recovered. Graphs: https://chromeperf.appspot.com/group_report?bug_id=811413
,
Aug 15
Can't see any obvious+persistent AFDO-related flakiness recently, so I'm closing this. If I missed something, tracking for general AFDO stability over time is in issue 849881. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 12 2018