New issue
Advanced search Search tips

Issue 811394 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Build error

Reported by juanka85...@gmail.com, Feb 12 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36

Steps to reproduce the problem:
1. Build chromium
2. See the error

What is the expected behavior?
Build it

What went wrong?
https://p.teknik.io/Raw/6xGWR

Did this work before? Yes 66.0.3344.0

Chrome version: 64.0.3282.119  Channel: canary
OS Version: 66.0.3345.0
Flash Version: no

i build using clang 6 (from google)
 
glibc 226
../../content/browser/loader/signed_exchange_header.cc:16:21: note: in instantiation of function template specialization 'std::map<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char>, std::less<std::__cxx11::basic_string<char> >, std::allocator<std::pair<const std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > > >::insert<std::pair<base::BasicStringPiece<std::string>, base::BasicStringPiece<std::string> >, void>' requested here
  response_headers_.insert(std::make_pair(name, value));

Components: -Internals>Installer Build
Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09bc8299ab35fd1e303ab0cd68abd14d6ae4faad

commit 09bc8299ab35fd1e303ab0cd68abd14d6ae4faad
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Feb 14 01:26:46 2018

Fix build with libstdc++

libstdc++ couldn't do the implicit conversion from base::StringPiece
to std::string.

BUG= 811394 
R=ksakamoto
CC=​​kouhei
TBR=csharrison

Change-Id: Ideaee888f1a0eb764ac06e90a1556693fc9ed36c
Reviewed-on: https://chromium-review.googlesource.com/914699
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536589}
[modify] https://crrev.com/09bc8299ab35fd1e303ab0cd68abd14d6ae4faad/content/browser/loader/signed_exchange_header.cc

Status: Fixed (was: Started)

Sign in to add a comment