Add mips support for wpr_go
Reported by
djordje....@mips.com,
Feb 12 2018
|
||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 Steps to reproduce the problem: Try running smoothness.top_25_pages perf test on MIPS linux platform, for instance. What is the expected behavior? What went wrong? Fails with message saying there is no wpr_go binary for MIPS available locally or on google cloud. Did this work before? No Chrome version: <Copy from: 'about:version'> Channel: stable OS Version: Flash Version: Shockwave Flash 28.0 r0 After building wpr_go manually using src/third_party/catapult/telemetry/bin/update_wpr_go_binary script as a reference, and modifying telemetry/telemetry/internal/binary_dependencies.json to add MIPS binary, tests are now executed. (given that respective page set is already recorded using wpr_record)
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/b0a56d0e9ce21c5852663cb6e66ab025cf702c40 commit b0a56d0e9ce21c5852663cb6e66ab025cf702c40 Author: Djordje Golubovic <djordje.golubovic@mips.com> Date: Tue Feb 13 12:39:10 2018 Add MIPS wpr_go binary support. This enables running performance tests using wpr_go on MIPS platforms. Bug: chromium:811393 Change-Id: I67929fdf3a82e8d1db691a8015b06e1005ba519d Reviewed-on: https://chromium-review.googlesource.com/914725 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/b0a56d0e9ce21c5852663cb6e66ab025cf702c40/telemetry/telemetry/internal/binary_dependencies.json [modify] https://crrev.com/b0a56d0e9ce21c5852663cb6e66ab025cf702c40/telemetry/bin/update_wpr_go_binary
,
Feb 14 2018
,
Feb 14 2018
Additional code review regarding this issue, for reference: crrev.com/c/917061 |
||
►
Sign in to add a comment |
||
Comment 1 by djordje....@mips.com
, Feb 12 2018