New issue
Advanced search Search tips

Issue 811390 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Luci migration app: change experimental percentages from 1% to 10%

Project Member Reported by bpastene@chromium.org, Feb 12 2018

Issue description

It just has incremental ticks, which makes it difficult to determine the actual percentage value at a glance.

ie: Try to determine the percentage in the attached screen cap.
 
luci_slider.png
10.1 KB View Download

Comment 1 by no...@chromium.org, Feb 12 2018

my rationale was that precision is not important there. What difference does it make if it is 65% or 67%?
It may not be important, but it's nice to have. We were instructed to incrementally increase experimental traffic. I'd like to do 10% every step, but the imprecise slider makes that difficult.

The builder list for a master in the migration console has precise values for experimental percentage. Since it "doesn't make a difference", why not round the values to the nearest 10%?

Comment 3 by no...@chromium.org, Feb 12 2018

Labels: -Type-Bug Type-Feature
Owner: no...@chromium.org
Status: Started (was: Unconfirmed)
Summary: Luci migration app: change experimental percentages from 1% to 10% (was: Luci migration app: Add numeric indicator to "Experiment percentage" slider)
SG
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9ecb59112b928fdc7e2134c5a7de01184558017c

commit 9ecb59112b928fdc7e2134c5a7de01184558017c
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Feb 12 23:51:19 2018

[luci-migration] change exp percentage with 10% increments

Make UI less confusing by preventing setting experiment percentage to values
that are not divisable by 10.

Bug:  811390 
Change-Id: I0ae29e6a9bd4d44240c9f8b73ab3a8095884990d
Reviewed-on: https://chromium-review.googlesource.com/915026
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/9ecb59112b928fdc7e2134c5a7de01184558017c/go/src/infra/appengine/luci-migration/app/templates/pages/builder.html
[modify] https://crrev.com/9ecb59112b928fdc7e2134c5a7de01184558017c/go/src/infra/appengine/luci-migration/app/builder_test.go
[modify] https://crrev.com/9ecb59112b928fdc7e2134c5a7de01184558017c/go/src/infra/appengine/luci-migration/app/builder.go

Comment 5 by no...@chromium.org, Feb 13 2018

Status: Fixed (was: Started)
try it out!
ummm, #4 didn't fix the issue I had filed

The original title of this bug was what I was requesting. And it would still be nice to have. But I can do without, so you can wontfix it.

Comment 7 by no...@chromium.org, Feb 14 2018

Status: WontFix (was: Fixed)
ok, I assumed Description field fully describes the bug and Summary summarizes the Description.

Sign in to add a comment