New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811388 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Security



Sign in to add a comment

Pixelbook remains in mirrored mode after disconnecting external display

Project Member Reported by hhg@google.com, Feb 12 2018

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10032.86.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.140 Safari/537.36
Platform: Pixelbook

Steps to reproduce the problem:
1. Log in
2. Close screen
3. Open screen

What is the expected behavior?
Chromebook prompts for password

What went wrong?
Chromebook does not prompt for password

Did this work before? N/A 

Chrome version: 63.0.3239.140  Channel: n/a
OS Version: 10032.86.0
Flash Version: Chrome63.0.3239.140

b/73117493 in buganizer has attachments with video evidence and the output of chrome://policy. Mike Harris (mwharris@) commented, "ChromeOsLockOnIdleSuspend is set, so this is likely a Chrome OS bug."
I observe that it appears time-dependent: opening quickly does not require password, but after waiting some numbner of minutes it does prompt for one.
 
Cc: r...@chromium.org
Labels: Security_Impact-Stable
Owner: derat@chromium.org
Over to derat@ and rkc@ for triage.

We need more information on whether locking is just delayed or just doesn't happen in some cases before deciding severity.

Comment 2 by r...@chromium.org, Feb 16 2018

Cc: jdufault@chromium.org

Comment 3 by r...@chromium.org, Feb 16 2018

Cc: tbarzic@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 16 2018

Status: Assigned (was: Unconfirmed)

Comment 5 by derat@chromium.org, Feb 16 2018

Cc: tbroch@chromium.org osh...@chromium.org afakhry@chromium.org
Components: UI>Shell>LockScreen OS>Kernel>Power UI>Shell>MultipleMonitor
Feedback report is at http://feedback/#/Report/85040755813 -- thanks!

The system is entering docked mode (rather than suspending) because Chrome reported that there's another display attached:

[0208/130910:INFO:daemon.cc(1412)] Chrome is using presentation display mode
[0208/130911:INFO:daemon.cc(1430)] Received updated external policy: ac_dim=7m ac_screen_off=8m ac_lock=0s ac_idle_warn=0s ac_idle=30m battery_dim=5m battery_screen_off=6m battery_lock=0s battery_idle_warn=0s battery_idle=10m ac_idle=suspend battery_idle=shutdown lid_closed=shutdown use_audio=1 use_video=1 presentation_factor=2.0 user_activity_factor=2.0 wait_for_initial_user_activity=0 force_nonzero_brightness_for_user_activity=1 (Prefs)
...
[0208/130913:INFO:daemon.cc(1412)] Chrome is using presentation display mode
...
[0208/130945:INFO:daemon.cc(507)] Lid closed
[0208/130945:INFO:input_device_controller.cc(292)] Configuring devices for mode "docked"
...
[0208/130946:INFO:state_controller.cc(970)] Ready to perform lid-closed action (no-op)
...
[0208/130950:INFO:daemon.cc(516)] Lid opened

I can see in the video that there's no display connected via Type-C, but I think that Chrome also reports external displays if you're casting or sharing your screen. Any chance that either of those things was happening when you saw this? If so, this is a dupe of issue 488091.
Labels: Security_Severity-Low
SecSev-Low based on Dan's comment.

Comment 7 by hhg@google.com, Feb 16 2018

There is no attached screen when I have the issue, and I am not casting or sharing. However, I do use my laptop both in attached screen mode and as a laptop, and I have noticed that it continues to think that there is an attached screen even when there is not: it reports "Mirroring to SyncMaster". Furthermore, there are occasions when it is possible to the mouse past the border of the screen, although it doesn't always happen.
Labels: -Security_Severity-Low Security_Severity-Medium
Hmmm interesting. This does look like a real bug. Marking as Medium.

Comment 9 by derat@chromium.org, Feb 16 2018

Cc: dnicoara@chromium.org derat@chromium.org dbehr@chromium.org marc...@chromium.org
Components: OS>Kernel>Display
Owner: marc...@chromium.org
Summary: Pixelbook remains in mirrored mode after disconnecting external display (was: Pixelbook fails to lock on screen close)
Adding some more people who might have ideas about why Chrome (or the kernel?) is getting confused.

Healfdene, what kind of Type-C dock or adapter and display are you using?
Owner: afakhry@chromium.org
Does appear userspace thinks we never lost the external display (cut-n-paste from ADB combined view below).  

In particular the display_configurator.cc DISPLAY= log lines below think external display is still there.

modetest as well believes external display is there which may indicate that the hotplug detect never deasserted


018-02-08 13:09:45.000 6 state_controller.cc(923):  Turning panel off after entering docked mode
2018-02-08 13:09:45.000 6 display_power_setter.cc(81):  Asking DisplayService to turn internal display off and external displays on
2018-02-08 13:09:45.425 8 31383:31383: display_configurator.cc(864): SetDisplayPower: power_state=INTERNAL_OFF_EXTERNAL_ON flags=0, configure timer=Stopped
2018-02-08 13:09:45.426 4 31495:31510: screen_manager.cc(114): Display controller (crtc=32) already present.
2018-02-08 13:09:45.426 4 31495:31510: screen_manager.cc(114): Display controller (crtc=39) already present.
2018-02-08 13:09:45.426 8 31383:31383: display_configurator.cc(912): Display snapshots invalidated.
2018-02-08 13:09:45.426 8 31383:31383: update_display_configuration_task.cc(69): OnDisplaysUpdated: new_display_state=SINGLE new_power_state=INTERNAL_OFF_EXTERNAL_ON flags=0 force_configure=0 display_count=2
2018-02-08 13:09:45.426 8 31383:31383: display_configurator.cc(212): EnterState: display=SINGLE power=INTERNAL_OFF_EXTERNAL_ON
2018-02-08 13:09:45.426 8 31495:31510: drm_display.cc(105): DRM configuring: device=/sys/devices/pci0000:00/0000:00:02.0/drm/card0 crtc=32 connector=48 origin=0,0 size=0x0
2018-02-08 13:09:45.571 8 31383:31383: display_configurator.cc(877): SetDisplayMode: state=DUAL_MIRROR
2018-02-08 13:09:45.577 8 31383:31383: instance_holder.h(67): Instance ar<IPv6: 2>mojom<IPv6: 3>RotationLockInstance not available.
2018-02-08 13:09:45.577 8 31383:31383: instance_holder.h(67): Instance ar<IPv6: 2>mojom<IPv6: 3>RotationLockInstance not available.
2018-02-08 13:09:46.000 6 internal_backlight_controller.cc(677):  Setting brightness to 0 (0%) over 0 ms
2018-02-08 13:09:46.000 6 state_controller.cc(970):  Ready to perform lid-closed action (no-op)
2018-02-08 13:09:46.000 6 daemon.cc(1412):  Chrome is using presentation display mode
2018-02-08 13:09:46.000 6 ambient_light_handler.cc(195):  Hysteresis overcome; transitioning to 36.14% (step 0) for lux 0 (panel)
2018-02-08 13:09:46.000 6 daemon.cc(771):  On battery at 64% (displayed as 65%), 3.523/5.486Ah at 1.484A, 3h12m28s until empty (3h3m29s until shutdown)
2018-02-08 13:09:46.159 8 31495:31510: drm_display.cc(105): DRM configuring: device=/sys/devices/pci0000:00/0000:00:02.0/drm/card0 crtc=39 connector=56 origin=0,0 size=1920x1200
2018-02-08 13:09:46.278 8 31383:31383: display_configurator.cc(1016): OnConfigured: success=1 new_display_state=SINGLE new_power_state=INTERNAL_OFF_EXTERNAL_ON
2018-02-08 13:09:46.311 8 31383:31383: instance_holder.h(67): Instance ar<IPv6: 2>mojom<IPv6: 3>RotationLockInstance not available.
2018-02-08 13:09:46.325 3 31383:31383: render_widget_host_view_base.cc(323): Not implemented reached in virtual void content<IPv6: 3>RenderWidgetHostViewBas<IPv6: 1>SetInsets(const gfx<IPv6: 3>Insets &)
2018-02-08 13:09:46.327 8 31383:31383: instance_holder.h(67): Instance ar<IPv6: 2>mojom<IPv6: 3>RotationLockInstance not available.
2018-02-08 13:09:46.565 3 31383:31490: service_manager.cc(157): Connection InterfaceProviderSpec prevented service: content_browser from binding interface: content<IPv6: 3>mojom<IPv6: 4>hild exposed by: nacl_loader
2018-02-08 13:09:46.565 3 31383:31490: service_manager.cc(157): Connection InterfaceProviderSpec prevented service: content_browser from binding interface: content<IPv6: 3>mojom<IPv6: 4>hild exposed by: nacl_loader
2018-02-08 13:09:46.583 3 31383:31490: service_manager.cc(157): Connection InterfaceProviderSpec prevented service: content_browser from binding interface: content<IPv6: 3>mojom<IPv6: 4>hildHistogramFetcherFactory exposed by: nacl_loader
2018-02-08 13:09:46.583 3 31383:31490: service_manager.cc(157): Connection InterfaceProviderSpec prevented service: content_browser from binding interface: content<IPv6: 3>mojom<IPv6: 4>hildHistogramFetcherFactory exposed by: nacl_loader
2018-02-08 13:09:46.583 3 31383:31490: [1,698058624:18:09:46.583884] Native Client module will be loaded at base address 0x00004f3b00000000
2018-02-08 13:09:47.000 6 daemon.cc(1412):  Chrome is using presentation display mode
2018-02-08 13:09:47.000 6 ambient_light_handler.cc(195):  Hysteresis overcome; transitioning to 60% (step 0) for lux 0 (keyboard)
2018-02-08 13:09:47.000 6 activity_logger.cc(20):  Audio activity stopped
2018-02-08 13:09:47.330 4 31495:31510: screen_manager.cc(114): Display controller (crtc=32) already present.
2018-02-08 13:09:47.330 4 31495:31510: screen_manager.cc(114): Display controller (crtc=39) already present.
2018-02-08 13:09:47.330 8 31383:31383: display_configurator.cc(912): Display snapshots invalidated.
2018-02-08 13:09:47.330 8 31383:31383: update_display_configuration_task.cc(69): OnDisplaysUpdated: new_display_state=DUAL_MIRROR new_power_state=INTERNAL_OFF_EXTERNAL_ON flags=0 force_configure=0 display_count=2
2018-02-08 13:09:47.331 8 31383:31383: display_configurator.cc(212): EnterState: display=DUAL_MIRROR power=INTERNAL_OFF_EXTERNAL_ON
2018-02-08 13:09:47.331 4 31383:31383: display_configurator.cc(272): Ignoring request to enter mirrored mode with 2 connected display(s) and 1 turned on
2018-02-08 13:09:47.331 8 31383:31383: display_configurator.cc(212): EnterState: display=MULTI_EXTENDED power=INTERNAL_OFF_EXTERNAL_ON
2018-02-08 13:09:47.331 8 31495:31510: drm_display.cc(105): DRM configuring: device=/sys/devices/pci0000:00/0000:00:02.0/drm/card0 crtc=32 connector=48 origin=0,0 size=0x0
2018-02-08 13:09:47.331 8 31495:31510: drm_display.cc(105): DRM configuring: device=/sys/devices/pci0000:00/0000:00:02.0/drm/card0 crtc=39 connector=56 origin=0,1660 size=1920x1200
2018-02-08 13:09:47.431 8 31383:31383: display_configurator.cc(1016): OnConfigured: success=1 new_display_state=MULTI_EXTENDED new_power_state=INTERNAL_OFF_EXTERNAL_ON
2018-02-08 13:09:48.717 4         : shill[976]: [WARNING:traffic_monitor.cc(226)] DNS queries failing, out-of-credits?
2018-02-08 13:09:50.000 6 daemon.cc(516):  Lid opened
Owner: weidongg@chromium.org
Project Member

Comment 14 by sheriffbot@chromium.org, Feb 17 2018

Labels: M-65
Project Member

Comment 15 by sheriffbot@chromium.org, Feb 17 2018

Labels: -Pri-2 Pri-1
I recently fixed a bug in which tablet mode is triggered when lid is closed ( issue 790720 ), not sure whether it is related.

Now I could not repro this issue in ToT.

Steps:
1. Log in my gmail account.
2. Make sure "Sleep when lid is closed" is turned on in chrome://settings/power
3. Make sure "Show lock screen when waking from sleep" is turned on in chrome:://settings/lockScreen
4. Close lid, and reopen.
5. Enter lock screen.


Project Member

Comment 17 by sheriffbot@chromium.org, Mar 7 2018

weidongg: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by sheriffbot@chromium.org, Mar 22 2018

weidongg: Uh oh! This issue still open and hasn't been updated in the last 29 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hi hhg@, can you still repro this on ToT?

Comment 20 by hhg@google.com, Apr 3 2018

I have not been able to reproduce for some time, I think we can close as obsolete.

Status: WontFix (was: Assigned)
Thanks for following up.
Project Member

Comment 22 by sheriffbot@chromium.org, Jul 11

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment