[MD Extensions] Extension errors on chrome://extensions |
||||
Issue descriptionProblem 1. Errors are indicated in the Chrome menu icon (the three stacked dots) 2. When this happens I click on the three dots 3. The dropdown says something like "there was an extension error" 4. Click on said message, this opens the extension page. 5. No error is shown on any extension. 6. In case there are a lot of extensions, it is not apparent Fix 1. Highlight error with icon and in red in the card Color: Google Red 700. Icon: icons:error Size:18x18px 2. Call out the number of extensions that have errors at the top. Height of bar: 36px Images attached.
,
Feb 17 2018
,
Feb 20 2018
An update on this. Had a discussion with bettes@ and decided that extensions errors does not require a page-level bar since avg number of extensions per user is 5-6 and hence the bar will be redundant. So let's go with only point 1 of the the fix: Highlight error with icon and in red in the card. Rest is WAI. Also the error needs to be highlighted in the extensions details page as well. Mock attached.
,
Feb 21 2018
@namratakannan: Should the error icon have a 20x20 size instead of 18x18? 20x20 is the size we use in our shared style and it is used in multiple places, see [1] for definition, and [2] for usages. Or is this icon a special case, and should not follow the shared style? [1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_vars_css.html?l=23 [2] https://cs.chromium.org/search/?q=cr-icon-size+-file:third_party+-file:infra+-file:out/Debug&type=cs
,
Feb 22 2018
@namratakannan: On the extension details view, the other warnings have a triangle warning icon sized 19x19 and in paper red 700 color. I will add the run-time warning to the detail view along with the error icon following the design specified here. Should the warning icon be made consistent with error icon? On the extensions page, the run-time warning (error) text was already being displayed. I will add the error icon.
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/949cdb4a18baffc8c9a1b20c2faaab868154a583 commit 949cdb4a18baffc8c9a1b20c2faaab868154a583 Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Feb 23 02:15:16 2018 MD Extensions: add error icon to errors and warnings On the extensions page, add icon to existing errors and warnings text. On the extensions details page, add error text, error icon and reload button. Bug: 811387 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8479ac8bab6ea3e9168baa24008c7ed62d7196eb Reviewed-on: https://chromium-review.googlesource.com/929844 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#538666} [modify] https://crrev.com/949cdb4a18baffc8c9a1b20c2faaab868154a583/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/949cdb4a18baffc8c9a1b20c2faaab868154a583/chrome/browser/resources/md_extensions/detail_view.js [modify] https://crrev.com/949cdb4a18baffc8c9a1b20c2faaab868154a583/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/949cdb4a18baffc8c9a1b20c2faaab868154a583/chrome/test/data/webui/extensions/extension_detail_view_test.js
,
Feb 23 2018
,
Feb 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by karandeepb@chromium.org
, Feb 16 2018Status: Assigned (was: Untriaged)