New issue
Advanced search Search tips

Issue 811386 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 739232



Sign in to add a comment

Address presubmit warnings in //content/renderer/media/stream

Project Member Reported by mcasas@chromium.org, Feb 12 2018

Issue description

r536141 moved a few files from //content/renderer/media to //content/renderer/media/stream
`git cl upload` identified inconsistencies, probably modern style nits, etc.  


** Presubmit Warnings **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
  content/renderer/media/stream/media_stream_video_renderer_sink.cc:143
    void SetGpuMemoryBufferVideoForTesting(

Banned functions were used.
    content/renderer/media/stream/external_media_stream_audio_source.h:50:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/local_media_stream_audio_source.h:61:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_deliverer.h:132:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_processor.cc:156:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_processor.cc:262:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_processor.h:203:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_processor.h:205:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_processor_options.h:103:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_source.cc:85:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_audio_track.cc:98:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_audio_track.h:82:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_audio_track.h:98:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_track.h:101:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_audio_unittest.cc:116:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_audio_unittest.cc:225:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_device_observer.cc:47:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_device_observer.h:81:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_device_observer_unittest.cc:26:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_renderer_factory_impl.cc:54:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_renderer_factory_impl.h:20:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_source.h:20:
      Please consider using base::{Once,Repeating}Callback instead of base::Callback. (crbug.com/714018)
    content/renderer/media/stream/media_stream_source.h:23:
      Please consider using base::{Once,Repeating}Callback instead of base::Callback. (crbug.com/714018)
    content/renderer/media/stream/media_stream_source.h:72:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_track.h:50:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_video_capturer_source.cc:59:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source.cc:65:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source.cc:68:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_video_capturer_source.cc:103:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source.cc:222:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source.cc:254:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source_unittest.cc:56:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source_unittest.cc:71:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source_unittest.cc:79:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source_unittest.cc:97:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source_unittest.cc:113:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source_unittest.cc:142:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_capturer_source_unittest.cc:226:
      base::TimeXXX::FromInternalValue() and ToInternalValue() are
      deprecated (http://crbug.com/634507). Please avoid converting away
      from the Time types in Chromium code, especially if any math is
      being done on time values. For interfacing with platform/library
      APIs, use FromMicroseconds() or InMicroseconds(), or one of the other
      type converter methods instead. For faking TimeXXX values (for unit
      testing only), use TimeXXX() + TimeDelta::FromMicroseconds(N). For
      other use cases, please contact base/time/OWNERS.
    content/renderer/media/stream/media_stream_video_renderer_sink.cc:88:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_renderer_sink.cc:158:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_video_renderer_sink.cc:167:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_renderer_sink.cc:197:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_renderer_sink.h:48:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_renderer_sink.h:81:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_renderer_sink.h:95:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_video_renderer_sink_unittest.cc:56:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_renderer_sink_unittest.cc:58:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_renderer_sink_unittest.cc:205:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_renderer_sink_unittest.cc:207:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_source.cc:66:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_source.cc:375:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_source_unittest.cc:83:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_source_unittest.cc:98:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_source_unittest.cc:160:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_source_unittest.cc:181:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_source_unittest.cc:419:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_source_unittest.cc:430:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_track.cc:81:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_video_track.cc:266:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_track.cc:291:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_track_unittest.cc:51:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_track_unittest.cc:159:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_track_unittest.cc:170:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_track_unittest.cc:172:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/media_stream_video_track_unittest.cc:192:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/media_stream_video_track_unittest.cc:280:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/mock_media_stream_video_sink.cc:24:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/processed_local_audio_source.h:115:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/processed_local_audio_source_unittest.cc:106:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/remote_media_stream_track_adapter.cc:22:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/remote_media_stream_track_adapter.cc:62:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/remote_media_stream_track_adapter.h:87:
      Please consider using base::{Once,Repeating}Callback instead of base::Callback. (crbug.com/714018)
    content/renderer/media/stream/track_audio_renderer.h:176:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/user_media_processor.cc:124:
      Please consider using base::{Once,Repeating}Callback instead of base::Callback. (crbug.com/714018)
    content/renderer/media/stream/user_media_processor.cc:268:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/user_media_processor.cc:626:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/user_media_processor.cc:731:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/user_media_processor.cc:763:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/user_media_processor.cc:770:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/video_track_adapter.cc:114:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/video_track_adapter.h:56:
      Please consider using base::{Once,Repeating}Callback instead of base::Callback. (crbug.com/714018)
    content/renderer/media/stream/video_track_adapter.h:123:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/webaudio_media_stream_source.cc:17:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webaudio_media_stream_source.h:54:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/webmediaplayer_ms.cc:87:
      base::TimeXXX::FromInternalValue() and ToInternalValue() are
      deprecated (http://crbug.com/634507). Please avoid converting away
      from the Time types in Chromium code, especially if any math is
      being done on time values. For interfacing with platform/library
      APIs, use FromMicroseconds() or InMicroseconds(), or one of the other
      type converter methods instead. For faking TimeXXX values (for unit
      testing only), use TimeXXX() + TimeDelta::FromMicroseconds(N). For
      other use cases, please contact base/time/OWNERS.
    content/renderer/media/stream/webmediaplayer_ms.cc:130:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms.cc:148:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/webmediaplayer_ms.cc:255:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms.cc:259:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms.cc:365:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms.cc:583:
      base::TimeXXX::FromInternalValue() and ToInternalValue() are
      deprecated (http://crbug.com/634507). Please avoid converting away
      from the Time types in Chromium code, especially if any math is
      being done on time values. For interfacing with platform/library
      APIs, use FromMicroseconds() or InMicroseconds(), or one of the other
      type converter methods instead. For faking TimeXXX values (for unit
      testing only), use TimeXXX() + TimeDelta::FromMicroseconds(N). For
      other use cases, please contact base/time/OWNERS.
    content/renderer/media/stream/webmediaplayer_ms.cc:700:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms.cc:720:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms.cc:732:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms.h:271:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/webmediaplayer_ms_compositor.cc:154:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms_compositor.cc:271:
      base::TimeXXX::FromInternalValue() and ToInternalValue() are
      deprecated (http://crbug.com/634507). Please avoid converting away
      from the Time types in Chromium code, especially if any math is
      being done on time values. For interfacing with platform/library
      APIs, use FromMicroseconds() or InMicroseconds(), or one of the other
      type converter methods instead. For faking TimeXXX values (for unit
      testing only), use TimeXXX() + TimeDelta::FromMicroseconds(N). For
      other use cases, please contact base/time/OWNERS.
    content/renderer/media/stream/webmediaplayer_ms_compositor.cc:272:
      base::TimeXXX::FromInternalValue() and ToInternalValue() are
      deprecated (http://crbug.com/634507). Please avoid converting away
      from the Time types in Chromium code, especially if any math is
      being done on time values. For interfacing with platform/library
      APIs, use FromMicroseconds() or InMicroseconds(), or one of the other
      type converter methods instead. For faking TimeXXX values (for unit
      testing only), use TimeXXX() + TimeDelta::FromMicroseconds(N). For
      other use cases, please contact base/time/OWNERS.
    content/renderer/media/stream/webmediaplayer_ms_compositor.cc:291:
      base::TimeXXX::FromInternalValue() and ToInternalValue() are
      deprecated (http://crbug.com/634507). Please avoid converting away
      from the Time types in Chromium code, especially if any math is
      being done on time values. For interfacing with platform/library
      APIs, use FromMicroseconds() or InMicroseconds(), or one of the other
      type converter methods instead. For faking TimeXXX values (for unit
      testing only), use TimeXXX() + TimeDelta::FromMicroseconds(N). For
      other use cases, please contact base/time/OWNERS.
    content/renderer/media/stream/webmediaplayer_ms_compositor.cc:341:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms_compositor.cc:483:
      Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms_compositor.h:122:
      Consider using THREAD_CHECKER macros instead of the class directly.
    content/renderer/media/stream/webmediaplayer_ms_unittest.cc:133:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms_unittest.cc:159:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms_unittest.cc:199:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms_unittest.cc:370:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)
    content/renderer/media/stream/webmediaplayer_ms_unittest.cc:410:
      Please consider using base::{Once,Repeating}Closure instead of base::Closure. (crbug.com/714018)

content/renderer/media/stream/local_media_stream_audio_source.cc:34 OS_ANDROID macro is used without including build/build_config.h.
content/renderer/media/stream/media_stream_audio_processor_options.h:54 OS_ANDROID macro is used without including build/build_config.h.
content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc:166 OS_ANDROID macro is used without including build/build_config.h.
content/renderer/media/stream/processed_local_audio_source.cc:274 OS_MACOSX macro is used without including build/build_config.h.
content/renderer/media/stream/webmediaplayer_ms_unittest.cc:1053 OS_ANDROID macro is used without including build/build_config.h.

The src directory requires source formatting. Please run: git cl format 

Found unprefixed crbug.com URL(s), consider prepending https://
    content/renderer/media/stream/media_stream_device_observer.cc:99   // iterator from |label_stream_map_| ( crbug.com/616884 ). Future work needs to
    content/renderer/media/stream/webmediaplayer_ms.cc:314   // For more details, see  crbug.com/738379 


 

Comment 1 by mcasas@chromium.org, Feb 12 2018

Blocking: 810841
Labels: OS-Fuchsia OS-iOS

Comment 2 by mcasas@chromium.org, Feb 12 2018

Labels: -OS-Linux -OS-Android -OS-Windows -OS-iOS -OS-Chrome -OS-Mac -OS-Fuchsia

Comment 3 by guidou@chromium.org, Feb 13 2018

Status: Available (was: Unconfirmed)

Comment 4 by mcasas@chromium.org, Feb 15 2018

Blocking: -810841 739232
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32

commit 2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32
Author: Raul Tambre <raul@tambre.ee>
Date: Thu Dec 13 08:33:54 2018

Presubmit warning fixes in //content/renderer/media/stream

Refactored base::ThreadChecker to THREAD_CHECKER macros.
HTTPS-ified various links.
Converted typedefs to usings.
This CL has no functional changes.

Bug: 811386
Change-Id: I3152898ca646cfdea4a8773fd0c0ca9390421d52
Reviewed-on: https://chromium-review.googlesource.com/c/1356983
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616247}
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/AUTHORS
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/aec_dump_message_filter.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/apply_constraints_processor.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/external_media_stream_audio_source.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/external_media_stream_audio_source.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/local_media_stream_audio_source.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/local_media_stream_audio_source.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_audio_deliverer.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_audio_processor.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_audio_processor.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_audio_track.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_audio_track.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_center.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_constraints_util_audio.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_constraints_util_sets.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_constraints_util_video_content.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_device_observer.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_device_observer.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_source.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_source.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_track.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_video_capturer_source.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_video_renderer_sink.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_video_renderer_sink.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_video_source.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_video_source.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/media_stream_video_track.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/processed_local_audio_source.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/track_audio_renderer.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/user_media_client_impl.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/user_media_client_impl.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/user_media_client_impl_unittest.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/user_media_processor.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/video_track_adapter.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/video_track_adapter.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/webaudio_media_stream_source.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/webaudio_media_stream_source.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/2f450d9193ff3a2a2810dd0d3c056ee7d0d4ce32/content/renderer/media/stream/webmediaplayer_ms_unittest.cc

Sign in to add a comment