Issue metadata
Sign in to add a comment
|
Network.setRequestInterception stopped working
Reported by
valerybu...@gmail.com,
Feb 12 2018
|
||||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36
Steps to reproduce the problem:
1. In background script of unpacked chrome extension:
chrome.debugger.attach(debuggee, "1.2", () => {
chrome.debugger.sendCommand(debuggee, "Network.setRequestInterception", { patterns: [{ urlPattern: "*" }] })
chrome.debugger.sendCommand(debuggee, "Network.enable")
})
2. Subscribe to events:
chrome.debugger.onEvent.addListener((source, method, params) => {
console.log(method)
})
3. Navigate to localhost for example.
4. Notice that only Network events are logged, without any Interception events.
What is the expected behavior?
Interception events are emitted along with Network events.
What went wrong?
No observed Interception events.
Did this work before? N/A
Does this work in other browsers? N/A
Chrome version: 64.0.3282.140 Channel: stable
OS Version: OS X 10.13.2
Flash Version:
It worked for me a couple of weeks ago, not sure if API just changed with Chrome update or something else. Couldn't find any info about that.
,
Feb 12 2018
,
Feb 12 2018
valery, could you help us out and create a small standalone extension with these calls in it?
,
Feb 12 2018
I just tried it on m64 and it works for me.
,
Feb 13 2018
valerybugakov@ Thanks for the issue. As per comment #3, adding Needs-Feedback label. Please provide sample extension which will help in further triaging of the issue. Thanks..
,
Feb 24 2018
,
Feb 25 2018
I don't see how the script at #6 is supposed to work on any version, given is awaits requestIntercepted (line 24) before it performs any network activity (line #34).
,
Feb 25 2018
@caseq
requestIntercepted is a devtools protocol method, it registers a callback to be called whenever a network request is going to be performed.
Anyway, it is supposed to work because with protocol 1.2 it worked on previous chromium versions-according to method name changes etc.
It turns out that now you need to add :
chromeFlags: [
"--test-type"
]
in order for the previous script to work - test_no_request_interception.js.
Attaching the new script wich works.
I'm sorry but it's really frustrating and time consuming to keep up with all these frequent breaking changes with Devtools and Google Chrome.
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c806b8b802c5bcd93831229bedd8164d8a68a26 commit 4c806b8b802c5bcd93831229bedd8164d8a68a26 Author: Andrey Kosyakov <caseq@chromium.org> Date: Fri Dec 28 20:17:50 2018 DevTools: enable only one DevToolsURLRequestInterceptor per BrowserContext Bug: 811385 , 764505 Change-Id: I924aa64f71b2012f21ce0dc7e309cf354bbeb6e4 Reviewed-on: https://chromium-review.googlesource.com/c/1391678 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619186} [modify] https://crrev.com/4c806b8b802c5bcd93831229bedd8164d8a68a26/content/browser/devtools/devtools_url_request_interceptor.cc [modify] https://crrev.com/4c806b8b802c5bcd93831229bedd8164d8a68a26/content/browser/devtools/devtools_url_request_interceptor.h [modify] https://crrev.com/4c806b8b802c5bcd93831229bedd8164d8a68a26/content/browser/storage_partition_impl_map.cc
,
Dec 29
,
Jan 10
,
Jan 10
,
Jan 10
Issue 836423 has been merged into this issue. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by valerybu...@gmail.com
, Feb 12 2018