Implement chrome://connection-help AboutUI |
||||||
Issue descriptionAs part of go/httphelpcontent, there should be a subset of support.google.com/chrome/answer/6098869 available at chrome://connection-help for users who can't make https connections.
,
Feb 13 2018
Screenshot of what the current implementation looks like:
,
Feb 14 2018
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/766fbc88bed0c117536f00aab036aef7851a3c03 commit 766fbc88bed0c117536f00aab036aef7851a3c03 Author: Carlos IL <carlosil@chromium.org> Date: Fri Feb 16 02:34:52 2018 Added AboutUI page for connection-help. Added an AboutUI page for chrome://connection-help, that displays a subset of the information available at support.google.com/chrome/answer/6098869. On a separate CL, logic will be added to redirect users who visit the online help center and get an interstitial to the chrome://connection-help site. Bug: 811382 Change-Id: Ic53d81a902fd8f59894f935a691b90c6eec98c11 Reviewed-on: https://chromium-review.googlesource.com/854793 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537119} [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/browser/about_flags.cc [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/browser/flag_descriptions.h [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/browser/ui/webui/about_ui.cc [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/browser/ui/webui/webui_browsertest.cc [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/common/chrome_features.cc [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/common/chrome_features.h [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/common/webui_url_constants.cc [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/chrome/common/webui_url_constants.h [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/components/resources/security_interstitials_resources.grdp [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/components/security_interstitials_strings.grdp [modify] https://crrev.com/766fbc88bed0c117536f00aab036aef7851a3c03/tools/metrics/histograms/enums.xml
,
Feb 16 2018
,
Mar 20 2018
Images of UI after suggested changes.
,
Mar 20 2018
@Max, could you check these screenshots of the implementation. I'm wondering if the SHOW LESS button should actually be positioned underneath the expanded block of text. I know this is the position for the details button on other interstitials, but it looks little odd here. I guess normally in this expand collapse type of component we would use the header or some form of up / down chevron to indicate there is extra content.
,
Mar 20 2018
I'm going to go ahead and re-open this bug while we use it to discuss the UI.
,
Mar 21 2018
Thanks both! Generally this LGTM. Edward's proposal to move the SHOW LESS buttons below the expanded blocks sounds good to me.
,
Mar 21 2018
Thanks for reviewing this. Here's a screenshot of the new format with the button below the text.
,
Mar 21 2018
Thanks! LGTM.
,
Mar 21 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by est...@chromium.org
, Feb 13 2018Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows