The new iOS app should support migrating PINs stored in the old app.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b89470b0854ac1b2c745c42a30948094093409f1 commit b89470b0854ac1b2c745c42a30948094093409f1 Author: Yuwei Huang <yuweih@chromium.org> Date: Sat Feb 17 00:14:46 2018 [CRD iOS] Rewriting the Keychain Wrapper The old keychain wrapper doesn't handle multiple keychain entries and can't deal with the new keychain schema. This CL implements a new keychain wrapper for committing (Key, Account, Security Value) entry and doing (Key, Account)->Security Value lookup. BUG= 811380 Change-Id: Id2ea073fb5b171fa105a7379a29f7884a0a2f57d Reviewed-on: https://chromium-review.googlesource.com/917523 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#537473} [modify] https://crrev.com/b89470b0854ac1b2c745c42a30948094093409f1/remoting/BUILD.gn [modify] https://crrev.com/b89470b0854ac1b2c745c42a30948094093409f1/remoting/ios/BUILD.gn [modify] https://crrev.com/b89470b0854ac1b2c745c42a30948094093409f1/remoting/ios/persistence/BUILD.gn [add] https://crrev.com/b89470b0854ac1b2c745c42a30948094093409f1/remoting/ios/persistence/keychain.cc [add] https://crrev.com/b89470b0854ac1b2c745c42a30948094093409f1/remoting/ios/persistence/keychain.h [add] https://crrev.com/b89470b0854ac1b2c745c42a30948094093409f1/remoting/ios/persistence/remoting_keychain.cc [add] https://crrev.com/b89470b0854ac1b2c745c42a30948094093409f1/remoting/ios/persistence/remoting_keychain.h [add] https://crrev.com/b89470b0854ac1b2c745c42a30948094093409f1/remoting/ios/persistence/remoting_keychain_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15b7efb900d75f7316c6e713e80f87b9904791b1 commit 15b7efb900d75f7316c6e713e80f87b9904791b1 Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Feb 22 00:23:52 2018 [CRD iOS] Using the new keychain * Delete the old keychain wrapper. * Make RemotingOAuthAuthentication use the new keychain. * Implement HostPairingInfo that stores host pairings to the new keychain. BUG= 811380 Change-Id: I172f0893a1784bd1d12f256e2b8d921e37988a99 Reviewed-on: https://chromium-review.googlesource.com/924694 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#538272} [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/BUILD.gn [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/facade/remoting_oauth_authentication.h [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/facade/remoting_oauth_authentication.mm [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/facade/remoting_service.mm [delete] https://crrev.com/d0b0f452ee949a2a374a3686610d5c522e77ef44/remoting/ios/keychain_wrapper.h [delete] https://crrev.com/d0b0f452ee949a2a374a3686610d5c522e77ef44/remoting/ios/keychain_wrapper.mm [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/BUILD.gn [add] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/host_pairing_info.cc [add] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/host_pairing_info.h [add] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/host_pairing_info_unittest.cc [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/keychain.h [add] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/mock_keychain.cc [add] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/mock_keychain.h [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/remoting_keychain.cc [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/remoting_keychain.h [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/persistence/remoting_keychain_unittest.mm [modify] https://crrev.com/15b7efb900d75f7316c6e713e80f87b9904791b1/remoting/ios/session/remoting_client.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/558edcc7c448bbd3fccb201520588e5906f521d7 commit 558edcc7c448bbd3fccb201520588e5906f521d7 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Feb 26 21:41:29 2018 [CRD iOS] Adding a FakeKeychain for storing data in memory This CL adds a FakeKeychain implementation that stores data in memory. This makes it easier for testing keychain logic without mocking keychain API calls. Bug: 811380 Change-Id: I2958c8e65eaeee61477498bb6d54ad90609ad20c Reviewed-on: https://chromium-review.googlesource.com/931994 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#539272} [modify] https://crrev.com/558edcc7c448bbd3fccb201520588e5906f521d7/remoting/ios/persistence/BUILD.gn [add] https://crrev.com/558edcc7c448bbd3fccb201520588e5906f521d7/remoting/ios/persistence/fake_keychain.cc [add] https://crrev.com/558edcc7c448bbd3fccb201520588e5906f521d7/remoting/ios/persistence/fake_keychain.h
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/7ebb149b313c5d185bd5a73d631dac9631af886c commit 7ebb149b313c5d185bd5a73d631dac9631af886c Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Feb 28 04:04:30 2018
Verifed Fixed in 67.3396.22
Comment 1 Deleted