New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811376 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

UKMTestCase.testSecondaryPassphrase hangs on iPad iOS 11

Project Member Reported by baxley@chromium.org, Feb 12 2018

Issue description

This test reliably hangs/fails when run on iOS 11.2 iPad. It passes on iOS 10 iPad and iOS 11 iPhone X.


This is likely due to an EarlGrey typing bug on iPads. (crbug.com/793306)

I'm didn't verify that is the problem, so I haven't marked it as blocking.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20099d21bcfc0705d24ece7fc8f93388dfc520d8

commit 20099d21bcfc0705d24ece7fc8f93388dfc520d8
Author: Mike Baxley <baxley@chromium.org>
Date: Mon Feb 12 21:57:45 2018

Disable testSecondaryPassphrase on iOS 11 iPad.

This test is failing, likely due to an EarlGrey typing bug.

TBR=olivierrobin

Bug:  811376 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I314b31ca409ae997dcbf46aa3ed4809bbf02bf31
Reviewed-on: https://chromium-review.googlesource.com/914470
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536204}
[modify] https://crrev.com/20099d21bcfc0705d24ece7fc8f93388dfc520d8/ios/chrome/browser/metrics/ukm_egtest.mm

Cc: mahmadi@chromium.org
Owner: holte@chromium.org
Assigning to holte@ the author of the test.
Could using grey_replaceText instead of grey_typeText solve this? I remember the latter tends to be buggy, but not the former.

Comment 4 by baxley@chromium.org, Feb 13 2018

Yes, grey_replaceText is a way to get around it. It is less flaky and faster. The only time it shouldn't be used is if we care that typing is actually performed.

Comment 5 by holte@chromium.org, Feb 20 2018

Components: Internals>Metrics>UKM
@holte can you ptal as this disable reduces test coverage?
Cc: linds...@chromium.org
Labels: Hotlist-DisableReview

Comment 9 by holte@chromium.org, Mar 15 2018

I tried using replaceText instead here:
https://chromium-review.googlesource.com/c/chromium/src/+/944901

It seems like it is causing it to fail to fill in the passphrase field, but I haven't had the chance to look into detail at the failure yet.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48e09655c45b14de5e203b8440eee1f7ba1e0fd2

commit 48e09655c45b14de5e203b8440eee1f7ba1e0fd2
Author: Steven Holte <holte@chromium.org>
Date: Fri Mar 23 18:47:39 2018

Avoid SecondaryPassphrase test hang using replaceText

Bug:  811376 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1a745dbb16e9aa9791671afc90ff67106848c4d8
Reviewed-on: https://chromium-review.googlesource.com/944901
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545535}
[modify] https://crrev.com/48e09655c45b14de5e203b8440eee1f7ba1e0fd2/ios/chrome/browser/metrics/ukm_egtest.mm

Comment 11 by holte@chromium.org, Mar 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment