Say whether the connection triggered by pressing on the host item or user clicking reconnect, and whether the authentication is pinful or pinless.
Connection type is now being reported after CL 939102
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a25e14c79475dfd5b3dc70ef541526f268fbef16 commit a25e14c79475dfd5b3dc70ef541526f268fbef16 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Mar 28 21:04:50 2018 [CRD Mobile] Refactor authentication methods This CL refactors the way we do PIN authentication and third party authentication: * Make ChromotingSession::Core create the ClientAuthConfig and forward authentication calls to the Delegate on UI thread. * Pass the authentication callbacks to the Delegate and instead of providing separate HandleOn...Fetch methods. * Merge the JniPairingSecretFetcher into JniClient since it's now only used on the UI thread. * Clear pairing info on iOS if the authenticator falls back to PIN authentication. The end goal is to allow tracking authentication method (e.g. PIN, pairing, or third-party) for telemetry and feedback. Change-Id: I19a3404597163f35fb79536b77f44f9f3fb49673 Bug: 811375 Reviewed-on: https://chromium-review.googlesource.com/978455 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#546596} [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/client/chromoting_session.cc [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/client/chromoting_session.h [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/client/jni/BUILD.gn [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/client/jni/jni_client.cc [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/client/jni/jni_client.h [delete] https://crrev.com/6274288edd439112c0c7b66ac346ecad51f1f7ce/remoting/client/jni/jni_pairing_secret_fetcher.cc [delete] https://crrev.com/6274288edd439112c0c7b66ac346ecad51f1f7ce/remoting/client/jni/jni_pairing_secret_fetcher.h [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/ios/session/remoting_client.h [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/ios/session/remoting_client.mm [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/ios/session/remoting_client_session_delegate.h [modify] https://crrev.com/a25e14c79475dfd5b3dc70ef541526f268fbef16/remoting/ios/session/remoting_client_session_delegate.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc3753eef9818caa07b6d65bf361fc5227ccadab commit dc3753eef9818caa07b6d65bf361fc5227ccadab Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Mar 28 23:47:58 2018 [CRD Mobile] Tracking authentication method for telemetry and feedback This CL tracks the current auth method for telemetry and feedback. This can help us analyze auth method-specific issues and understand how many users are using pairing or third party auth. Change-Id: Ib1a528bab9af22f4c97cc2fc0cf01306c08d18ac Bug: 811375 Reviewed-on: https://chromium-review.googlesource.com/981183 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#546661} [modify] https://crrev.com/dc3753eef9818caa07b6d65bf361fc5227ccadab/remoting/base/chromoting_event.cc [modify] https://crrev.com/dc3753eef9818caa07b6d65bf361fc5227ccadab/remoting/base/chromoting_event.h [modify] https://crrev.com/dc3753eef9818caa07b6d65bf361fc5227ccadab/remoting/base/telemetry_log_writer.cc [modify] https://crrev.com/dc3753eef9818caa07b6d65bf361fc5227ccadab/remoting/client/chromoting_session.cc [modify] https://crrev.com/dc3753eef9818caa07b6d65bf361fc5227ccadab/remoting/client/client_telemetry_logger.cc [modify] https://crrev.com/dc3753eef9818caa07b6d65bf361fc5227ccadab/remoting/client/client_telemetry_logger.h [modify] https://crrev.com/dc3753eef9818caa07b6d65bf361fc5227ccadab/remoting/client/feedback_data.cc
Comment 1 by yuweih@chromium.org
, Mar 5 2018