New issue
Advanced search Search tips

Issue 811336 link

Starred by 1 user
Status: Duplicate
Merged: issue 811334
Owner:
yhirano@chromium.org
Closed: May 2018
Cc:
yhirano@chromium.org
sullivan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.6%-87.3% regression in loading.desktop at 535191:535336

Project Member Reported by sullivan@chromium.org, Feb 12 2018 
Could be related to  bug 811334 .
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 12 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=811336

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1174d5ad5150d0f4abda2c4e277c60d5a7805db78360badf53ad018c76422819


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-pro
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
win-high-dpi
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 12 2018

Cc: jwd@chromium.org yhirano@chromium.org
Owner: yhirano@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11c582cd840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by yhirano@chromium.org, Feb 13 2018

Cc: -jwd@chromium.org
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Feb 13 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/15fe883d840000

Comment 7 by yhirano@chromium.org, Feb 13 2018 

sullivan@, I have a question; Currently 98 test cases are listed in https://chromeperf.appspot.com/group_report?bug_id=811336. I picked one and tried bisect (#5) but it couldn't reproduce a difference. What should I do? Should I run 98 bisect jobs and exclude non-reproducing ones?
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Feb 13 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1680168d840000

ResourceLoadScheduler: Count the number of throttlable requests by yhirano@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/915882/4

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 21 by sullivan@chromium.org, Feb 13 2018 

I think the bisect in #9 was a re-run? There was a bug with them yesterday where rerunning caused it just to pinpoint the last CL in the range. So let's ignore that one.

This bug is all loading metrics for Windows in the same revision range, except for 2 on linux which I split into  bug 811841 , and one on Mac, which I split into  bug 811844 .

I bisected the top 10 largest regressions, will see how they come back.
Project Member

Comment 22 by 42576172...@developer.gserviceaccount.com, Feb 13 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/16be3b6d840000
Project Member

Comment 23 by 42576172...@developer.gserviceaccount.com, Feb 13 2018

Cc: jwd@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14c9b65d840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 24 by 42576172...@developer.gserviceaccount.com, Feb 13 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1297943d840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 25 by 42576172...@developer.gserviceaccount.com, Feb 13 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16cd16cd840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 26 by 42576172...@developer.gserviceaccount.com, Feb 13 2018

Cc: yzshen@chromium.org w...@chromium.org vakh@chromium.org jam@chromium.org scottmg@chromium.org
Owner: w...@chromium.org
📍 Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/11b0e035840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Introduce feature flag S13nSafeBrowsingCheckByURLLoaderThrottle. by yzshen@chromium.org
https://chromium.googlesource.com/chromium/src/+/cb3011f67a9594f61c853fd25e7d9a34d286d21b

Filter FieldTrialListTest.TestCopyFieldTrialStateToFlags under Fuchsia. by wez@chromium.org
https://chromium.googlesource.com/chromium/src/+/c887cf2a868e141eb77fc687bcf07ec9f0b8f7eb

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 27 by w...@chromium.org, Feb 13 2018

Owner: yzshen@chromium.org
My CL was a test-only filter file, specific to Fuchsia.

Reassigning to yzshen@, since it seems yhirano@ has already take a look, in case the *LoaderThrottle CL is the issue.
Project Member

Comment 28 by 42576172...@developer.gserviceaccount.com, Feb 14 2018

Owner: yhirano@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/10310d6d840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 33 by 42576172...@developer.gserviceaccount.com, Feb 14 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11f34fed840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 34 by 42576172...@developer.gserviceaccount.com, Feb 14 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16b9303d840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 35 by 42576172...@developer.gserviceaccount.com, Feb 14 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/13fe883d840000
Project Member

Comment 36 by 42576172...@developer.gserviceaccount.com, Feb 14 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14cb6dcd840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 37 by 42576172...@developer.gserviceaccount.com, Feb 14 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14c5295d840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 38 by 42576172...@developer.gserviceaccount.com, Feb 14 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/148d165d840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 39 by 42576172...@developer.gserviceaccount.com, Feb 14 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14ec593d840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 40 by 42576172...@developer.gserviceaccount.com, Feb 14 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14b0f1fd840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 41 by 42576172...@developer.gserviceaccount.com, Feb 15 2018

Cc: evem@chromium.org dcheng@chromium.org
Owner: evem@chromium.org
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/148edaed840000

Update RendererSideResourceScheduler testing config (Enabled_2_1024) by yhirano@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f25bbc692f06964b5e10c7312f9f81377cdea32

Conditionally enable UpdateBrowserControlsState for by evem@chromium.org
https://chromium.googlesource.com/chromium/src/+/7d1ede9740f44a77f5da73dc9c0f7de96b2e8925

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 42 by yhirano@chromium.org, Feb 15 2018

Owner: yhirano@chromium.org

Comment 43 by yhirano@chromium.org, Feb 15 2018

Cc: -yhirano@chromium.org -jam@chromium.org -evem@chromium.org -w...@chromium.org -vakh@chromium.org -yzshen@chromium.org -jwd@chromium.org -dcheng@chromium.org -scottmg@chromium.org
Project Member

Comment 46 by 42576172...@developer.gserviceaccount.com, Feb 15 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12b16a7d840000
Project Member

Comment 47 by 42576172...@developer.gserviceaccount.com, Feb 15 2018

Cc: yhirano@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12d3f97d840000

[DO NOT COMMIT] 2_1024 => 1_1024 by yhirano@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/920573/1

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 49 by tyoshino@chromium.org, Feb 15 2018 

#48 is for my patch.
Project Member

Comment 50 by 42576172...@developer.gserviceaccount.com, Feb 15 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1486b4b3840000
Project Member

Comment 54 by 42576172...@developer.gserviceaccount.com, Feb 16 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/168945b3840000
Project Member

Comment 55 by 42576172...@developer.gserviceaccount.com, Feb 16 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12b34f7d840000

[DO NOT COMMIT] 2_1024 => disabled by yhirano@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/920963/1

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 56 by 42576172...@developer.gserviceaccount.com, Feb 16 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/14fd654b840000

Comment 57 by yhirano@chromium.org, May 14 2018

Mergedinto: 81334
Status: Duplicate (was: Assigned)

Comment 58 by yhirano@chromium.org, May 14 2018

Mergedinto: -81334 811334

Comment 59 by yhirano@chromium.org, May 14 2018 

 Issue 811420  has been merged into this issue.
►

Sign in to add a comment