New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811333 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chromium try flakes app hits chrome-build-extract for LUCI builds

Project Member Reported by iannucci@chromium.org, Feb 12 2018

Issue description

Components: -Infra>Client>Chrome Infra
Owner: iannucci@chromium.org
Status: Assigned (was: Untriaged)
I'm not sure who owns chromium-try-flakes, but it's not I>C>C. Back to you for retriage.

Comment 2 by estaab@chromium.org, Feb 12 2018

Cc: st...@chromium.org
Components: -Infra Infra>Flakiness>Pipeline
+stgao since his team owns CTF
Cc: iannucci@chromium.org
Owner: st...@chromium.org
stgao@ any idea how to triage this?
Cc: st...@chromium.org
Components: -Infra Infra>Flakiness>Pipeline
Owner: ----
Status: Available (was: Assigned)
ah oops, pressed send too soon

Comment 5 by st...@chromium.org, Feb 12 2018

Cc: wylieb@chromium.org
Owner: st...@chromium.org
Status: Assigned (was: Available)
(Many thanks for the report!)

hm, it seems that we should switch CTF to Milo APIs instead.
If not too urgent, I will fix it this afternoon.
sounds great :) I don't think it's too urgent, but we saw it for chromium_presubmit (which has been switched to LUCI). I expect that as more things switch this will become more important.

Comment 7 by st...@chromium.org, Feb 12 2018

OK. Will try to get to it this afternoon or tomorrow.

Comment 10 by no...@chromium.org, Feb 20 2018

Issue 813861 has been merged into this issue.
This bug not being fixed is actively paging me, unfortunately. Issue 813861 is the bug I filed when I got paged this morning.

Comment 12 by st...@chromium.org, Feb 20 2018

Sorry about this! I need one more review for the fixing CL above.
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2

commit 8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2
Author: Shuotao Gao <stgao@chromium.org>
Date: Tue Feb 20 22:57:51 2018

[chromium-try-flakes] Support Luci builds.

Two changes:
1. Read the master name from the build properties instead of cq job.
2. Use Milo instead of chrome-build-extract.

Bug:  811333 
Change-Id: I72bf21fc3a26c96b7407571d4d73bcfc16f14257
Reviewed-on: https://chromium-review.googlesource.com/920768
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py
[modify] https://crrev.com/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2/appengine/chromium_try_flakes/status/cq_status.py
[modify] https://crrev.com/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2/appengine/chromium_try_flakes/handlers/flake_issues.py
[modify] https://crrev.com/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2/appengine/chromium_try_flakes/status/test/cq_status_test.py

Comment 14 by st...@chromium.org, Feb 21 2018

Status: Fixed (was: Assigned)
Fix was deployed. If there are further issue, please file a new bug.
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/de2065a11a3dcc682498e0ea0d86f049ed616780

commit de2065a11a3dcc682498e0ea0d86f049ed616780
Author: Shuotao Gao <stgao@chromium.org>
Date: Wed Feb 21 06:33:53 2018

[chromium-try-flakes] Remove prefix ')]}\'\n' from Milo response.

TBR=nodir@chromium.org
Bug:  811333 
Change-Id: I15515ec0d1e14602e1f23815c8e4a53f23be19e4
Reviewed-on: https://chromium-review.googlesource.com/927929
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/de2065a11a3dcc682498e0ea0d86f049ed616780/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py
[modify] https://crrev.com/de2065a11a3dcc682498e0ea0d86f049ed616780/appengine/chromium_try_flakes/handlers/flake_issues.py

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f987d9950b177a30765eafc072814ae8fe786c58

commit f987d9950b177a30765eafc072814ae8fe786c58
Author: Shuotao Gao <stgao@chromium.org>
Date: Thu Feb 22 05:49:52 2018

[chromium-try-flakes] Handle unavailable step text for Luci builds.

For Buildbot builds, steps seem to have all step text. However, for Luci builds,
some steps like "analyze" don't have step text.

Bug:  811333 
Change-Id: I8247ced6d2214381336771fa465b8526b8be4a4e
Reviewed-on: https://chromium-review.googlesource.com/930579
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/f987d9950b177a30765eafc072814ae8fe786c58/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py
[modify] https://crrev.com/f987d9950b177a30765eafc072814ae8fe786c58/appengine/chromium_try_flakes/handlers/flake_issues.py

Sign in to add a comment