Chromium try flakes app hits chrome-build-extract for LUCI builds |
||||||
Issue descriptionLog https://pantheon.corp.google.com/logs/viewer?project=chromium-try-flakes&organizationId=433637338589&minLogLevel=0&expandAll=false×tamp=2018-02-12T17%3A03%3A50.233054000Z&dateRangeStart=2018-02-12T16%3A19%3A57.454Z&dateRangeEnd=2018-02-12T17%3A19%3A57.454Z&interval=PT1H&resource=gae_app&logName=projects%2Fchromium-try-flakes%2Flogs%2Fappengine.googleapis.com%252Frequest_log&advancedFilter=resource.type%3D%22gae_app%22%0Aresource.labels.module_id%3D%22default%22%0Aresource.labels.zone%3D%22us9%22%0Aresource.labels.project_id%3D%22chromium-try-flakes%22%0Aresource.labels.version_id%3D%2213717-cc3ed04%22%0Atimestamp%3D%222018-02-12T17%3A03%3A50.233054000Z%22%0AinsertId%3D%225a81c8f60005c57d2281996d%22 Outage https://o.corp.google.com/#Escalator:m25c53ca598000049 I don't think c-b-e will ever work for LUCI builds. Milo provides all the canonical APIs for builds at this point in time.
,
Feb 12 2018
+stgao since his team owns CTF
,
Feb 12 2018
stgao@ any idea how to triage this?
,
Feb 12 2018
ah oops, pressed send too soon
,
Feb 12 2018
(Many thanks for the report!) hm, it seems that we should switch CTF to Milo APIs instead. If not too urgent, I will fix it this afternoon.
,
Feb 12 2018
sounds great :) I don't think it's too urgent, but we saw it for chromium_presubmit (which has been switched to LUCI). I expect that as more things switch this will become more important.
,
Feb 12 2018
OK. Will try to get to it this afternoon or tomorrow.
,
Feb 13 2018
,
Feb 15 2018
Fixing CL ready for review: https://chromium-review.googlesource.com/c/infra/infra/+/920768
,
Feb 20 2018
Issue 813861 has been merged into this issue.
,
Feb 20 2018
This bug not being fixed is actively paging me, unfortunately. Issue 813861 is the bug I filed when I got paged this morning.
,
Feb 20 2018
Sorry about this! I need one more review for the fixing CL above.
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2 commit 8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2 Author: Shuotao Gao <stgao@chromium.org> Date: Tue Feb 20 22:57:51 2018 [chromium-try-flakes] Support Luci builds. Two changes: 1. Read the master name from the build properties instead of cq job. 2. Use Milo instead of chrome-build-extract. Bug: 811333 Change-Id: I72bf21fc3a26c96b7407571d4d73bcfc16f14257 Reviewed-on: https://chromium-review.googlesource.com/920768 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py [modify] https://crrev.com/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2/appengine/chromium_try_flakes/status/cq_status.py [modify] https://crrev.com/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2/appengine/chromium_try_flakes/handlers/flake_issues.py [modify] https://crrev.com/8a73f7af4d51782a0c58d395e9b1a68fd8a6ccc2/appengine/chromium_try_flakes/status/test/cq_status_test.py
,
Feb 21 2018
Fix was deployed. If there are further issue, please file a new bug.
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/de2065a11a3dcc682498e0ea0d86f049ed616780 commit de2065a11a3dcc682498e0ea0d86f049ed616780 Author: Shuotao Gao <stgao@chromium.org> Date: Wed Feb 21 06:33:53 2018 [chromium-try-flakes] Remove prefix ')]}\'\n' from Milo response. TBR=nodir@chromium.org Bug: 811333 Change-Id: I15515ec0d1e14602e1f23815c8e4a53f23be19e4 Reviewed-on: https://chromium-review.googlesource.com/927929 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/de2065a11a3dcc682498e0ea0d86f049ed616780/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py [modify] https://crrev.com/de2065a11a3dcc682498e0ea0d86f049ed616780/appengine/chromium_try_flakes/handlers/flake_issues.py
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f987d9950b177a30765eafc072814ae8fe786c58 commit f987d9950b177a30765eafc072814ae8fe786c58 Author: Shuotao Gao <stgao@chromium.org> Date: Thu Feb 22 05:49:52 2018 [chromium-try-flakes] Handle unavailable step text for Luci builds. For Buildbot builds, steps seem to have all step text. However, for Luci builds, some steps like "analyze" don't have step text. Bug: 811333 Change-Id: I8247ced6d2214381336771fa465b8526b8be4a4e Reviewed-on: https://chromium-review.googlesource.com/930579 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/f987d9950b177a30765eafc072814ae8fe786c58/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py [modify] https://crrev.com/f987d9950b177a30765eafc072814ae8fe786c58/appengine/chromium_try_flakes/handlers/flake_issues.py |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jbudorick@chromium.org
, Feb 12 2018Owner: iannucci@chromium.org
Status: Assigned (was: Untriaged)