New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811332 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 811322
issue 811325
issue 811326



Sign in to add a comment

Pinpoint jobs failing with 'DiagnosticRef' object is not iterable error

Project Member Reported by sullivan@chromium.org, Feb 12 2018

Issue description

Blocking: 811325
Blocking: 811322
Blocking: 811326

Comment 4 by dtu@chromium.org, Feb 12 2018

Cc: eakuefner@chromium.org dtu@chromium.org nednguyen@chromium.org simonhatch@chromium.org
Owner: ----
As far as I can tell, the trace links are now missing from the histogram output, when they were there before.

Old histogram json, that has the trace links we expect.
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=021042ab2fcd03c9a9b3d5abcdf9946686471561&as=chartjson-output.json

New histogram json, that has "traceUrls" diagnostics, but they don't reference anything in the histogram set.
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=062f01903d4afd439769b9a5b080839d68f9b2ac&as=chartjson-output.json

Comment 5 by dtu@chromium.org, Feb 12 2018

Cc: chiniforooshan@chromium.org
BTW this is also tracked in Catapult at https://github.com/catapult-project/catapult/issues/4243

Comment 6 by dtu@chromium.org, Feb 13 2018

Cc: benjhayden@chromium.org
I briefly broke this last week, see https://github.com/catapult-project/catapult/issues/4232. However, it should be fixed at head.
Owner: simonhatch@chromium.org
Status: WontFix (was: Untriaged)
Closing this out since there isn't much we can do here. Data isn't there in the broken range, so we can't recover in Pinpoint.
Can't we just bail out early if the trace links aren't present? That way we could finish the bisects, and they just wouldn't have trace links, right?
That's what I tried out originally, and then we ran into the same issue missing story tags diagnostics. Missing urls is totally fine, that just won't show up in the UI. Missing diagnostics like story tags isn't since we can't find the histogram at that point.

Comment 12 by dtu@chromium.org, Feb 20 2018

Yes, Simon's fix for ignoring DiagnosticRef will work for functional bisects, but if the story tags are missing, we can't find the metric, so we're hosed for perf bisects.

Sign in to add a comment