New issue
Advanced search Search tips

Issue 811315 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use child text content when checking for no-op scripts

Project Member Reported by domenic@chromium.org, Feb 12 2018

Issue description

Chrome Version: Version 66.0.3345.0 (Official Build) canary (64-bit)

Test: http://w3c-test.org/html/semantics/scripting-1/the-script-element/emptyish-script-elements.html

Spec: https://html.spec.whatwg.org/#prepare-a-script step 5

Recent spec change: https://github.com/whatwg/html/pull/3451 (to match Firefox and Edge and be simpler)

The observable difference here is due to whether or not you mark the script as "already-started", preventing future executions when its child text content changes.
 
Description: Show this description

Comment 2 by tkent@chromium.org, Feb 13 2018

Status: Available (was: Untriaged)
Owner: hirosh...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb5461b97a8994108f309336972b174e847d939c

commit bb5461b97a8994108f309336972b174e847d939c
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Mon Jun 11 07:30:59 2018

Spec-followup: Use child text content for no-op scripts

Bug:  811315 
Change-Id: Id6b17e608e493d4ae1d5353cbb79e95de170751d
Reviewed-on: https://chromium-review.googlesource.com/1091697
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565940}
[delete] https://crrev.com/7011ba84567e43b782131a3dc747dba0caa37adc/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/emptyish-script-elements-expected.txt
[modify] https://crrev.com/bb5461b97a8994108f309336972b174e847d939c/third_party/blink/renderer/core/script/script_loader.cc

Status: Fixed (was: Started)

Sign in to add a comment