Password Export: menu item disabled after canceling export |
|||
Issue descriptionChrome Version: 66.0.3344.0 OS: Android What steps will reproduce the problem? (1) Tap menu, tap "Export passwords...", authenticate (2) Tap "Cancel" in the confirmation dialog (4) Tap menu again What is the expected result? It should be possible to tap the "Export passwords..." item in the menu. What happens instead? The item is disabled. Could you take a look? Thanks!
,
Feb 13 2018
CL in review at https://crrev.com/c/914883
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/212d3064f916278e6d5245efdab3a92b62a9b8b5 commit 212d3064f916278e6d5245efdab3a92b62a9b8b5 Author: Vaclav Brozek <vabr@chromium.org> Date: Tue Feb 13 11:57:10 2018 [Android password settings] Fix export cancellation Chrome displays a warning dialog if the user requests exporting their passwords. The dialog allows the user to cancel the export. This CL ensures that the cancellation does properly update the inner state so that the export menu item gets re-enabled. The CL also refactors the test a little: a block of code was used repeatedly for checking the state of the export menu item, now it is a helper method. Bug: 811307 Change-Id: I32112f056f84f410b0b862b9530a3fe756983512 Reviewed-on: https://chromium-review.googlesource.com/914883 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#536338} [modify] https://crrev.com/212d3064f916278e6d5245efdab3a92b62a9b8b5/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java [modify] https://crrev.com/212d3064f916278e6d5245efdab3a92b62a9b8b5/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java
,
Feb 13 2018
,
Feb 15 2018
Verified fix in 66.0.3348.0. 'Export password' option is not disabled on canceling the export. |
|||
►
Sign in to add a comment |
|||
Comment 1 by vabr@chromium.org
, Feb 13 2018Status: Started (was: Assigned)