New issue
Advanced search Search tips

Issue 811306 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Building Monochrome for mipsel fails

Reported by gordana....@mips.com, Feb 12 2018

Issue description

Steps to reproduce the problem:
1. gn gen out-gn/mipsel-android --args="target_os=\"android\" is_debug=false target_cpu=\"mipsel\""
2. ninja -C out-gn/mipsel-android monochrome
3. 

What is the expected behavior?
Build to succeed.

What went wrong?
Linking failed with error:

[71791/74560] SOLINK ./libmonochrome.so
FAILED: libmonochrome.so libmonochrome.so.TOC lib.unstripped/libmonochrome.so 
python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="../../third_party/android_ndk/toolchains/mipsel-linux-android-4.9/prebuilt/linux-x86_64/bin/mipsel-linux-android-readelf" --nm="../../third_party/android_ndk/toolchains/mipsel-linux-android-4.9/prebuilt/linux-x86_64/bin/mipsel-linux-android-nm" --strip=../../third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libmonochrome.so" --tocfile="./libmonochrome.so.TOC" --output="./libmonochrome.so"  -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--hash-style=gnu -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed --gcc-toolchain=../../third_party/android_ndk/toolchains/mipsel-linux-android-4.9/prebuilt/linux-x86_64 -Wl,--no-undefined -Wl,--exclude-libs=libgcc.a -Wl,--exclude-libs=libc++_static.a -Wl,--exclude-libs=libvpx_assembly_arm.a --target=mipsel-linux-android --target=mipsel-linux-android -mips32 -Werror -Wl,-O2 -Wl,--gc-sections -Wl,--fatal-warnings -nostdlib --sysroot=../../third_party/android_ndk/platforms/android-16/arch-mips -Wl,--version-script=/home/v8mips/Buildbot/Setup/Slave-CHROMIUM-android3/Release_build/build/src/build/android/android_only_jni_exports.lst -Wl,-wrap,calloc -Wl,-wrap,free -Wl,-wrap,malloc -Wl,-wrap,memalign -Wl,-wrap,posix_memalign -Wl,-wrap,pvalloc -Wl,-wrap,realloc -Wl,-wrap,valloc -Wl,--dynamic-linker,/system/bin/linker -L../../third_party/android_ndk/sources/cxx-stl/llvm-libc++/libs/mips -o "./lib.unstripped/libmonochrome.so" -Wl,-soname="libmonochrome.so" @"./libmonochrome.so.rsp"
../../third_party/android_ndk/toolchains/mipsel-linux-android-4.9/prebuilt/linux-x86_64/lib/gcc/mipsel-linux-android/4.9.x/../../../../mipsel-linux-android/bin/ld: .gnu.hash is incompatible with the MIPS ABI
clang: error: linker command failed with exit code 1 (use -v to see invocation)

as per [1].

[1] http://www.rt-rk.com/mips-buildbot/builders/Release_build/builds/2539/steps/Build/logs/stdio

Did this work before? Yes r535647

Chrome version: master  Channel: dev
OS Version: 
Flash Version: 

The issue is introduced with:
https://chromium-review.googlesource.com/c/chromium/src/+/909711

where hashstyle gnu is forced for monochrome target.

MIPS architecture does not support hashstyle gnu.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1235ace2707eccd944989d8a234ed7c37d51b45f

commit 1235ace2707eccd944989d8a234ed7c37d51b45f
Author: Gordana Cmiljanovic <gordana.cmiljanovic@mips.com>
Date: Mon Feb 12 17:28:02 2018

[MIPS] Do not use hash-style gnu for MIPS architecture

Hashstyle gnu has been forced for monochrome here:
https://chromium-review.googlesource.com/c/chromium/src/+/909711
but that cannot be used for MIPS since it is not supported.

Bug:  811306 
Change-Id: I241623d5f9013902b0afd0cd1d468da01eba5d1d
Reviewed-on: https://chromium-review.googlesource.com/913949
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536119}
[modify] https://crrev.com/1235ace2707eccd944989d8a234ed7c37d51b45f/chrome/android/BUILD.gn

Status: Fixed (was: Unconfirmed)

Sign in to add a comment