New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811288 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

CompositorControllerSurfaceSyncBrowserTests/.../0 in headless_browsertests flakily failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Feb 12 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of jbroman@chromium.org

CompositorControllerSurfaceSyncBrowserTests/.../0 in headless_browsertests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29


 
Cc: eseckler@chromium.org
Components: Internals>Headless
Owner: fsam...@chromium.org
Status: Assigned (was: Available)
Summary: CompositorControllerSurfaceSyncBrowserTests/.../0 in headless_browsertests flakily failing on chromium.win/Win7 Tests (dbg)(1) (was: CompositorControllerSurfaceSyncBrowserTests/.../0 in headless_browsertests failing on chromium.win/Win7 Tests (dbg)(1))
../../headless/public/util/compositor_controller_browsertest.cc(282): error: Expected equality of these values:
  1
  begin_frame_counter_->begin_frame_count()
    Which is: 2

Two failures:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F66295%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests%2F0%2Flogs%2FCompositorControllerSurfaceSyncBrowserTests__x2f_CompositorControllerSurfaceSyncBrowserTest.RunAsyncTest__x2f_1%2F0
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F66303%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests%2F0%2Flogs%2FCompositorControllerSurfaceSyncBrowserTests__x2f_CompositorControllerSurfaceSyncBrowserTest.RunAsyncTest__x2f_0%2F0

This recent CL seems likely to be the cause:

https://chromium.googlesource.com/chromium/src/+/6de28ba11ef3d94306472ff46525ee53e8e55adc%5E%21/#F9

But it has been in for nearly a week. It also disables a nearby and related assertion for flaking.

I'm going to disable this test for now.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb7d3484a1b299ea1c790dfafc0c7e2001ca8296

commit eb7d3484a1b299ea1c790dfafc0c7e2001ca8296
Author: Jeremy Roman <jbroman@chromium.org>
Date: Mon Feb 12 16:09:38 2018

Disable CompositorControllerSurfaceSyncBrowserTests/CompositorControllerSurfaceSyncBrowserTest.RunAsyncTest due to flakiness.

Bug:  811288 
Change-Id: I649d1765e484c7439abc78af4c2a1eff3946cd93
Tbr: fsamuel@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/913650
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536088}
[modify] https://crrev.com/eb7d3484a1b299ea1c790dfafc0c7e2001ca8296/headless/public/util/compositor_controller_browsertest.cc

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b74eba3c346a54a96781f987ae2f68254e3344f

commit 5b74eba3c346a54a96781f987ae2f68254e3344f
Author: Eric Seckler <eseckler@chromium.org>
Date: Wed Feb 21 18:41:44 2018

headless/viz: Use unlimited surface deadlines for full-pipe mode.

Also reenables previously flaky CompositorController browsertest.

Bug:  811288 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id2d8ab78e3117941c3426b3dd5628de171833bb7
Reviewed-on: https://chromium-review.googlesource.com/928706
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538161}
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/cc/base/switches.cc
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/cc/base/switches.h
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/components/viz/common/switches.cc
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/components/viz/common/switches.h
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/headless/lib/DEPS
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/headless/lib/browser/headless_devtools_manager_delegate.cc
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/headless/public/util/compositor_controller_browsertest.cc
[modify] https://crrev.com/5b74eba3c346a54a96781f987ae2f68254e3344f/ui/compositor/compositor.cc

Owner: eseckler@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment