New issue
Advanced search Search tips

Issue 811277 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
pbos@chromium.org
dfried@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 101762
issue 820351



Sign in to add a comment

Proper accessibility implementation or TreeView and TableView

Project Member Reported by aleventhal@chromium.org, Feb 12 2018 
The TreeView and TableView widgets use the text of the currently selected item for the name property, which is incorrect.

- The name property should be the text of label for the entire widget
- A selection and/or focus should be exposed and selection events should be fired when the selection changes. This will be difficult in the case when the selectable child items don't have their own View, just model data.
- In the case of TreeView, the level, posinset and setsize need to be exposed

Comment 1 by jamwalla@chromium.org, Aug 29

Blocking: 820351

Comment 2 by jamwalla@chromium.org, Aug 29

Blocking: 101762

Comment 3 by dfried@chromium.org, Sep 17

Cc: dfried@chromium.org

Comment 4 by pbos@chromium.org, Oct 11

Cc: pbos@chromium.org
Components: -Blink>Accessibility UI>Accessibility

Comment 5 by robliao@chromium.org, Oct 18

Labels: -Pri-3 PM-markchang a11y-q2-18 Pri-2
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb17833e9f4a8da43a8ca509f0a85363a387581b

commit eb17833e9f4a8da43a8ca509f0a85363a387581b
Author: Nektarios Paisios <nektar@chromium.org>
Date: Fri Oct 26 23:42:25 2018

Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants"

This is a reland of cb9c309136ca43808267b83a6c603557805af943

R=dmazzoni@chromium.org,aleventhal@chromium.org
TBR=afakhry@chromium.org,ellyjones@chromium.org,sky@chromium.org
Bug: 811277

Original change's description:
Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants

Also renamed some methods to make interface more consistent.
In preparation for more changes in AXVirtualView.

Change-Id: I815d6d941f18ef84864636bc02423af20b0bbc97
Reviewed-on: https://chromium-review.googlesource.com/c/1303093
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603255}
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/accessibility/BUILD.gn
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/BUILD.gn
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/ax_tree_source_views_unittest.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/ax_view_obj_wrapper.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/ax_virtual_view.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/ax_virtual_view.h
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/ax_virtual_view_unittest.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/view_accessibility.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/view_accessibility.h
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/view_ax_platform_node_delegate.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/view_ax_platform_node_delegate.h
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/accessibility/view_ax_platform_node_delegate_win_unittest.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/controls/tabbed_pane/tabbed_pane.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/eb17833e9f4a8da43a8ca509f0a85363a387581b/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41463733b6ebbdee9549063eb9d9e23278ff7c1b

commit 41463733b6ebbdee9549063eb9d9e23278ff7c1b
Author: Nektarios Paisios <nektar@chromium.org>
Date: Sat Oct 27 00:20:16 2018

Revert "Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants""

This reverts commit eb17833e9f4a8da43a8ca509f0a85363a387581b.

Reason for revert:
Broke linux-chromeos-dbg again.
AXPlatformNodeDelegateBase::Create and GetData are not defined.



Original change's description:
> Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants"
> 
> This is a reland of cb9c309136ca43808267b83a6c603557805af943
> 
> R=​dmazzoni@chromium.org,aleventhal@chromium.org
> TBR=afakhry@chromium.org,ellyjones@chromium.org,sky@chromium.org
> Bug: 811277
> 
> Original change's description:
> Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants
> 
> Also renamed some methods to make interface more consistent.
> In preparation for more changes in AXVirtualView.
> 
> Change-Id: I815d6d941f18ef84864636bc02423af20b0bbc97
> Reviewed-on: https://chromium-review.googlesource.com/c/1303093
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603255}

TBR=ellyjones@chromium.org,dmazzoni@chromium.org,sky@chromium.org,afakhry@chromium.org,nektar@chromium.org,aleventhal@chromium.org

Change-Id: I954e26880106e51fe78daa79717300f5ab833341
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 811277
Reviewed-on: https://chromium-review.googlesource.com/c/1303556
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603268}
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/accessibility/BUILD.gn
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/BUILD.gn
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/ax_tree_source_views_unittest.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/ax_view_obj_wrapper.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/ax_virtual_view.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/ax_virtual_view.h
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/ax_virtual_view_unittest.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/view_accessibility.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/view_accessibility.h
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/view_ax_platform_node_delegate.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/view_ax_platform_node_delegate.h
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/accessibility/view_ax_platform_node_delegate_win_unittest.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/controls/tabbed_pane/tabbed_pane.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/41463733b6ebbdee9549063eb9d9e23278ff7c1b/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e678e606320dab796d260b926de8c96bb89633

commit e6e678e606320dab796d260b926de8c96bb89633
Author: Nektarios Paisios <nektar@chromium.org>
Date: Thu Nov 01 02:39:35 2018

Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants"

This is a reland of cb9c309136ca43808267b83a6c603557805af943

Two things needed to be changed to fix the compilation failures:
1. Add build file entries for ui/accessibility/platform/ax_platform_node_base.* and ax_-platform_node_delegate_base.* so that these files would be compiled on platforms that don't have native accessibility support, such as Chrome OS.
2. Implement all the unimplemented methods in ui/accessibility/platform/ax_platform_node_base and ax_platform_node_delegate_base.

R=dmazzoni@chromium.org,aleventhal@chromium.org
TBR=afakhry@chromium.org,ellyjones@chromium.org,sky@chromium.org
Bug: 811277

Original change's description:
Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants

Also renamed some methods to make interface more consistent.
In preparation for more changes in AXVirtualView.

Change-Id: Ic83e231c0fd3bdf45e68f4e6279e705ce22b2aa7
Reviewed-on: https://chromium-review.googlesource.com/c/1304815
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604493}
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/accessibility/BUILD.gn
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/accessibility/platform/ax_platform_node_delegate_base.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/accessibility/platform/ax_platform_node_delegate_base.h
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/BUILD.gn
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/ax_tree_source_views_unittest.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/ax_view_obj_wrapper.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/ax_virtual_view.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/ax_virtual_view.h
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/ax_virtual_view_unittest.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/view_accessibility.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/view_accessibility.h
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/view_ax_platform_node_delegate.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/view_ax_platform_node_delegate.h
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/accessibility/view_ax_platform_node_delegate_win_unittest.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/controls/tabbed_pane/tabbed_pane.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/e6e678e606320dab796d260b926de8c96bb89633/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bf097da730a7a9d831df48bfcefb5a5be4d31bf

commit 8bf097da730a7a9d831df48bfcefb5a5be4d31bf
Author: Nektarios Paisios <nektar@chromium.org>
Date: Thu Nov 01 22:55:24 2018

Computes several accessibility attributes for a virtual view based on its real View ancestor

Also took the opportunity to:
Add a test for managing virtual focus,
and a test for the "focusable" and "enabled" accessibility attributes
R=dmazzoni@chromium.org, ellyjones@chromium.org, aleventhal@chromium.org

Bug: 811277
Change-Id: I6061ddae14bc1fd83ab4e38222fe57d6025380e5
Reviewed-on: https://chromium-review.googlesource.com/c/1302576
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604737}
[modify] https://crrev.com/8bf097da730a7a9d831df48bfcefb5a5be4d31bf/ui/views/accessibility/ax_virtual_view.cc
[modify] https://crrev.com/8bf097da730a7a9d831df48bfcefb5a5be4d31bf/ui/views/accessibility/ax_virtual_view.h
[modify] https://crrev.com/8bf097da730a7a9d831df48bfcefb5a5be4d31bf/ui/views/accessibility/ax_virtual_view_unittest.cc
[modify] https://crrev.com/8bf097da730a7a9d831df48bfcefb5a5be4d31bf/ui/views/accessibility/view_accessibility.h
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1057be98888965457ab2d105d76a3eefba58d9c4

commit 1057be98888965457ab2d105d76a3eefba58d9c4
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Nov 02 11:38:54 2018

GetClassName is a Win32 macro, use a different name in AXVirtualView

In jumbo builds, AXVirtualView::GetClassName sometimes expanded to
AXVirtual::GetClassNameW (but not always). This caused build breakage.

Rather than carefully ensuring that ui/views/accessibility is compiled
with the same GetClassName macro every time (be it defined or
not defined), just rename it to get the build going.

If the undef method is to be used, it needs be in the header file, but
then it will also affect View::GetClassName and that is another can
of worms. It's possible GetClassName should be added to
base/win/windows_types.h which could be used everywhere, but that
is a larger fix than just getting the build working again.

TBR=nektar@chromium.org,dmazzoni@chromium.org

Bug: 811277
Change-Id: I8e5a8b71f21d57ef03a5c5e58bee84b5b99b2abd
Reviewed-on: https://chromium-review.googlesource.com/c/1314488
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#604892}
[modify] https://crrev.com/1057be98888965457ab2d105d76a3eefba58d9c4/ui/views/accessibility/ax_virtual_view.cc
[modify] https://crrev.com/1057be98888965457ab2d105d76a3eefba58d9c4/ui/views/accessibility/ax_virtual_view.h
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b471893d67391875f56db8d99c6c1849ba53bf

commit c5b471893d67391875f56db8d99c6c1849ba53bf
Author: Nektarios Paisios <nektar@chromium.org>
Date: Wed Dec 12 19:27:23 2018

Adds a new accessibility role to distinguish the TableView widget

The views/controls/table_view widget is implemented in different ways on different platforms.
On Windows it should be exposed as a list view control.
On Mac as a table view.
Since this widget behaves similar to the existing ARIA tree grid widget but without the functionality of expanding / collapsing columns, we decided to call it a list grid.
Note that even though it is similar the widget doesn't have the same keyboard shortcuts and accessibility tree hierarchy as an ARIA grid.
Please look at the MSAA hierarchy of the list view control in Windows File Explorer or the table view in Finder on the Mac for examples.
R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org
TBR=dominickn@chromium.org

Change-Id: I8225ff1424a65c3b7ff77bfba17094e69226ada2
Bug: 811277
Reviewed-on: https://chromium-review.googlesource.com/c/1371930
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615996}
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/c5b471893d67391875f56db8d99c6c1849ba53bf/ui/accessibility/platform/ax_platform_node_win.cc
►

Sign in to add a comment