New issue
Advanced search Search tips

Issue 811246 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in GetLayoutBox

Project Member Reported by ClusterFuzz, Feb 12 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4825604164419584

Fuzzer: attekett_dom_fuzzer
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x60f000014780
Crash State:
  GetLayoutBox
  GetLayoutBox
  blink::PaintLayerScrollableArea::RegisterForAnimation
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=535623:535643

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4825604164419584

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 12 2018

Labels: M-66
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 12 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 12 2018

Labels: Pri-1
Cc: szager@chromium.org
Owner: skobes@chromium.org
Status: Assigned (was: Untriaged)
Looks like regression from https://chromium.googlesource.com/chromium/src/+/96f85b68747a679ea1ac4cd05d6743ae5f7142b7
Components: Blink>Scroll
Project Member

Comment 6 by ClusterFuzz, Feb 12 2018

Components: Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 7 by skobes@chromium.org, Feb 12 2018

Cc: chrishtr@chromium.org skobes@chromium.org
Owner: bokan@chromium.org

Comment 8 by szager@chromium.org, Feb 13 2018

bokan@, this may be as simple as checking has_been_disposed_ from PaintLayerScrollableArea::RegisterForAnimation (and maybe also from PaintLayerScrollableArea::DeregisterForAnimation, for good measure).
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d02373d84f7c9f8c6705a5735a859574f34cf4e

commit 2d02373d84f7c9f8c6705a5735a859574f34cf4e
Author: Steve Kobes <skobes@chromium.org>
Date: Tue Feb 13 21:09:10 2018

Speculative fix for crashes in PLSA::RegisterForAnimation.

Bug:  811074 , 811246 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib3e7fb4ab6dab4ac53ffef7aaf6bdc96161c538d
Reviewed-on: https://chromium-review.googlesource.com/916734
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536473}
[modify] https://crrev.com/2d02373d84f7c9f8c6705a5735a859574f34cf4e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Project Member

Comment 10 by ClusterFuzz, Feb 14 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6250569824731136 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by ClusterFuzz, Feb 14 2018

ClusterFuzz has detected this issue as fixed in range 536320:536321.

Detailed report: https://clusterfuzz.com/testcase?key=4825604164419584

Fuzzer: attekett_dom_fuzzer
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x60f000014780
Crash State:
  GetLayoutBox
  GetLayoutBox
  blink::PaintLayerScrollableArea::RegisterForAnimation
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=535623:535643
Fixed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=536320:536321

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4825604164419584

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 14 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-0
I'm afraid the VRP panel declined to reward for this bug. Thanks for the report!
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Labels: -ReleaseBlock-Stable
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 27 2018

Labels: Merge-Request-67
Project Member

Comment 17 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ for M67 merge review. 
Labels: -Hotlist-Merge-Review -Merge-Review-67
Already in M66 (!), no merge needed.
Project Member

Comment 20 by sheriffbot@chromium.org, May 23 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment