Move browser cache clearing to shared state |
|||||||
Issue descriptionCurrently, as means to reduce noise, we clear various browser caches in Telemetry during possible_browser.Create. New stories, however, might want to have finer control on whether and when to clear such caches. We thus propose to pass ownership of this actions to the shared state (which in turn could delegate to individual stories if desired). In particular it should be able to: - stop an clear OS pagecache for it - stop and remove HTTPcache from under it
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/c5ec62416b5f8cbaf19567011c9ebf88aaabaea8 commit c5ec62416b5f8cbaf19567011c9ebf88aaabaea8 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Wed Feb 14 13:35:23 2018 [Telemetry] Move cache clearing code to possible_browser As a first step towards shifting the ownership of cache clearing decisions to the shared state, this CL: - provides a new possible_browser.FlushOsPageCaches() method - replaces browser.ClearCaches() with a new private method possible_browser._ClearCachesOnStart() There should be no behavior change on cache clearing at the moment. On follow up CLs _ClearCachesOnStart should be removed when the shared state code calls individual cache clearing methods as needed. Bug: chromium:811244 Change-Id: Ie9c274b2211eb1e1eff5aa5e074496a64df1aac3 Reviewed-on: https://chromium-review.googlesource.com/916603 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/c5ec62416b5f8cbaf19567011c9ebf88aaabaea8/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py [modify] https://crrev.com/c5ec62416b5f8cbaf19567011c9ebf88aaabaea8/telemetry/telemetry/internal/browser/possible_browser.py [modify] https://crrev.com/c5ec62416b5f8cbaf19567011c9ebf88aaabaea8/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py [modify] https://crrev.com/c5ec62416b5f8cbaf19567011c9ebf88aaabaea8/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py [modify] https://crrev.com/c5ec62416b5f8cbaf19567011c9ebf88aaabaea8/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Apr 30 2018
,
Jun 21 2018
In particular, for startup benchmarks with shared state we should not call _ClearCachesOnStart() in FindExistingBrowser() because the latter is called after the browser had started - too late to do flushing. Currently there is a workaround - avoid setting |clear_sytem_cache_for_browser_and_profile_on_start| for the story and flush the caches manually. So it is not a hard blocker. It would be good though to check the other benchmarks using this feature before removing _ClearCachesOnStart() from FindExistingBrowser().
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/4128a1eb529dc2b956aead5160e980e409e7d743 commit 4128a1eb529dc2b956aead5160e980e409e7d743 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Thu Jun 21 15:56:43 2018 [Telemetry] Add clear_caches option to possible_browser.Create This is a first step towards moving browser cache-clearing decisions out of the possible-browser and into the shared state. At the moment a clear_caches option is added for the Create() method, which defaults to True and maintains the current behavior. On Android's FindExistingBrowser() method we switch off cache-clearing already; and let its client, the android_go example benchmark, clear caches itself. On follow up CLs, shared state implementations will individually take control over cache-clearing responsibilities and while setting clear_caches=False to prevent "double-clearing". Finally, when all shared states have been migrated, both the option and the cache-clearing code in possible-browser's can be removed. Bug: chromium:811244 Change-Id: Ie0c2fb0c5f1665e2bf0383943b182bd6afc30135 Reviewed-on: https://chromium-review.googlesource.com/1110119 Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/4128a1eb529dc2b956aead5160e980e409e7d743/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py [modify] https://crrev.com/4128a1eb529dc2b956aead5160e980e409e7d743/telemetry/examples/benchmarks/android_go_benchmark.py [modify] https://crrev.com/4128a1eb529dc2b956aead5160e980e409e7d743/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py [modify] https://crrev.com/4128a1eb529dc2b956aead5160e980e409e7d743/telemetry/telemetry/internal/browser/possible_browser.py [modify] https://crrev.com/4128a1eb529dc2b956aead5160e980e409e7d743/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d370bf6746dba7d05a325c314cfc12b2693beb9c commit d370bf6746dba7d05a325c314cfc12b2693beb9c Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Jun 21 18:47:17 2018 Roll src/third_party/catapult 44fc6f687b35..53842b6cbc1f (11 commits) https://chromium.googlesource.com/catapult.git/+log/44fc6f687b35..53842b6cbc1f git log 44fc6f687b35..53842b6cbc1f --date=short --no-merges --format='%ad %ae %s' 2018-06-21 ckitagawa@chromium.org [Devil] Fix pylint typecheck errors 2018-06-21 perezju@chromium.org [Telemetry] Add clear_caches option to possible_browser.Create 2018-06-21 charliea@chromium.org Tell sqlite3 to use a write-ahead mode 2018-06-21 perezju@chromium.org Fix index of timeseries data frames 2018-06-21 perezju@chromium.org [Telemetry] Do not cache installed apps in AndroidPlatformBackend 2018-06-21 benjhayden@chromium.org Increase Anomaly query limit in graph_json. 2018-06-21 nednguyen@google.com Disable testWaitForJavaScriptCondition on Mac 2018-06-21 perezju@chromium.org [Telemetry] Example: restart browser during story 2018-06-21 perezju@chromium.org [Telemetry] Fix pylint unidiomatic-typecheck warnings 2018-06-21 perezju@chromium.org [soundwave] Code health in dashboard_api.py 2018-06-21 perezju@chromium.org [soundwave] Follow cursor on fetch alerts API call Created with: gclient setdep -r src/third_party/catapult@53842b6cbc1f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244,chromium:711073,chromium:854744, chromium:849703 , chromium:854986 TBR=sullivan@chromium.org Change-Id: I7a6383560447cee344a85996f9a7f595e0e9088c Reviewed-on: https://chromium-review.googlesource.com/1110297 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569338} [modify] https://crrev.com/d370bf6746dba7d05a325c314cfc12b2693beb9c/DEPS
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77e40a0648b708b8e1b92a5891b4bd0716a98589 commit 77e40a0648b708b8e1b92a5891b4bd0716a98589 Author: Egor Pasko <pasko@chromium.org> Date: Tue Sep 11 11:52:28 2018 clear_system_cache: Sync dirty pages before ClearCacheForFile(s) In http://crbug.com/881384#c2 I saw some more evidence that the page cache is not fully flushed when benchmarking. On Linux/Android calling sync(2) syscall before evicting individual files should help because the later pagecache dropping operations become a lot cheaper for the kernel. I could not find good documentation about sync(2) guarantees on MacOS. The page cache flushing for individual files is still asynchronous, with no cheap way to check that it happened. The plan is to sleep for one second after such operations. Since we would prefer to sleep only once per bulk of operations, the sleeping will be done on higher levels. The Windows story is not covered - the operation requires administrator privileges. Bug: 811244 Change-Id: Ib71f4f934a0eb4b438bfedbbb50462e07ff64308 Reviewed-on: https://chromium-review.googlesource.com/1211602 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#590266} [modify] https://crrev.com/77e40a0648b708b8e1b92a5891b4bd0716a98589/base/test/test_file_util.h [modify] https://crrev.com/77e40a0648b708b8e1b92a5891b4bd0716a98589/base/test/test_file_util_posix.cc [modify] https://crrev.com/77e40a0648b708b8e1b92a5891b4bd0716a98589/base/test/test_file_util_win.cc [modify] https://crrev.com/77e40a0648b708b8e1b92a5891b4bd0716a98589/tools/perf/clear_system_cache/clear_system_cache_main.cc
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/9f36d9f788130761c3611060bc7a104772761d15 commit 9f36d9f788130761c3611060bc7a104772761d15 Author: Egor Pasko <pasko@chromium.org> Date: Fri Sep 14 13:24:41 2018 FlushOsPageCaches: wait for dust to settle In [1] we found extra evidence for OS pagecache not being fully complete after possible_browser.FlushOsPageCaches() returns. A best-effort mitigation is in flight: [2]. This is another one, which is done at a level a bit higher to avoid pausing after each invocation of the clear_system_cache tool. [1] NOT_FOR_COMMIT: Sleep before/after pagecache flush https://chromium-review.googlesource.com/c/chromium/src/+/1210643 [2] clear_system_cache: Sync dirty pages before ClearCacheForFile(s) https://chromium-review.googlesource.com/c/chromium/src/+/1211602 Bug: chromium:811244 Bug: chromium:881384 Change-Id: I46cd699cdbd163fa7ca2470d8cbd580683dea2ad Reviewed-on: https://chromium-review.googlesource.com/1216346 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> [modify] https://crrev.com/9f36d9f788130761c3611060bc7a104772761d15/telemetry/telemetry/core/platform.py [modify] https://crrev.com/9f36d9f788130761c3611060bc7a104772761d15/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py [modify] https://crrev.com/9f36d9f788130761c3611060bc7a104772761d15/telemetry/telemetry/internal/browser/possible_browser.py
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8323f92cb0c81332c00abfe5a3bad012a400fd35 commit 8323f92cb0c81332c00abfe5a3bad012a400fd35 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Sep 14 16:52:21 2018 Roll src/third_party/catapult 3e071665b9f9..9f36d9f78813 (14 commits) https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..9f36d9f78813 git log 3e071665b9f9..9f36d9f78813 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 pasko@chromium.org FlushOsPageCaches: wait for dust to settle 2018-09-14 ulan@chromium.org Revert "Output DevTools error messages as warnings while running a story." 2018-09-13 simonhatch@chromium.org Dashboard - Error out on empty or uncompressed uploads 2018-09-13 sadrul@chromium.org rendering: Ignore trace-events for canceled draws. 2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner 2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug 2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions 2018-09-13 pasko@chromium.org clear_system_cache: update binaries 2018-09-13 anthonyalridge@google.com Create a link to traces from the CFG. 2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label. 2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it. 2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark 2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter. 2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story. Created with: gclient setdep -r src/third_party/catapult@9f36d9f78813 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244, chromium:881384 , chromium:883892 ,chromium:880432, chromium:883735 ,chromium:883592, chromium:882291 , chromium:881873 ,chromium:878390, chromium:881384 ,chromium:866423,chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432 TBR=sullivan@chromium.org Change-Id: I934e7e9b842518c75edbeb4a1604c2e06b577861 Reviewed-on: https://chromium-review.googlesource.com/1226380 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591375} [modify] https://crrev.com/8323f92cb0c81332c00abfe5a3bad012a400fd35/DEPS
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96212b78b6be9820a30e2b64a0984a848f1592b7 commit 96212b78b6be9820a30e2b64a0984a848f1592b7 Author: Egor Pasko <pasko@chromium.org> Date: Mon Sep 17 11:09:59 2018 startup_mobile benchmark: update comments Remove the comment about OS pagecache flushing, it is now handled for the benchmark. After @decorators.Disabled were deprecated and removed, the comment about applicability of this benchmark to non-Android platform looks more actionable at the head of the file. Bug: 811244 Change-Id: Id95321c2c10d5124f4bb2fa4e5fa49a2119e4d91 Reviewed-on: https://chromium-review.googlesource.com/1225804 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#591639} [modify] https://crrev.com/96212b78b6be9820a30e2b64a0984a848f1592b7/tools/perf/benchmarks/startup_mobile.py
,
Jan 4
Just reminder to self, the only two shared states that need updating are: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py?rcl=51771a7cad87fdf00c949740c06205e71de8830a&l=191 https://cs.chromium.org/chromium/src/tools/perf/page_sets/dual_browser_story.py?rcl=dcec81e12c80bd5a091645c554362f6c4d43febd&l=152 After migrating cache clearing responsibilities to those, we can finally remove cache clearing code in the possible browser. Also I think this is no longer blocking issue 760498.
,
Jan 4
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/b82ebb6bf22705498dd0abc34a66dbcdd0e6981f commit b82ebb6bf22705498dd0abc34a66dbcdd0e6981f Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Mon Jan 07 11:25:33 2019 [Telemetry] Move cache_clearing to SharedPageState Decisions of how and when to clear platform caches are being moved away from the possible_browser and into individual shared states. Bug: chromium:811244 Change-Id: I222c71a389686844d9cb1cfe912de3a0786ce9f6 Reviewed-on: https://chromium-review.googlesource.com/c/1396160 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> [modify] https://crrev.com/b82ebb6bf22705498dd0abc34a66dbcdd0e6981f/telemetry/telemetry/testing/fakes/__init__.py [modify] https://crrev.com/b82ebb6bf22705498dd0abc34a66dbcdd0e6981f/telemetry/telemetry/page/shared_page_state.py
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/665647085fb74390e69cfad0396664a7bc16b9f3 commit 665647085fb74390e69cfad0396664a7bc16b9f3 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Mon Jan 07 11:39:46 2019 [tools/perf] Move cache clearing to MultiBrowserSharedState Decisions of how and when to clear platform caches are being moved away from the possible_browser and into individual shared states. This fixes a bug, in fact, where platform dns caches were being cleared twice. Bug: chromium:811244 Change-Id: I0b1d787fd10f0fb657b15009f3e042f0af5fdc89 Reviewed-on: https://chromium-review.googlesource.com/c/1396318 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#620290} [modify] https://crrev.com/665647085fb74390e69cfad0396664a7bc16b9f3/tools/perf/page_sets/dual_browser_story.py
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5893c9b98572f906ed2a397b6779099ec9cdc89f commit 5893c9b98572f906ed2a397b6779099ec9cdc89f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Jan 07 12:26:05 2019 Roll src/third_party/catapult 865a64df6576..b82ebb6bf227 (1 commits) https://chromium.googlesource.com/catapult.git/+log/865a64df6576..b82ebb6bf227 git log 865a64df6576..b82ebb6bf227 --date=short --no-merges --format='%ad %ae %s' 2019-01-07 perezju@chromium.org [Telemetry] Move cache_clearing to SharedPageState Created with: gclient setdep -r src/third_party/catapult@b82ebb6bf227 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244 TBR=sullivan@chromium.org Change-Id: Ibc733553248820a61766267fdca96e58ea35c7ff Reviewed-on: https://chromium-review.googlesource.com/c/1397762 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620294} [modify] https://crrev.com/5893c9b98572f906ed2a397b6779099ec9cdc89f/DEPS
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 18
(5 days ago)
Work left to do here is to try to remove: browser_options.clear_sytem_cache_for_browser_and_profile_on_start by making it True everywhere. That should be desirable to make more deterministic measurements on all platforms/benchmarks. Looking through code history, this was selectively turned off in some benchmarks because it did blow up running time (c.f. issue 685240 ). I find that a bit strange, anyway, I'll to make a test CL switching this to True and run some try jobs to validate how much would the impact in running time be today.
,
Jan 18
(5 days ago)
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16ace3e2540000
,
Jan 18
(4 days ago)
📍 Job complete. See results below. https://pinpoint-dot-chromeperf.appspot.com/job/16ace3e2540000
,
Jan 21
(2 days ago)
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16a8c7fa540000
,
Yesterday
(41 hours ago)
📍 Job complete. See results below. https://pinpoint-dot-chromeperf.appspot.com/job/16a8c7fa540000
,
Yesterday
(37 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/d4e9197559c456c9614b50d403860fa8d49f3269 commit d4e9197559c456c9614b50d403860fa8d49f3269 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Jan 22 01:28:28 2019 [Telemetry] Disable clear_caches option from possible_browser.Create No clients should be setting this option to anything other than False. Assert that this is the case, and remove the now obsolete code paths. Bug: chromium:811244 Change-Id: I391412346619f6d8346f1bb3a03a5b395ab4f41b Reviewed-on: https://chromium-review.googlesource.com/c/1421398 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> [modify] https://crrev.com/d4e9197559c456c9614b50d403860fa8d49f3269/telemetry/telemetry/internal/browser/possible_browser.py [modify] https://crrev.com/d4e9197559c456c9614b50d403860fa8d49f3269/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py [modify] https://crrev.com/d4e9197559c456c9614b50d403860fa8d49f3269/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py [modify] https://crrev.com/d4e9197559c456c9614b50d403860fa8d49f3269/telemetry/telemetry/page/shared_page_state.py [modify] https://crrev.com/d4e9197559c456c9614b50d403860fa8d49f3269/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py [modify] https://crrev.com/d4e9197559c456c9614b50d403860fa8d49f3269/telemetry/telemetry/testing/fakes/__init__.py
,
Yesterday
(36 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d5cbffb15aa51d9fc93972af1610faa4a69acd5 commit 7d5cbffb15aa51d9fc93972af1610faa4a69acd5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Jan 22 02:56:58 2019 Roll src/third_party/catapult 43bcb969261e..d4e9197559c4 (1 commits) https://chromium.googlesource.com/catapult.git/+log/43bcb969261e..d4e9197559c4 git log 43bcb969261e..d4e9197559c4 --date=short --no-merges --format='%ad %ae %s' 2019-01-22 perezju@chromium.org [Telemetry] Disable clear_caches option from possible_browser.Create Created with: gclient setdep -r src/third_party/catapult@d4e9197559c4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244 TBR=sullivan@chromium.org Change-Id: I0bc1ac4bbf278cedc974b1f592f3b2ec40da4f0d Reviewed-on: https://chromium-review.googlesource.com/c/1426141 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624714} [modify] https://crrev.com/7d5cbffb15aa51d9fc93972af1610faa4a69acd5/DEPS
,
Today
(16 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa9dd4b64462d709ccfcc3f1622ffa9c9f8009d8 commit fa9dd4b64462d709ccfcc3f1622ffa9c9f8009d8 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Jan 22 22:21:44 2019 [tools/perf] Remove clear_caches=False option in possible_browser.Create This is the default behavior after: https://chromium-review.googlesource.com/c/catapult/+/1421398 No need to specify this option any more. Bug: 811244 Change-Id: Ia0d752bba86481ffa5e77d263a079a2f56a4da19 Reviewed-on: https://chromium-review.googlesource.com/c/1421191 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#624961} [modify] https://crrev.com/fa9dd4b64462d709ccfcc3f1622ffa9c9f8009d8/tools/perf/page_sets/dual_browser_story.py |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by perezju@chromium.org
, Feb 13 2018Status: Started (was: Available)