New issue
Advanced search Search tips

Issue 811229 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cc_unittests DamageShouldNotCareAboutContributingLayers fails under ubsan

Project Member Reported by h...@chromium.org, Feb 12 2018

Issue description

From https://ci.chromium.org/buildbot/chromium.clang/ToTLinuxUBSanVptr/1662

 RUN      ] LayerTreeHostImplTest.DamageShouldNotCareAboutContributingLayers
../../cc/trees/layer_tree_host_impl_unittest.cc:4531:7: runtime error: downcast of address 0x1d1c9cf82780 which does not point to an object of type 'cc::(anonymous namespace)::DidDrawCheckLayer'
0x1d1c9cf82780: note: object is of type 'cc::SolidColorLayerImpl'
 00 00 00 00  48 f1 e9 04 00 00 00 00  02 00 00 00 ff ff ff ff  00 fa e1 9c 1c 1d 00 00  c0 c1 de 9c
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'cc::SolidColorLayerImpl'
    #0 0x1934370  (/b/s/w/ir/out/Release/cc_unittests+0x1934370)
    #1 0x23d0595  (/b/s/w/ir/out/Release/cc_unittests+0x23d0595)
    #2 0x23d252b  (/b/s/w/ir/out/Release/cc_unittests+0x23d252b)
    #3 0x23d3e92  (/b/s/w/ir/out/Release/cc_unittests+0x23d3e92)
    #4 0x23e5087  (/b/s/w/ir/out/Release/cc_unittests+0x23e5087)
    #5 0x23e4073  (/b/s/w/ir/out/Release/cc_unittests+0x23e4073)
    #6 0x2855159  (/b/s/w/ir/out/Release/cc_unittests+0x2855159)
    #7 0x285b4f3  (/b/s/w/ir/out/Release/cc_unittests+0x285b4f3)
    #8 0x285b339  (/b/s/w/ir/out/Release/cc_unittests+0x285b339)
    #9 0x21e92ef  (/b/s/w/ir/out/Release/cc_unittests+0x21e92ef)
    #10 0x7f9c8f2b2f44  (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
    #11 0x806029  (/b/s/w/ir/out/Release/cc_unittests+0x806029)
 

Comment 1 by h...@chromium.org, Feb 12 2018

Cc: weiliangc@chromium.org
The test was added here: https://chromium-review.googlesource.com/899947

Comment 2 by h...@chromium.org, Feb 12 2018

Owner: h...@chromium.org
Status: Started (was: Available)
The fix is very simple: https://chromium-review.googlesource.com/#/c/chromium/src/+/911802

Comment 3 by h...@chromium.org, Feb 12 2018

Cc: treib@chromium.org
Owner: ----
Status: Available (was: Started)
Looks like original commit just got reverted: https://chromium-review.googlesource.com/913209

Should be easy to re-land with the fix from #2, but I'm leaving that to others.

Sign in to add a comment