New issue
Advanced search Search tips

Issue 811188 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Gerrit flake: CQ to merges to Git but doesn't update Gerrit status on submission

Reported by vpalatin@chromium.org, Feb 12 2018

Issue description

I have tried to submit 2 EC CLs (public and private) with a CQ-DEPEND on each other:
(public)
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/880955
(private)
https://chrome-internal-review.googlesource.com/c/chromeos/platform/ec-private/+/552559

Gerrit still thinks both are not submitted while there are both in their respective git repository:
https://chromium.googlesource.com/chromiumos/platform/ec/+/01cee655ab1eb2cf5271a1d578074a3252430ea0
https://chrome-internal.googlesource.com/chromeos/platform/ec-private/+/c6ae2cfb51d243d411270ff51d839db2c1996321
(I'm going to abandon them)

The public CL failed with:
The Commit Queue failed to apply your change in https://luci-milo.appspot.com/buildbot/chromeos/master-paladin/17709 . CL:880955 had no changes after rebasing to ToT.

The private CL failed with:
The Commit Queue failed to apply your change in https://luci-milo.appspot.com/buildbot/chromeos/master-paladin/17709 . CL:*552559 depends on CL:880955, which had no changes after rebasing to ToT.

Then the CL exonerator came :
"This CL has been marked innocent in the CL annotator; re-marking as CQ+1."

CL failed again ...

 
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>CI
Status: Available (was: Untriaged)
Summary: Gerrit flake: CQ to merges to Git but doesn't update Gerrit status on submission (was: CQ seems confused about which CL is submitted)
This isn't the issue I linked in Comment 2. Instead, this is Gerrit flakes recurring. Going to leave this open as the new bug for any such reports (though I don't think we've had any more since February).
Cc: athilenius@chromium.org
 Issue 804394  has been merged into this issue.
Most recent dupe is from January so I think we still aren't seeing a pattern of new reports since February.
Issue 849981 has been merged into this issue.
It happened again last night. Escalating to Gerrit team (yet again).
Per the Gerrit team, we can use the Fix Change REST API to try to automatically repair changes that we detect failed in this way. This is a workaround while Gerrit continues to investigate fixing the root cause on b/63796025 .

Labels: -Pri-2 Pri-1
Labels: -Type-Bug Type-Feature
We've been offered an API to clean up an entire git repository on a periodic basis and also permission to call this daily. Our current action item is to call this daily. This API was landed here: https://buganizer.corp.google.com/issues/63796025 .

Cc: ajp@chromium.org benchan@chromium.org
 Issue 830934  has been merged into this issue.
Cc: -athilenius@chromium.org

Sign in to add a comment