Spec: https://docs.google.com/presentation/d/1HDXjNMQVuubUdLnS4uF8xdwki4Lo7gSJSZi-VSq2LZ8/edit#slide=id.g32b1e762f8_2_35
WIP screenshots for https://chromium-review.googlesource.com/c/chromium/src/+/918202.
Updated App Info screenshot with separator.
Avoid removing Site Settings (save for future patch).
Updated screenshots with SecondaryUiMd feature enabled.
Demonstration of location bar and hosted app menu present at the same time.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c313230b7556d7a8f322056c335d381ff34d68b commit 0c313230b7556d7a8f322056c335d381ff34d68b Author: Alan Cutter <alancutter@chromium.org> Date: Wed Feb 21 05:09:02 2018 Show Page Info dialog from Hosted app menu > App Info This CL moves the App Info option to the top of the hosted app menu and makes it open the Page Info dialog instead of App Info. This includes a minor refactor to Page Info to specify where the anchor point should be. App Info option screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=324760&signed_aid=voiiQnz7zdyQ1ilYM_MXyQ==&inline=1 Page Info dialog screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=324761&signed_aid=5aA6lr7Kfq8lvTmkexIH0w==&inline=1 Bug: 811178 Change-Id: Id1e4907ec2f5618bee1376460c3fce0ee410d7c6 Reviewed-on: https://chromium-review.googlesource.com/918202 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#538023} [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/app/chrome_command_ids.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/apps/app_info_dialog.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/browser_command_controller.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/bubble_anchor_util.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/cocoa/browser_dialogs_views_mac.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/cocoa/bubble_anchor_util_views_mac.mm [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/extensions/hosted_app_menu_model.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/page_info/page_info_dialog.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/page_info/page_info_dialog.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/toolbar/app_menu_model.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/bubble_anchor_util_views.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/bubble_anchor_util_views.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/frame/browser_non_client_frame_view.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/chrome/browser/ui/views/page_info/page_info_bubble_view.h [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/testing/buildbot/filters/mash.browser_tests.filter [modify] https://crrev.com/0c313230b7556d7a8f322056c335d381ff34d68b/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter
As part of this we should also remove the Site Settings menu item as it is now redundant with access to the Page Info dialog.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9178903dcdb242495c220d272aa2cf4f00a62f36 commit 9178903dcdb242495c220d272aa2cf4f00a62f36 Author: Alan Cutter <alancutter@chromium.org> Date: Wed Feb 28 01:45:44 2018 Remove Site Settings from the hosted app menu The Site Settings menu item is redundant now that App Info opens Page Info. Screenshot: Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325940&signed_aid=mKxJj9vpE0mIciuf3E9g_w==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325941&signed_aid=oCB4Kp8aUnFYrOcoHCPGSg==&inline=1 Bug: 811178 Change-Id: Iacadd269f5152f42b7f6d0a6afb25c20b9329e26 Reviewed-on: https://chromium-review.googlesource.com/930442 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#539640} [modify] https://crrev.com/9178903dcdb242495c220d272aa2cf4f00a62f36/chrome/browser/ui/extensions/hosted_app_menu_model.cc [modify] https://crrev.com/9178903dcdb242495c220d272aa2cf4f00a62f36/chrome/browser/ui/toolbar/app_menu_model.cc [modify] https://crrev.com/9178903dcdb242495c220d272aa2cf4f00a62f36/chrome/browser/ui/toolbar/app_menu_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/689f89a063d70df856c7cdc79180deeaf8dbf871 commit 689f89a063d70df856c7cdc79180deeaf8dbf871 Author: Alan Cutter <alancutter@chromium.org> Date: Thu Mar 08 05:09:54 2018 Clean up redundant getter for AppMenuButton This is a simple clean up CL that has no changes in behaviour. The bubble anchor code can use the recently added ButtonProvider instead of a specialised getter on FrameView. Change-Id: Ia067afe36f07c3ce4b77344c28f6467e4a9a1801 Bug: 811178 Reviewed-on: https://chromium-review.googlesource.com/950642 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#541727} [modify] https://crrev.com/689f89a063d70df856c7cdc79180deeaf8dbf871/chrome/browser/ui/browser_command_controller.cc [modify] https://crrev.com/689f89a063d70df856c7cdc79180deeaf8dbf871/chrome/browser/ui/bubble_anchor_util.h [modify] https://crrev.com/689f89a063d70df856c7cdc79180deeaf8dbf871/chrome/browser/ui/views/bubble_anchor_util_views.cc [modify] https://crrev.com/689f89a063d70df856c7cdc79180deeaf8dbf871/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc [modify] https://crrev.com/689f89a063d70df856c7cdc79180deeaf8dbf871/chrome/browser/ui/views/frame/browser_non_client_frame_view.h [modify] https://crrev.com/689f89a063d70df856c7cdc79180deeaf8dbf871/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/689f89a063d70df856c7cdc79180deeaf8dbf871/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
Comment 1 by hwi@chromium.org
, Feb 13 2018