New issue
Advanced search Search tips

Issue 811159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Allow client to set custom_frame_view color

Project Member Reported by wutao@chromium.org, Feb 12 2018

Issue description

Allow client to set custom_frame_view color.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e446b43685e62ba0064892c485e14011ac9daf7

commit 8e446b43685e62ba0064892c485e14011ac9daf7
Author: wutao <wutao@chromium.org>
Date: Wed Feb 14 17:57:11 2018

cros: Allow client to set custom_frame_view color.

This cl allows client to set custom_frame_view color.
Changes:
1. Add OnWindowPropertyChanged to CustomFrameViewAshWindowStateDelegate.
2. Client can set custom_frame_view color by setting window property
aura::client::kTopViewColor.

Bug:  811159 , 768932
Test: CustomFrameViewAshTest.KTopViewColor and manually test color update.
Change-Id: Ic2306c399b0d4cda88ffb0f96c48a15e3e6f430b
Reviewed-on: https://chromium-review.googlesource.com/912518
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536748}
[modify] https://crrev.com/8e446b43685e62ba0064892c485e14011ac9daf7/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/8e446b43685e62ba0064892c485e14011ac9daf7/ash/frame/custom_frame_view_ash.h
[modify] https://crrev.com/8e446b43685e62ba0064892c485e14011ac9daf7/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/8e446b43685e62ba0064892c485e14011ac9daf7/ash/frame/default_frame_header.cc
[modify] https://crrev.com/8e446b43685e62ba0064892c485e14011ac9daf7/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/8e446b43685e62ba0064892c485e14011ac9daf7/ash/public/cpp/window_properties.h

Comment 2 by wutao@chromium.org, Mar 6 2018

Status: Fixed (was: Available)

Sign in to add a comment