New issue
Advanced search Search tips

Issue 811144 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::LayoutObject::MaybeClearIsScrollAnchorObject

Project Member Reported by ClusterFuzz, Feb 12 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5091673965854720

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x114e98a459c4
Crash State:
  blink::LayoutObject::MaybeClearIsScrollAnchorObject
  blink::RootFrameViewport::SetLayoutViewport
  blink::PaintLayerScrollableArea::Dispose
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=533688:533710

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5091673965854720

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: skobes@chromium.org szager@chromium.org
Of the CLs in range, https://chromium.googlesource.com/chromium/src/+/fe8c4db4003022f5cb12506a15cc78ea6633bbdf looks most promising?
 Issue 811179  has been merged into this issue.
Cc: -szager@chromium.org
Components: Blink>Scroll
Labels: Pri-1
Owner: szager@chromium.org
Status: Assigned (was: Untriaged)
szager@, this has introduced multiple security regressions. I see do not revert in your cl, please take a look soon to fix this regression. Otherwise, please revert.
Project Member

Comment 4 by ClusterFuzz, Feb 12 2018

Labels: OS-Linux
Project Member

Comment 5 by ClusterFuzz, Feb 12 2018

Components: Blink>Internals Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 12 2018

Labels: M-66
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 12 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by skobes@chromium.org, Feb 12 2018

Cc: bokan@chromium.org chrishtr@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae6f0ca22561ab9cef4a0e46d37faf67333a460

commit dae6f0ca22561ab9cef4a0e46d37faf67333a460
Author: Stefan Zager <szager@chromium.org>
Date: Tue Feb 13 10:52:43 2018

[RootLayerScrolls] Speculative fix for crasher

The call from PaintLayerScrollableArea::Dispose into
TopDocumentRootScrollerController::DidDisposeScrollableArea can call
back into the PLSA's ScrollAnchor, which may point to a LayoutObject
which has already been deleted.

The ScrollAnchor is no longer needed, so clear it out aggressively.

BUG= 811144 
R=skobes@chromium.org,bokan@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2121105ed0b4118f966c25682236649d33d3c055
Reviewed-on: https://chromium-review.googlesource.com/914864
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536329}
[modify] https://crrev.com/dae6f0ca22561ab9cef4a0e46d37faf67333a460/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/dae6f0ca22561ab9cef4a0e46d37faf67333a460/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/dae6f0ca22561ab9cef4a0e46d37faf67333a460/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/dae6f0ca22561ab9cef4a0e46d37faf67333a460/third_party/WebKit/Source/core/layout/ScrollAnchor.h
[modify] https://crrev.com/dae6f0ca22561ab9cef4a0e46d37faf67333a460/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Cc: vmp...@chromium.org
Project Member

Comment 11 by ClusterFuzz, Feb 14 2018

ClusterFuzz has detected this issue as fixed in range 536325:536340.

Detailed report: https://clusterfuzz.com/testcase?key=5091673965854720

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x114e98a459c4
Crash State:
  blink::LayoutObject::MaybeClearIsScrollAnchorObject
  blink::RootFrameViewport::SetLayoutViewport
  blink::PaintLayerScrollableArea::Dispose
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=533688:533710
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=536325:536340

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5091673965854720

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Feb 14 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5091673965854720 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Feb 14 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Labels: -ReleaseBlock-Stable
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 27 2018

Labels: Merge-Request-67
Project Member

Comment 17 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The fix in #9 landed in M66, so I'm not sure why SheriffBot added a merge request. https://storage.googleapis.com/chromium-find-releases-static/dae.html#dae6f0ca22561ab9cef4a0e46d37faf67333a460
Cc: awhalley@chromium.org
+awhalley@ for M67 merge review. 
Labels: -Merge-Review-67
Removing "Merge-Review-67" label per comment #18.
Project Member

Comment 21 by sheriffbot@chromium.org, May 23 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment