New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811121 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

Add a test to prevent new libgcc_s/libstdc++ users

Project Member Reported by manojgupta@chromium.org, Feb 11 2018

Issue description

We have moved to use llvm based libraries. Add a test to prevent new dependencies on libgcc_s and libstdc++.
Only a few whitelisted files e.g. binaries delivered from outside Chrome OS should use  libgcc_s/libstdc++.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0595afb7ab7b1fb79ad14208223462b9f7e5c219

commit 0595afb7ab7b1fb79ad14208223462b9f7e5c219
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Feb 14 05:16:16 2018

platform_ToolchainOptions: Add check for libgcc_s/libstdc++.

As part of migration to llvm based libraries, we want to
prevent new dependencies on libgcc_s/libstdc++. Add a new check
to platform_ToolchainOptions to do so.
Whitelist any current users e.g. binaries delivered from outside,
or built using gcc.

BUG= chromium:811121 
TEST=link/eve/lump/daisy/kevin tryjobs passed with hwtest.

Change-Id: Ic0ced8a33c9d4267a91bebad0754dcac411673c4
Reviewed-on: https://chromium-review.googlesource.com/911995
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/0595afb7ab7b1fb79ad14208223462b9f7e5c219/client/site_tests/platform_ToolchainOptions/libstdcxx_whitelist
[modify] https://crrev.com/0595afb7ab7b1fb79ad14208223462b9f7e5c219/client/site_tests/platform_ToolchainOptions/platform_ToolchainOptions.py
[add] https://crrev.com/0595afb7ab7b1fb79ad14208223462b9f7e5c219/client/site_tests/platform_ToolchainOptions/libgcc_whitelist

Status: Verified (was: Untriaged)

Comment 3 by laszio@chromium.org, Feb 17 2018

Labels: regression-tests
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/367e5e8568a69fda19eb329b7d125d6cc7ff6904

commit 367e5e8568a69fda19eb329b7d125d6cc7ff6904
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Feb 22 06:26:46 2018

platform_Toolchainoptions: Whitelist mores files in libgcc/stdlibc++ tests.

Whitelist more files that are delivered as binaries in Chrome OS
from libstdc++/libgcc tests.
Whitelist files installed by crosvm (https://crbug.com/814480).

BUG= chromium:811121 
TEST=No more platform_Toolchain options failures in nyan boards.

Change-Id: I1b031a1f02b5842bf17e90b4d3bbc6ea7ec460ca
Reviewed-on: https://chromium-review.googlesource.com/929358
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/367e5e8568a69fda19eb329b7d125d6cc7ff6904/client/site_tests/platform_ToolchainOptions/libstdcxx_whitelist
[modify] https://crrev.com/367e5e8568a69fda19eb329b7d125d6cc7ff6904/client/site_tests/platform_ToolchainOptions/libgcc_whitelist

Sign in to add a comment