New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security
Team-Security-UX



Sign in to add a comment

Myanmar character in domain names can lead to spoofing

Reported by zxyrz...@gmail.com, Feb 11 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36

Steps to reproduce the problem:
http://google.xn--rid4c.com/ not shown in punycode
and you can regist domain ငဝ.com

What is the expected behavior?

What went wrong?
Myanmar (1000— 109F)
U+1004 (င) => c
U+101d (ဝ) => o
U+100c (ဌ) => g
U+1042 (၂) => j
U+1054 (ၔ) => e

Did this work before? N/A 

Chrome version: 64.0.3282.140  Channel: stable
OS Version: OS X 10.13.3
Flash Version: Shockwave Flash 28.0 r0
 
屏幕快照 2018-02-11 下午11.51.47.png
8.3 KB View Download
Cc: js...@chromium.org mgiuca@chromium.org
Components: UI>Security>UrlFormatting UI>Internationalization
Status: Untriaged (was: Unconfirmed)
This could well be working as expected, insofar as "google.co.com" isn't a real domain and doesn't look like one either. Inter-label character set mixing is different than Intra-label mixing. As noted in https://www.chromium.org/developers/design-documents/idn-in-google-chrome,

"Google Chrome decides if it should show Unicode or punycode for each domain label (component) of a hostname separately."

Owner: js...@chromium.org
Status: Assigned (was: Untriaged)
Jshin@, can you please triage and close if this is working as intended.

Comment 3 by js...@chromium.org, Feb 13 2018

Status: WontFix (was: Assigned)
This is rather interesting. According to registry.co.com, co.com tries to attract those without .com domain to get an alternative ( <foo>.co.com).  

Anyway, this is working as intended.  


Comment 4 by js...@chromium.org, Feb 14 2018

Status: Started (was: WontFix)
I'm adding the following 4 entries to the confusability list for Chrome:

U+1004 (င) => c
U+100c (ဌ) => g
U+1042 (၂) => j
U+1054 (ၔ) => e

Thank you for reporting. 


U+101d (ဝ) => o  // this is already covered by Unicode data. 

Comment 5 by js...@chromium.org, Feb 14 2018

Cc: -js...@chromium.org markda...@google.com sffc@google.com bstell@google.com

Comment 6 by och...@chromium.org, Feb 14 2018

Labels: Security_Severity-Medium Security_Impact-Stable

Comment 7 by zxyrz...@gmail.com, Feb 15 2018

Thank for the fast fix :-)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37747f4a4972e6d44d3f956f8d3a63255ef0941a

commit 37747f4a4972e6d44d3f956f8d3a63255ef0941a
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Feb 15 06:56:39 2018

Add more entries to the confusability mapping

U+014B (ŋ) => n
U+1004 (င) => c
U+100c (ဌ) => g
U+1042 (၂) => j
U+1054 (ၔ) => e

Bug:  811117 , 808316 
Test: components_unittests -gtest_filter=*IDN*
Change-Id: I29f73c48d665bd9070050bd7f0080563635b9c63
Reviewed-on: https://chromium-review.googlesource.com/919423
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536955}
[modify] https://crrev.com/37747f4a4972e6d44d3f956f8d3a63255ef0941a/components/url_formatter/idn_spoof_checker.cc
[modify] https://crrev.com/37747f4a4972e6d44d3f956f8d3a63255ef0941a/components/url_formatter/top_domains/test_domains.list
[modify] https://crrev.com/37747f4a4972e6d44d3f956f8d3a63255ef0941a/components/url_formatter/top_domains/test_skeletons.gperf
[modify] https://crrev.com/37747f4a4972e6d44d3f956f8d3a63255ef0941a/components/url_formatter/url_formatter_unittest.cc

Project Member

Comment 9 by sheriffbot@chromium.org, Feb 15 2018

Labels: M-65
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 15 2018

Labels: -Pri-2 Pri-1

Comment 11 by js...@chromium.org, Feb 19 2018

Status: Fixed (was: Started)
http://google.xn--rid4c.com/ will not be blocked (comment #1, comment #3), but if there's a domain in the top 10k list which can be spoofed by 5 Burmese characters in comment 4, it'll be blocked.


Project Member

Comment 12 by sheriffbot@chromium.org, Feb 19 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: reward-topanel
Labels: -reward-topanel reward-unpaid reward-500
*** Boilerplate reminders! ***
Please do NOT publicly disclose details until a fix has been released to all our users. Early public disclosure may cancel the provisional reward. Also, please be considerate about disclosure when the bug affects a core library that may be used by other products. Please do NOT share this information with third parties who are not directly involved in fixing the bug. Doing so may cancel the provisional reward. Please be honest if you have already disclosed anything publicly or to third parties. Lastly, we understand that some of you are not interested in money. We offer the option to donate your reward to an eligible charity. If you prefer this option, let us know and we will also match your donation - subject to our discretion. Any rewards that are unclaimed after 12 months will be donated to a charity of our choosing.
*********************************
Congrats zxyrzg02@ - the VRP panel decided to award $500 for this report. A member of our finance team will be in touch to arrange payment. Also, how would you like to be credited in our release notes?
Labels: -reward-unpaid reward-inprocess

Comment 17 by zxyrz...@gmail.com, Feb 27 2018

Thanks for the reward! Please credit as "LnyasZhang"
Or credit as "Lnyas Zhang", thanks a lot
Labels: -M-65 M-66
Project Member

Comment 20 by sheriffbot@chromium.org, Mar 16

Labels: Merge-Request-66
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 16

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Approved for M66 - branch:3359
The CL for this bug was landed on Feb 15 (2 weeks before M66 branch) :-)

See comment 8. 
Labels: -Merge-Approved-66
Labels: Release-0-M66
Labels: CVE-2018-6100
Labels: CVE_description-missing
Project Member

Comment 28 by sheriffbot@chromium.org, May 28

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment