Relative links hardwired upon save
Reported by
jidanni@gmail.com,
Feb 11 2018
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36 Example URL: Steps to reproduce the problem: 1. Browse a file, e.g., https://en.wikipedia.org/wiki/Help:Table 2. Now do CTRL+S, save Webpage Complete. 3. Now offline, browse the saved file. In Firefox, the relative links are still functional offline. E.g., <a href="#Setting_borders"><span class="tocnumber">4.2.3</span> <span class="toctext">Setting borders</span></a> But in chromium, the relative links are now the totally useless (offline) hard links: <a href="https://en.wikipedia.org/wiki/Help:Table#Setting_borders"><span class="tocnumber">4.2.3</span> <span class="toctext">Setting borders</span></a> What is the expected behavior? What went wrong? Internal links useless offline. Did this work before? N/A Chrome version: 64.0.3282.119 Channel: n/a OS Version: Flash Version: We saved the file for offline use, right?
,
Feb 12 2018
Tested this issue on chrome reported version 64.0.3282.119 using Ubuntu 14.04 with steps mentioned below: 1) Launched chrome reported version and navigated to https://en.wikipedia.org/wiki/Help:Table 2) Now CTRL+S, saved the Web page and went to offline, browse the saved file 3) File opened in browser and unable to access links init Observed the same behaviour in Firefox @Reporter: Please find the attached screen cast for your reference and let us know if we have missed any steps in reproducing the issue. Thanks!
,
Feb 12 2018
Thank you however you tested by clicking a SubPage Link, not a internal link. Here are the internal links: Contents [hide] 1 Using the toolbar 2 Basic table markup summary 2.1 HTML attributes 3 Pipe syntax tutorial 3.1 Rendering the pipe 4 Examples 4.1 Simple straightforward tables 4.1.1 Minimalist table 4.1.2 Multiplication table 4.2 Whole table operations 4.2.1 Captions and summaries 4.2.2 Width, height 4.2.3 Setting borders...
,
Feb 12 2018
Thank you for providing more feedback. Adding requester "viswa.karala@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 12 2018
,
May 29 2018
jidanni@ Thanks for the update. Tested the issue on Mac OS 10.13.3 and Windows 10 on the latest Stable and Canary and unable to reproduce the issue. On saving the given page as html -> turning off the wifi and clicking on the internal links as per comment #3, can observe the message ' There is no Internet Connection'. The same is observed on Firefox as well. Request you to provide a screen cast of the steps followed to reproduce the issue which will help in further triaging. Thanks..
,
May 31 2018
Here I compare Firefox and Chome saved INTERNAL link behaviour for i in /tmp/??KK.html #FFKK and CHKK are the two files I save in do mech-dump --links file://$i | sort -u > $i.L done comm -3 /tmp/*.L # #Alignment #Basic_table_markup_summary #Border #Captions #Captions_and_summaries #Cell_content_indenting #Cell_operations #Cells #Cells_spanning_multiple_rows_or_columns #Centering_tables #Centering_tables_2 #Classes #Collapsible_tables #Color;_scope_of_parameters #Column_operations #Combined_use_of_COLSPAN_and_ROWSPAN #Comparison_of_table_syntax #Conditional_table_row #Converting_spreadsheets_and_database_tables_to_wikitable_format #Decimal_point_alignment #Examples #External_links #Floating_images_in_the_center #Floating_table #HTML_attributes #Headers #Height #Indenting_tables #Minimalist_table #More_complex_examples #Multiplication_table #Mélange #Nested_tables #Non-rectangular_tables #Notes #Nowrap #Numerical_and_year_sorting_problems #Other_table_syntax #Pipe_syntax_in_terms_of_the_HTML_produced #Pipe_syntax_tutorial #Positioning #Rendering_the_pipe #Row_operations #Row_template #Rows #Scrolling #Section_link_or_map_link_to_a_row_anchor #See_also #Setting_borders #Setting_cell_parameters #Setting_column_widths #Shifting/centering #Simple_straightforward_tables #Sortable_tables #Sorting #Sorting_and_collapsing #Table_cell_templates #Table_row_1 #Table_row_10 #Table_row_11 #Table_row_12 #Table_row_13 #Table_row_14 #Table_row_15 #Table_row_16 #Table_row_17 #Table_row_18 #Table_row_19 #Table_row_2 #Table_row_20 #Table_row_21 #Table_row_22 #Table_row_23 #Table_row_24 #Table_row_25 #Table_row_26 #Table_row_27 #Table_row_28 #Table_row_29 #Table_row_3 #Table_row_30 #Table_row_31 #Table_row_32 #Table_row_33 #Table_row_34 #Table_row_35 #Table_row_36 #Table_row_37 #Table_row_38 #Table_row_39 #Table_row_4 #Table_row_40 #Table_row_41 #Table_row_5 #Table_row_6 #Table_row_7 #Table_row_8 #Tables #Tables_and_the_Visual_Editor #Tables_with_captions #Tooltips #Using_class_mw-collapsible #Using_the_toolbar #Vertical_alignment_in_cells #Vertically_oriented_column_headers #Whole_table_operations #Width,_height #Wikimedia_sister_projects #Wikitable_as_image_gallery #Workarounds #cite_note-1 #cite_note-2 #cite_ref-1 #cite_ref-2 #mw-datatable #mw-head #p-search #wikitable_class ./Help_Table - Wikipedia_files/load(2).php ./Help_Table - Wikipedia_files/load(3).php ./Help_Table - Wikipedia_files/load(4).php ./Help_Table - Wikipedia_files/load.php Help:Table%20-%20Wikipedia_files/load.css Help:Table%20-%20Wikipedia_files/load_002.css Help:Table%20-%20Wikipedia_files/load_003.css Help:Table%20-%20Wikipedia_files/load_004.css https://en.wikipedia.org/wiki/Help:Table# https://en.wikipedia.org/wiki/Help:Table#Alignment https://en.wikipedia.org/wiki/Help:Table#Basic_table_markup_summary https://en.wikipedia.org/wiki/Help:Table#Border https://en.wikipedia.org/wiki/Help:Table#Captions https://en.wikipedia.org/wiki/Help:Table#Captions_and_summaries https://en.wikipedia.org/wiki/Help:Table#Cell_content_indenting https://en.wikipedia.org/wiki/Help:Table#Cell_operations https://en.wikipedia.org/wiki/Help:Table#Cells https://en.wikipedia.org/wiki/Help:Table#Cells_spanning_multiple_rows_or_columns https://en.wikipedia.org/wiki/Help:Table#Centering_tables https://en.wikipedia.org/wiki/Help:Table#Centering_tables_2 https://en.wikipedia.org/wiki/Help:Table#Classes https://en.wikipedia.org/wiki/Help:Table#Collapsible_tables https://en.wikipedia.org/wiki/Help:Table#Color;_scope_of_parameters https://en.wikipedia.org/wiki/Help:Table#Column_operations https://en.wikipedia.org/wiki/Help:Table#Combined_use_of_COLSPAN_and_ROWSPAN https://en.wikipedia.org/wiki/Help:Table#Comparison_of_table_syntax https://en.wikipedia.org/wiki/Help:Table#Conditional_table_row https://en.wikipedia.org/wiki/Help:Table#Converting_spreadsheets_and_database_tables_to_wikitable_format https://en.wikipedia.org/wiki/Help:Table#Decimal_point_alignment https://en.wikipedia.org/wiki/Help:Table#Examples https://en.wikipedia.org/wiki/Help:Table#External_links https://en.wikipedia.org/wiki/Help:Table#Floating_images_in_the_center https://en.wikipedia.org/wiki/Help:Table#Floating_table https://en.wikipedia.org/wiki/Help:Table#HTML_attributes https://en.wikipedia.org/wiki/Help:Table#Headers https://en.wikipedia.org/wiki/Help:Table#Height https://en.wikipedia.org/wiki/Help:Table#Indenting_tables https://en.wikipedia.org/wiki/Help:Table#M%C3%A9lange https://en.wikipedia.org/wiki/Help:Table#Minimalist_table https://en.wikipedia.org/wiki/Help:Table#More_complex_examples https://en.wikipedia.org/wiki/Help:Table#Multiplication_table https://en.wikipedia.org/wiki/Help:Table#Nested_tables https://en.wikipedia.org/wiki/Help:Table#Non-rectangular_tables https://en.wikipedia.org/wiki/Help:Table#Notes https://en.wikipedia.org/wiki/Help:Table#Nowrap https://en.wikipedia.org/wiki/Help:Table#Numerical_and_year_sorting_problems https://en.wikipedia.org/wiki/Help:Table#Other_table_syntax https://en.wikipedia.org/wiki/Help:Table#Pipe_syntax_in_terms_of_the_HTML_produced https://en.wikipedia.org/wiki/Help:Table#Pipe_syntax_tutorial https://en.wikipedia.org/wiki/Help:Table#Positioning https://en.wikipedia.org/wiki/Help:Table#Rendering_the_pipe https://en.wikipedia.org/wiki/Help:Table#Row_operations https://en.wikipedia.org/wiki/Help:Table#Row_template https://en.wikipedia.org/wiki/Help:Table#Rows https://en.wikipedia.org/wiki/Help:Table#Scrolling https://en.wikipedia.org/wiki/Help:Table#Section_link_or_map_link_to_a_row_anchor https://en.wikipedia.org/wiki/Help:Table#See_also https://en.wikipedia.org/wiki/Help:Table#Setting_borders https://en.wikipedia.org/wiki/Help:Table#Setting_cell_parameters https://en.wikipedia.org/wiki/Help:Table#Setting_column_widths https://en.wikipedia.org/wiki/Help:Table#Shifting/centering https://en.wikipedia.org/wiki/Help:Table#Simple_straightforward_tables https://en.wikipedia.org/wiki/Help:Table#Sortable_tables https://en.wikipedia.org/wiki/Help:Table#Sorting https://en.wikipedia.org/wiki/Help:Table#Sorting_and_collapsing https://en.wikipedia.org/wiki/Help:Table#Table_cell_templates https://en.wikipedia.org/wiki/Help:Table#Table_row_1 https://en.wikipedia.org/wiki/Help:Table#Table_row_10 https://en.wikipedia.org/wiki/Help:Table#Table_row_11 https://en.wikipedia.org/wiki/Help:Table#Table_row_12 https://en.wikipedia.org/wiki/Help:Table#Table_row_13 https://en.wikipedia.org/wiki/Help:Table#Table_row_14 https://en.wikipedia.org/wiki/Help:Table#Table_row_15 https://en.wikipedia.org/wiki/Help:Table#Table_row_16 https://en.wikipedia.org/wiki/Help:Table#Table_row_17 https://en.wikipedia.org/wiki/Help:Table#Table_row_18 https://en.wikipedia.org/wiki/Help:Table#Table_row_19 https://en.wikipedia.org/wiki/Help:Table#Table_row_2 https://en.wikipedia.org/wiki/Help:Table#Table_row_20 https://en.wikipedia.org/wiki/Help:Table#Table_row_21 https://en.wikipedia.org/wiki/Help:Table#Table_row_22 https://en.wikipedia.org/wiki/Help:Table#Table_row_23 https://en.wikipedia.org/wiki/Help:Table#Table_row_24 https://en.wikipedia.org/wiki/Help:Table#Table_row_25 https://en.wikipedia.org/wiki/Help:Table#Table_row_26 https://en.wikipedia.org/wiki/Help:Table#Table_row_27 https://en.wikipedia.org/wiki/Help:Table#Table_row_28 https://en.wikipedia.org/wiki/Help:Table#Table_row_29 https://en.wikipedia.org/wiki/Help:Table#Table_row_3 https://en.wikipedia.org/wiki/Help:Table#Table_row_30 https://en.wikipedia.org/wiki/Help:Table#Table_row_31 https://en.wikipedia.org/wiki/Help:Table#Table_row_32 https://en.wikipedia.org/wiki/Help:Table#Table_row_33 https://en.wikipedia.org/wiki/Help:Table#Table_row_34 https://en.wikipedia.org/wiki/Help:Table#Table_row_35 https://en.wikipedia.org/wiki/Help:Table#Table_row_36 https://en.wikipedia.org/wiki/Help:Table#Table_row_37 https://en.wikipedia.org/wiki/Help:Table#Table_row_38 https://en.wikipedia.org/wiki/Help:Table#Table_row_39 https://en.wikipedia.org/wiki/Help:Table#Table_row_4 https://en.wikipedia.org/wiki/Help:Table#Table_row_40 https://en.wikipedia.org/wiki/Help:Table#Table_row_41 https://en.wikipedia.org/wiki/Help:Table#Table_row_5 https://en.wikipedia.org/wiki/Help:Table#Table_row_6 https://en.wikipedia.org/wiki/Help:Table#Table_row_7 https://en.wikipedia.org/wiki/Help:Table#Table_row_8 https://en.wikipedia.org/wiki/Help:Table#Tables https://en.wikipedia.org/wiki/Help:Table#Tables_and_the_Visual_Editor https://en.wikipedia.org/wiki/Help:Table#Tables_with_captions https://en.wikipedia.org/wiki/Help:Table#Tooltips https://en.wikipedia.org/wiki/Help:Table#Using_class_mw-collapsible https://en.wikipedia.org/wiki/Help:Table#Using_the_toolbar https://en.wikipedia.org/wiki/Help:Table#Vertical_alignment_in_cells https://en.wikipedia.org/wiki/Help:Table#Vertically_oriented_column_headers https://en.wikipedia.org/wiki/Help:Table#Whole_table_operations https://en.wikipedia.org/wiki/Help:Table#Width,_height https://en.wikipedia.org/wiki/Help:Table#Wikimedia_sister_projects https://en.wikipedia.org/wiki/Help:Table#Wikitable_as_image_gallery https://en.wikipedia.org/wiki/Help:Table#Workarounds https://en.wikipedia.org/wiki/Help:Table#cite_note-1 https://en.wikipedia.org/wiki/Help:Table#cite_note-2 https://en.wikipedia.org/wiki/Help:Table#cite_ref-1 https://en.wikipedia.org/wiki/Help:Table#cite_ref-2 https://en.wikipedia.org/wiki/Help:Table#mw-datatable https://en.wikipedia.org/wiki/Help:Table#mw-head https://en.wikipedia.org/wiki/Help:Table#p-search https://en.wikipedia.org/wiki/Help:Table#wikitable_class
,
May 31 2018
As you can see, Firefox saved them as proper internal # links, whereas chromium slapped an https in front of them, causing them to give you the ' There is no Internet Connection' message, Note again I am only talking about the INTERNAL (pointing to places within the same page) links.
,
May 31 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 29
It's converting all relative URIs in links into fully-qualified resolved URIs, which is not what you want. Try it with the attached test case. You need to load it, save it as "Webpage, Complete", load the saved copy in a second tab, and look at the difference. There is no need to pull the ethernet cable or click any links (which are dummy links anyway). I surmise that the HTML serializer is using the href property of the HTMLAnchorElement object when it should be outputting the href attribute of the A tag. (the former is always fully-qualified; the latter can be relative)
,
Dec 24
BTW when I said "load it" in the previous comment, I mean you have to click "Download" and then open the saved file, not click "View" which just shows source. There is currently no way to directly view attachments on chromium.org, presumably due to security concerns (which could be avoided by using a separate domain for attachments, but I guess it's not a priority)
,
Dec 24
@viswa.karala@chromium.org and @susan.boorgula@chromium.org if you both "observed the same behaviour in Firefox" then you must have misunderstood something. Perhaps you opened the same saved file in chrome and firefox? The bug occurs when saving the file, not when re-opening it. It is perhaps debatable whether some links should be altered when saving a page - for example, if you save several web pages that link to each other, it is convenient to make the links point to the local saved copies even if they had been absolute, fully-qualified URIs on the server. However, there is no question that links pointing to sections inside the document itself, which consist only of a URI fragment (looks like a #hashtag) and are the most "relative" links possible, should not be altered. Chrome is altering them and Firefox is not. Firefox is right. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by krajshree@chromium.org
, Feb 11 2018