New issue
Advanced search Search tips

Issue 811075 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Collections: Create cell catalog in Settings

Project Member Reported by rohitrao@chromium.org, Feb 10 2018

Issue description

Create a cell catalog as a Debug-only Settings subscreen.  This will be analogous to the "Material Cell Catalog" screen.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78f1c2cf7a53bd2b0d8d51924b3c92b7f53786dd

commit 78f1c2cf7a53bd2b0d8d51924b3c92b7f53786dd
Author: Rohit Rao <rohitrao@google.com>
Date: Mon Feb 12 16:59:20 2018

[ios] Creates a base class for Settings table views.

Integrating with the MDC AppBar requires a bunch of boilerplate setup
and scrollview delegate code.  Move that code to a separate base class,
so that the tableview cell catalog class becomes simpler and easier to
read.

BUG= 811075 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8a14d2f8aacc60480c50ee1a361c3413b82dd20a
Reviewed-on: https://chromium-review.googlesource.com/913669
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536109}
[modify] https://crrev.com/78f1c2cf7a53bd2b0d8d51924b3c92b7f53786dd/ios/chrome/browser/ui/settings/BUILD.gn
[add] https://crrev.com/78f1c2cf7a53bd2b0d8d51924b3c92b7f53786dd/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h
[add] https://crrev.com/78f1c2cf7a53bd2b0d8d51924b3c92b7f53786dd/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm
[modify] https://crrev.com/78f1c2cf7a53bd2b0d8d51924b3c92b7f53786dd/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.h
[modify] https://crrev.com/78f1c2cf7a53bd2b0d8d51924b3c92b7f53786dd/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm

Comment 3 by sczs@chromium.org, Feb 14 2018

NextAction: 2018-02-28
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be78c4b34444218019e10c3d4206b2884b8208cd

commit be78c4b34444218019e10c3d4206b2884b8208cd
Author: Rohit Rao <rohitrao@chromium.org>
Date: Thu Feb 15 17:26:23 2018

[ios] Uses ChromeTableViewController for the Settings cell catalog.

BUG= 811075 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6e05590248f2d54e395463c10a660582cf72731a
Reviewed-on: https://chromium-review.googlesource.com/921763
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537058}
[modify] https://crrev.com/be78c4b34444218019e10c3d4206b2884b8208cd/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/be78c4b34444218019e10c3d4206b2884b8208cd/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h
[modify] https://crrev.com/be78c4b34444218019e10c3d4206b2884b8208cd/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm

Status: Fixed (was: Started)
Basic cell catalog is in place, with preliminary cells.

Marking this as fixed, but we'll continue adding new kinds of cells as we create them.

Comment 6 by cmasso@google.com, Feb 28 2018

What user story does this task correspond to? Please add the label.

Comment 7 by sczs@chromium.org, Feb 28 2018

Labels: S-Recent-Tabs-Cells
The NextAction date has arrived: 2018-02-28

Comment 9 by cmasso@google.com, Feb 28 2018

NextAction: ----

Sign in to add a comment