@@unscopables objects in the DOM should have a null prototype
Reported by
bzbar...@gmail.com,
Feb 10 2018
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:59.0) Gecko/20100101 Firefox/59.0 Steps to reproduce the problem: See https://github.com/heycam/webidl/issues/496 What is the expected behavior? Object.getPrototypeOf(Element.prototype[Symbol.unscopables]) is null. What went wrong? It's not null. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 66.0.3343.3 (Official Build) dev (64-bit) Channel: n/a OS Version: OS X 10.12 Flash Version:
,
Feb 12 2018
This is NOT a devtools problem. It's a problem in the DOM bindings implementation. Please move this to the right place.
,
Feb 12 2018
Thanks Boris. Routing to the DOM team.
,
Feb 13 2018
I think binding-team can look this. yokishiino@, peria@, could you have a chance to look?
,
Feb 13 2018
I'll take this.
,
May 3 2018
,
May 7 2018
This issue is so simple that this shouldn't be blocked on anything. https://cs.chromium.org/chromium/src/third_party/blink/renderer/bindings/templates/interface_base.cpp.tmpl?rcl=2698ab2e0135bd4b62a4e472eceb3174592bf605&l=997 We just need to define @@unscopables as ES null.
,
May 7 2018
No, you need to change https://cs.chromium.org/chromium/src/third_party/blink/renderer/bindings/templates/interface_base.cpp.tmpl?rcl=2698ab2e0135bd4b62a4e472eceb3174592bf605&l=988 to create the object with a null prototype.
,
May 8 2018
Thanks for correcting my understanding. :)
,
May 25 2018
,
May 25 2018
Just FYI, 3.3.24. [Unscopable] https://heycam.github.io/webidl/#Unscopable and 3.6.3. Interface prototype object https://heycam.github.io/webidl/#interface-prototype-object step 8.1. Let unscopableObject be the result of performing ! ObjectCreate(null). creates an unscopable object with |null| prototype.
,
Jun 13 2018
Let me take this issue. I made a patch at: https://chromium-review.googlesource.com/c/chromium/src/+/1098914
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9facfb326a2423094a52109eb40177fc942d3f8a commit 9facfb326a2423094a52109eb40177fc942d3f8a Author: Yuki Shiino <yukishiino@chromium.org> Date: Fri Jun 15 08:49:06 2018 v8binding: Changes @@unscopables's prototype to ES null. Implements step 8.1. of https://heycam.github.io/webidl/#create-an-interface-prototype-object Bug: 811029 Change-Id: I0feb1c16cf12585db8847c82d4efa342701bebcb Reviewed-on: https://chromium-review.googlesource.com/1098914 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#567580} [modify] https://crrev.com/9facfb326a2423094a52109eb40177fc942d3f8a/third_party/WebKit/LayoutTests/external/wpt/WebIDL/ecmascript-binding/interface-prototype-object-expected.txt [modify] https://crrev.com/9facfb326a2423094a52109eb40177fc942d3f8a/third_party/WebKit/LayoutTests/external/wpt/WebIDL/ecmascript-binding/interface-prototype-object.html [modify] https://crrev.com/9facfb326a2423094a52109eb40177fc942d3f8a/third_party/blink/renderer/bindings/templates/interface_base.cpp.tmpl [modify] https://crrev.com/9facfb326a2423094a52109eb40177fc942d3f8a/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc [modify] https://crrev.com/9facfb326a2423094a52109eb40177fc942d3f8a/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
,
Jun 15 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bzbar...@mit.edu
, Feb 10 2018