New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810986 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Few file formats are not opening in respective default apps/ view

Project Member Reported by mkarkada@chromium.org, Feb 10 2018

Issue description

Chrome OS version: 10323.27.0, 65.0.3325.61 dev channel eve device

This issue is bit related to  Issue 761154 

Steps To Reproduce:
(1) Got Files app> Downloads
(2) Open an audio file, a video file, Docs (pdf, txt, docx, xlsx, pptx)
(3) Ensure there are some supporting apps installed for each of the file formats. 

Actual behavior:
1. Opening an audio files shows list of open with options. Instead of opening in default audio player.
2. Docs (like docx,xlsx, pptx) also lists open with options.
3. A text file (.txt) opens with 'Text<txt>' app by default.

Expected behavior:
1. Audio files should have opened with its default audio player. Behavior similar to opening a video file which opens with its default video player. Also .amr file (An audio format) opens with text. Please refer the attachment

2. I believe docs (like docx,xlsx, pptx) should open in its default view (i.e. quick office component), in similar to opening a pdf.

3. Text file also should open in its default view similar to opening a pdf. 

Please refer the attachments for all the actual behaviors.

 
Actual behavior of amr audio file.png
332 KB View Download
Actual behavior of audio file.png
336 KB View Download
Actual behavior of docs.png
304 KB View Download
WAI pdf.png
319 KB View Download
Actual behavior of text file.png
199 KB View Download
WAI video file.png
458 KB View Download
Owner: yamaguchi@chromium.org
Status: Assigned (was: Untriaged)
mkarkada@, could you clarify -

1. Are you double-clicking on the files to create these screenshots? If you have 1+ more apps to open a file, the double-clicking should by default open the file in one of the apps.

2. If you are specifically selecting a file and clicking the Open With option, it is possible that a default app may not yet be set by the user.
Cc: yamaguchi@chromium.org
Owner: mkarkada@chromium.org
I think some of the screenshot might be expected, but I would like to wait clarification as commented above.
https://bugs.chromium.org/p/chromium/issues/detail?id=751950#c9 describes internal rules ordering to decide the "default" task.
@weifangsun, I was double-clicking on the files which actually didn't open in respective default apps. I attached screenshots of context menu to show actual behavior of those files that didn't open in default view.
Cc: -yamaguchi@chromium.org mkarkada@chromium.org sashab@chromium.org
Owner: yamaguchi@chromium.org
mkarakda@ - Thanks for clarifying!

yamaguchi@ - Even if the user has not explicitly set a default app for a file type, shouldn't CrOS be opening a file in a default app on double-click? From a system perspective, we should always have a default app assigned?
As a known issue, the notation of "(default)" is wrong in some cases.let me reply after taking a bit more look.
> As a known issue, the notation of "(default)" is wrong in some cases.let me reply after taking a bit more look.
I am sorry, this statement is no longer true after crrev.com/762911. The "(default)" notation in the app list can be considered correct.


We made the Files app to ask user when there is no default but multiple choice. See  Issue 761154 .
(IMHO this is useful for some users especially when the app which come with the Chrome OS has limited capability and installing another app having richer functions for the same type of the file, like the case of QuickOffice -> PowerPoint.)

From technical perspective (with our current design), it's possible that no "default" app is assigned for a file type.
The rule #2 described in crbug.com/751950#c9 means:
- Only the built-in apps, {FileManager, VideoPlayer, Gallery, and Text.app} are considered "set to default for some file types before user explicitly chooses another one."
So a text file will always have default task to open it, but .wav or .pptx doesn't always have the default task to open them.

> 1. Audio files should have opened with its default audio player.
We can do this by adding the Audio player app to the built-in app list. Should we do this?

> 2. I believe docs (like docx,xlsx, pptx) should open in its default view (i.e. quick office component), in similar to opening a pdf.
This can be done by adding Quick Office component extension to the built-in app as well. Should we do this?

> 3. Text file also should open in its default view similar to opening a pdf. 
We got request to have Text.app open text file at least when getting a new ChromeOS device M63+. See Issue 751950.


* Among the screenshots, Text.app being listed as .amr file handler looks strange. This needs a separate investigation. TODO(yamaguchi): file a new bug for this.
* I've found some file types doesn't provide menu "change default". TODO(yamaguchi): file a new bug for this.
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d0b2f01bf6fc4abb7990aa434f02a10fa9d3ac

commit b5d0b2f01bf6fc4abb7990aa434f02a10fa9d3ac
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Feb 16 07:47:36 2018

Use audio player and the Office Editing apps as the init default task.

We have several component extension as the initial default app, which
means set to default before user explicitly changes default app.
Audio player and the "Office Editing for Docs, Sheets & Slides" app
were not included in that list despite these are also components.

Bug:  810986 
Test: unit_tests --gtest_filter=FileManagerFileTasksTest.*
Test: manually verified Office Editing shown as default

Change-Id: I1ee20773714ecda50fbe3d17f8cda1c0bb72fd96
Reviewed-on: https://chromium-review.googlesource.com/920124
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537247}
[modify] https://crrev.com/b5d0b2f01bf6fc4abb7990aa434f02a10fa9d3ac/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/b5d0b2f01bf6fc4abb7990aa434f02a10fa9d3ac/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc

Labels: Merge-Request-65
> 3. Text file also should open in its default view similar to opening a pdf. 
Filed  Issue 813059 .
> I've found some file types doesn't provide menu "change default".
Filed Issue 812490.


The change in #8 will resolve these 2 issues. We're going to merge this to M65.
> 1. Audio files should have opened with its default audio player.
> 2. I believe docs (like docx,xlsx, pptx) should open in its default view 
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 17 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 21 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4f2d80d1167d7e69ac2fc16974bf3bc33661bb

commit 3b4f2d80d1167d7e69ac2fc16974bf3bc33661bb
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Feb 21 02:20:48 2018

Use audio player and the Office Editing apps as the init default task.

We have several component extension as the initial default app, which
means set to default before user explicitly changes default app.
Audio player and the "Office Editing for Docs, Sheets & Slides" app
were not included in that list despite these are also components.

Bug:  810986 
Test: unit_tests --gtest_filter=FileManagerFileTasksTest.*
Test: manually verified Office Editing shown as default

Change-Id: I1ee20773714ecda50fbe3d17f8cda1c0bb72fd96
Reviewed-on: https://chromium-review.googlesource.com/920124
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537247}(cherry picked from commit b5d0b2f01bf6fc4abb7990aa434f02a10fa9d3ac)
Reviewed-on: https://chromium-review.googlesource.com/927841
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#524}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/3b4f2d80d1167d7e69ac2fc16974bf3bc33661bb/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/3b4f2d80d1167d7e69ac2fc16974bf3bc33661bb/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment