New issue
Advanced search Search tips

Issue 810974 link

Starred by 2 users
Status: Fixed
Owner:
cblume@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ChildLocalSurfaceIdAllocator's default values don't match Parent's

Project Member Reported by cblume@chromium.org, Feb 10 2018 
The parent might send a message with sequence numbers (1, 1, some_nonce).

When we call child_allocator_.UpdateFromParent(that_local_surface_id);, we only update child_allocator_'s parent sequence number and the nonce. This behavior is correct.

However, the child allocator assumes different initial values than the parent allocator. So the child allocator would now think we are on (1, 0, some_nonce).


Update the child allocator to use the same initial values.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3583febf5c6cd470df88fcf0e4c590831ad0c206

commit 3583febf5c6cd470df88fcf0e4c590831ad0c206
Author: Chris Blume <cblume@chromium.org>
Date: Tue Feb 13 00:29:25 2018

ChildLocalSurfaceIdAllocator to use Parent values

The parent and child assume currently assume different initial values.
This is leading to a situation where the parent sends a message (1,1)
and the child updates its internals to (1,0).

This patch uses the same initial values.

BUG= 810974 

Change-Id: I1deb005a445b65e82e79f3c04aaaf323efbedd32
Reviewed-on: https://chromium-review.googlesource.com/912286
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536245}
[modify] https://crrev.com/3583febf5c6cd470df88fcf0e4c590831ad0c206/components/viz/common/surfaces/child_local_surface_id_allocator.cc
[modify] https://crrev.com/3583febf5c6cd470df88fcf0e4c590831ad0c206/components/viz/common/surfaces/child_local_surface_id_allocator.h
[modify] https://crrev.com/3583febf5c6cd470df88fcf0e4c590831ad0c206/components/viz/common/surfaces/child_local_surface_id_allocator_unittest.cc
[modify] https://crrev.com/3583febf5c6cd470df88fcf0e4c590831ad0c206/components/viz/common/surfaces/local_surface_id.h
[modify] https://crrev.com/3583febf5c6cd470df88fcf0e4c590831ad0c206/components/viz/common/surfaces/parent_local_surface_id_allocator.cc
[modify] https://crrev.com/3583febf5c6cd470df88fcf0e4c590831ad0c206/components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc

Comment 2 by cblume@chromium.org, Feb 13 2018

Status: Fixed (was: Started)
►

Sign in to add a comment