Default actions in the fallback dialog |
||
Issue descriptionI expect that most developers will want to have baseline functionality like "Open in browser" / "Share" / "Copy" in the menu, whether it's provided by Chrome or in the fallback dialog. Right now, IIUC, guaranteeing that e.g. "Share" shows up also means that "Share" will be duplicated when the menu is provided by Chrome. (Though there might be some hacky way to tell whether Chrome supports it.) I think the best thing to do would probably be to add a few default actions to the fallback dialog: 1. "Open in browser" - launches an implicit VIEW intent with the link 2. "Copy link" - as advertised 3. "Share..." - launches the standard Android share sheet (Ideally we'd reuse the icons from Chrome here too, but I don't think it's a must-have.) Open to other suggestions, but I don't see a great way e.g. for dialog providers to disclaim what options they're gonna show in a general way.
,
Feb 13 2018
If devs don't know in advance whether Chrome or the fallback menu will show, will it be useful to be able to disable the defaults? If it's Chrome then they already have to assume a bunch of other menu items will be there.
,
Feb 13 2018
I guess "Open in browser" or "Copy link" are fine, but for Share, I know some apps build their own share intent, so they might want to disable the default? But also they can change the text to be clearer.
,
Feb 23 2018
That's a good point. Giving them the option to replace share SGTM. Update per UI review convo: we shouldn't show any icons for these actions.
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/custom-tabs-client/+/7884a658507dc99bcb54b328bc29d76e64c3b684 commit 7884a658507dc99bcb54b328bc29d76e64c3b684 Author: Lei Tian <ltian@chromium.org> Date: Wed Feb 28 22:43:53 2018 Add predefined items to Browser Actions fallback dialog Add 3 predefined items to the Browser Actions fallback dialog includes: 1. Open in browser 2. Copy link 3. Share link: Android vanila text share, not Chrome customize share. Also move the icons of custom items to align on the right and for predefined items, no icon would shown. Bug: 810971 , 811575 , 813926 Change-Id: I52ee0dfa9bb808cb5746889b9e10dff9aedcd6b9 Reviewed-on: https://chromium-review.googlesource.com/929593 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> [modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/values/colors.xml [modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/src/android/support/customtabs/browseractions/BrowserActionsIntent.java [modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/src/android/support/customtabs/browseractions/BrowserActionItem.java [modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/layout/browser_actions_context_menu_row.xml [add] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/values/strings.xml [modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/tests/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuUiTest.java [modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuUi.java [modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/layout/browser_actions_context_menu_page.xml [modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/values/dimens.xml
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4af8c78b3f5483e664ef6bc156e2196ed3d0b83 commit b4af8c78b3f5483e664ef6bc156e2196ed3d0b83 Author: Lei Tian <ltian@chromium.org> Date: Fri Mar 02 03:59:45 2018 Roll out changes of display predefined items for Browser Actions fallback dialog Roll out changes of display predefined items for Browser Actions fallback dialog Bug: 810971 , 811575 , 813926 Change-Id: I499f0e14bb2b1c39d362a3f78f53cb5a12df3545 Reviewed-on: https://chromium-review.googlesource.com/942189 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> Cr-Commit-Position: refs/heads/master@{#540441} [modify] https://crrev.com/b4af8c78b3f5483e664ef6bc156e2196ed3d0b83/DEPS
,
Mar 2 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ltian@chromium.org
, Feb 12 2018