Instead of only filing bugs in the audit app, allow for sending email too, as some use cases of the app require this. This should be configurable at the rule level
https://docs.google.com/document/d/1I-FYf6legs2qZkCG0SAJy_oLLeDqlkXyjCriES7OCtM/edit#
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/c385bf7b0f2dccc10cabd75a4eb810e66aa8c88e commit c385bf7b0f2dccc10cabd75a4eb810e66aa8c88e Author: Roberto Carrillo <robertocn@google.com> Date: Thu Feb 22 18:47:16 2018 [cr-audit-commits] Add fields for custom notification. The purpose of this change is the eventual introduction of custom notifications in addition to bug filing for certain rules. Currently the notifier relies on IssueID being 0 for determining if a notification has already been sent. This will change, as not all violations will be reported via Monorail Issue. This is the first step. Once this is deployed, we'll manually backfill the field for previous notifications, and then we'll introduce a change to query the commits to notify on using this flag instead of IssueID. R=stgao,chanli,lijeffrey,wylieb BUG= 810964 Change-Id: Ie9b77557d3b46b6c04b858a1a63142b50dd6fdfd Reviewed-on: https://chromium-review.googlesource.com/912648 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [add] https://crrev.com/c385bf7b0f2dccc10cabd75a4eb810e66aa8c88e/go/src/infra/appengine/cr-audit-commits/app/model_test.go [modify] https://crrev.com/c385bf7b0f2dccc10cabd75a4eb810e66aa8c88e/go/src/infra/appengine/cr-audit-commits/app/model.go [modify] https://crrev.com/c385bf7b0f2dccc10cabd75a4eb810e66aa8c88e/go/src/infra/appengine/cr-audit-commits/app/notifier_test.go [modify] https://crrev.com/c385bf7b0f2dccc10cabd75a4eb810e66aa8c88e/go/src/infra/appengine/cr-audit-commits/app/notifier.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/7e8b66437dc0a484c49d06e2fbe1cf046b54f073 commit 7e8b66437dc0a484c49d06e2fbe1cf046b54f073 Author: Roberto Carrillo <robertocn@google.com> Date: Fri Feb 23 22:22:51 2018 [cr-audit-app] Allow audit rules to send custom notifications. Each ruleset in the set may be configured to use one custom notification function. R=stgao,chanli,lijeffrey,wylieb BUG= 810964 Change-Id: I3b5400c61e9fa3ebb682283960778984a36cdaf8 Reviewed-on: https://chromium-review.googlesource.com/912515 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [add] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/rules_config_test.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/utils.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/releasebot_rules.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/rules_config.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/notifier_test.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/commit_auditor.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/commit_auditor_test.go [add] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/notification.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/notifier.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/templates/pages/status.html [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/commit_scanner_test.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/status_test.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/model.go [modify] https://crrev.com/7e8b66437dc0a484c49d06e2fbe1cf046b54f073/go/src/infra/appengine/cr-audit-commits/app/template_funcs.go
Comment 1 by robert...@chromium.org
, Feb 10 2018