New issue
Advanced search Search tips

Issue 810958 link

Starred by 1 user
Status: Assigned
Owner:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make all one-argument constructors in blink explicit, add presubmit

Project Member Reported by chrishtr@chromium.org, Feb 9 2018 
Arch team, let us know if this is already in progress or decided
against. I think it is a good idea to prevent bugs; I was hit by
this problem today.

Vlad volunteered to work on this in the background.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f75d381b957c3aef76ce7a25cfb3639badff7e4

commit 9f75d381b957c3aef76ce7a25cfb3639badff7e4
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Sat Feb 10 01:39:26 2018

[PE] Make PaintChunkProperties ctor explicit to avoid errors.

This patch makes PaintChunkProperties ctor explicit so that
PropertyTreeState cannot be accidentally converted to it, instead
requiring explicit construction.

R=chrishtr@chromium.org

Bug: 810958
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id3637eb7aea213af42f1802fcba907e1806bc3c1
Reviewed-on: https://chromium-review.googlesource.com/912463
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535917}
[modify] https://crrev.com/9f75d381b957c3aef76ce7a25cfb3639badff7e4/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/9f75d381b957c3aef76ce7a25cfb3639badff7e4/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayerTest.cpp
[modify] https://crrev.com/9f75d381b957c3aef76ce7a25cfb3639badff7e4/third_party/WebKit/Source/platform/graphics/paint/PaintChunkProperties.h
[modify] https://crrev.com/9f75d381b957c3aef76ce7a25cfb3639badff7e4/third_party/WebKit/Source/platform/graphics/paint/PaintRecordBuilder.cpp
►

Sign in to add a comment