AEC3 reverb decay computation does not work well when the filter sizes are different |
||||||||||
Issue descriptionThe current AEC3 reverb decay computation does not work well when the filter sizes are different.
,
Feb 10 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/4b9124e43294dafa2ab974c3ff36815e4f851d76 commit 4b9124e43294dafa2ab974c3ff36815e4f851d76 Author: Per Åhgren <peah@webrtc.org> Date: Sat Feb 10 00:35:11 2018 Deactivated the computation of the reverb in AEC3 TBR: gustaf@webrtc.org BUG: chromium:810951 ,webrtc:8872 Change-Id: I79194f964754d0f156a5206dbeb49606617e8bb5 Reviewed-on: https://webrtc-review.googlesource.com/50502 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21978} [modify] https://crrev.com/4b9124e43294dafa2ab974c3ff36815e4f851d76/modules/audio_processing/aec3/aec_state.cc
,
Feb 12 2018
,
Feb 12 2018
,
Feb 12 2018
,
Feb 12 2018
This bug requires manual review: Less than 18 days to go before AppStore submit on M65 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 12 2018
Approving merge to M65 per internal email thread "Question regarding merge request in https://bugs.chromium.org/p/chromium/issues/detail?id=810371". Pls merge ASAP. Thank you.
,
Feb 13 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/e6a2609a47eccd6c1a9462f4858d2e1d49ac50a8 commit e6a2609a47eccd6c1a9462f4858d2e1d49ac50a8 Author: Per Åhgren <peah@webrtc.org> Date: Tue Feb 13 19:30:31 2018 Merge to M65: Deactivated the computation of the reverb in AEC3 (cherry picked from commit 4b9124e43294dafa2ab974c3ff36815e4f851d76) TBR: gustaf@webrtc.org,henrik.lundin@webrtc.org BUG: chromium:810951 ,webrtc:8872 Change-Id: I79194f964754d0f156a5206dbeb49606617e8bb5 Reviewed-on: https://webrtc-review.googlesource.com/50502 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#21978} Reviewed-on: https://webrtc-review.googlesource.com/52640 Cr-Commit-Position: refs/branch-heads/65@{#17} Cr-Branched-From: 3ac67a736bb200ecf7c116a88b2f8d5c542973c8-refs/heads/master@{#21637} [modify] https://crrev.com/e6a2609a47eccd6c1a9462f4858d2e1d49ac50a8/modules/audio_processing/aec3/aec_state.cc
,
Feb 13 2018
Per comment #8, this is already merged to M65. So removing "Merge-Approved-65" label.
,
Feb 13 2018
,
May 22 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by peah@chromium.org
, Feb 9 2018