New issue
Advanced search Search tips

Issue 810950 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Convert proxy resolution consumers over to using the network service.

Project Member Reported by mmenke@chromium.org, Feb 9 2018 
PepperNetworkProxyHost and ResolveProxyMsgHelper (Both use by pepper plugins - why do they need two proxy APIs?) use the network stack to resolve proxies.  We need to switch them over to using the network service, which doesn't yet provide such an API.

PepperNetworkProxyHost, at least, is also broken (see issue 810211).

Both currently proxy requests for other processes, so we could create a new Mojo API and let other processes directly access it, if we so desired, to avoid the extra process hop.

Comment 1 by mmenke@chromium.org, Feb 9 2018

Components: Internals>Plugins>Pepper

Comment 2 by dxie@chromium.org, May 15 2018

Labels: -Pri-3 Proj-Servicification-Canary OS-All Pri-1

Comment 3 by dougt@chromium.org, May 17 2018

Status: Available (was: Untriaged)

Comment 4 by dxie@chromium.org, May 18 2018

Labels: -OS-All OS-Windows OS-Linux OS-Mac OS-Chrome OS-Android

Comment 5 by xunji...@chromium.org, May 25 2018 

mmenke@: We have a mojo API for resolving proxies (services/proxy_resolver/public/mojom/proxy_resolver.mojom). Will that satisfy the use case here (ignoring the part about the extra process hop)?

Comment 6 by mmenke@chromium.org, May 25 2018 

ProxyResolver is actually an API to compile and then execute particular PAC scripts on URLs, not an interface where someone can provide a URL and have it mapped to a hostname.  In this case, the consumer doesn't have the PAC script, and it may be that there's a proxy configuration that doesn't involve PAC scripts, so that's not sufficient.  We should perhaps rename proxy_resolver (Both the service and the net/ files) to pac_executor or somesuch.

Comment 7 by xunji...@chromium.org, May 25 2018 

Thanks, Matt! I created Issue 846732 to do the renaming.

Comment 8 by mmenke@chromium.org, Jul 10

Owner: mmenke@chromium.org
Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dfa217e969e2720e6f0281d5007aa9ffb92d940

commit 4dfa217e969e2720e6f0281d5007aa9ffb92d940
Author: Matt Menke <mmenke@chromium.org>
Date: Thu Aug 02 15:27:47 2018

Add proxy look up API to NetworkContexts, convert PPAPI consumers.

The only code outside of net/ / services/network that does direct proxy
resolutions appears to be the two PPAPI consumers. This CL updates them
both to use the new API.

Bug:  810950 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I643605dfe2d8b67626ea8b84ee793b2c88b66e12
Reviewed-on: https://chromium-review.googlesource.com/1136875
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580195}
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/BUILD.gn
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/renderer_host/pepper/pepper_network_proxy_host.cc
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/renderer_host/pepper/pepper_network_proxy_host.h
[add] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/renderer_host/pepper/pepper_proxy_lookup_helper.cc
[add] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/renderer_host/pepper/pepper_proxy_lookup_helper.h
[add] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/renderer_host/pepper/pepper_proxy_lookup_helper_unittest.cc
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/resolve_proxy_msg_helper.cc
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/resolve_proxy_msg_helper.h
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/browser/resolve_proxy_msg_helper_unittest.cc
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/content/test/BUILD.gn
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/BUILD.gn
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/network_context.cc
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/network_context.h
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/network_context_unittest.cc
[add] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/proxy_lookup_request.cc
[add] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/proxy_lookup_request.h
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/public/mojom/network_context.mojom
[add] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/public/mojom/proxy_lookup_client.mojom
[modify] https://crrev.com/4dfa217e969e2720e6f0281d5007aa9ffb92d940/services/network/test/test_network_context.h

Comment 10 by mmenke@chromium.org, Aug 2

Status: Fixed (was: Started)
►

Sign in to add a comment