AppViewTest.TestAppViewConnectFollowingPreviousConnect/0 flake in mash_browser_tests |
|||
Issue descriptionRecent example: https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20ChromiumOS/26817 Is this another case where the non-OOPIF parameterization should be removed, like issue 810007 ? I see other tests disabled for the /0 case, like in https://chromium-review.googlesource.com/c/chromium/src/+/830709 If you think this is a chromeos-specific chrome --mash (out-of-process sysui) issue, please assign back to me. [ RUN ] AppViewTests/AppViewTest.TestAppViewConnectFollowingPreviousConnect/0 [21909:21909:0209/141923.652993:ERROR:shell_delegate_mus.cc(71)] Not implemented reached in virtual void ash::ShellDelegateMus::PreInit() [21909:21909:0209/141923.738257:ERROR:layer_tree_host_impl.cc(2647)] Forcing zero-copy tile initialization as worker context is missing [21739:21739:0209/141923.744789:WARNING:user_policy_manager_factory_chromeos.cc(184)] No policy loaded for known non-enterprise user [21909:21909:0209/141923.748267:ERROR:wallpaper_controller.cc(1247)] User is ephemeral or guest! Fallback to default wallpaper. [21739:21739:0209/141923.765429:WARNING:user_session_manager.cc(1044)] Attempting to save user password for non enterprise user. [21909:21909:0209/141923.891803:ERROR:shell_delegate_mus.cc(61)] Not implemented reached in virtual bool ash::ShellDelegateMus::CanShowWindowForUser(aura::Window *) const [21739:21739:0209/141923.951008:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [21739:21739:0209/141923.951374:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [21739:21739:0209/141923.951941:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [21739:21739:0209/141923.952050:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. GMOCK WARNING: Uninteresting mock function call - returning directly. Function call: RegisterMediaRoutesObserver(0xf7427e8a000) NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details. GMOCK WARNING: Uninteresting mock function call - taking default action specified at: ../../chrome/browser/apps/app_browsertest_util.cc:68: Function call: RegisterMediaSinksObserver(0xf7427e8a028) Returns: true NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details. [21739:21739:0209/141923.988778:ERROR:remote_text_input_client.cc(135)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged() [21739:21739:0209/141923.988801:ERROR:remote_text_input_client.cc(92)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const [21739:21739:0209/141923.988819:ERROR:remote_text_input_client.cc(98)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const [21739:21739:0209/141923.988825:ERROR:remote_text_input_client.cc(153)] Not implemented reached in virtual void RemoteTextInputClient::EnsureCaretNotInRect(const gfx::Rect &) [21739:21739:0209/141924.001836:ERROR:layer_tree_host_impl.cc(2647)] Forcing zero-copy tile initialization as worker context is missing [21739:21739:0209/141924.027216:ERROR:layer_tree_host_impl.cc(2647)] Forcing zero-copy tile initialization as worker context is missing [1:10:0209/141924.041933:ERROR:layer_tree_host_impl.cc(2647)] Forcing zero-copy tile initialization as worker context is missing [21739:21739:0209/141924.791093:ERROR:render_widget_host_view_aura.cc(1284)] Not implemented reached in virtual base::i18n::TextDirection content::RenderWidgetHostViewAura::GetTextDirection() const [1:10:0209/141924.792779:ERROR:layer_tree_host_impl.cc(2647)] Forcing zero-copy tile initialization as worker context is missing [21739:21739:0209/141924.805780:ERROR:layer_tree_host_impl.cc(2647)] Forcing zero-copy tile initialization as worker context is missing [21739:21739:0209/141924.893485:INFO:CONSOLE(37)] "appToEmbed cmoageaohepoaifbiafpgmbjiedpgnfk", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37) [21739:21739:0209/141924.929923:INFO:CONSOLE(37)] "CONNECTED. (1 / 3)", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37) [21739:21739:0209/141924.964518:INFO:CONSOLE(37)] "CONNECTED. (2 / 3)", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37) [21739:21902:0209/141924.991500:ERROR:crash_handler_host_linux.cc(437)] Failed to write crash dump for pid 22234 Cannot upload crash dump: failed to open Failed to save crash dump: failed to open BrowserTestBase received signal: Terminated. Backtrace: #0 0x000003ec29ec base::debug::StackTrace::StackTrace() #1 0x0000044fe0c5 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f5727675cb0 <unknown> #3 0x7f572773d6d3 epoll_wait #4 0x000004e6807d epoll_dispatch #5 0x000004e65b6d event_base_loop #6 0x000003ee6c72 base::MessagePumpLibevent::Run() #7 0x000003ee3f19 base::MessageLoop::Run() #8 0x000003f0f259 base::RunLoop::Run() #9 0x000004535aa3 content::RunMessageLoop() #10 0x000009031fae ExtensionTestMessageListener::WaitUntilSatisfied() #11 0x0000005e71f1 AppViewTest::TestHelper() #12 0x0000005e7b9e AppViewTest_TestAppViewConnectFollowingPreviousConnect_Test::RunTestOnMainThread() #13 0x0000044fde21 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #14 0x000003ff5bce ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #15 0x000003ff496a ChromeBrowserMainParts::PreMainMessageLoopRun() #16 0x0000019a0253 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #17 0x0000027592c1 content::BrowserMainLoop::PreMainMessageLoopRun() #18 0x000002b93d85 content::StartupTaskRunner::RunAllTasksNow() #19 0x00000275787d content::BrowserMainLoop::CreateStartupTasks() #20 0x00000275bd73 content::BrowserMainRunnerImpl::Initialize() #21 0x000002755462 content::BrowserMain() #22 0x000003e8dcf1 content::ContentMainRunnerImpl::Run() #23 0x00000616aea7 service_manager::Main() #24 0x000003e8c2e4 content::ContentMain() #25 0x0000044fda8b content::BrowserTestBase::SetUp() #26 0x000003faf1ab InProcessBrowserTest::SetUp() #27 0x000001d20571 testing::Test::Run() #28 0x000001d21130 testing::TestInfo::Run() #29 0x000001d21617 testing::TestCase::Run() #30 0x000001d28a87 testing::internal::UnitTestImpl::RunAllTests() #31 0x000001d286d7 testing::UnitTest::Run() #32 0x000003fc3792 base::TestSuite::Run() #33 0x000003eb68c9 ChromeTestSuiteRunner::RunTestSuite() #34 0x000003eb6840 (anonymous namespace)::MusTestLauncherDelegate::RunTestSuite() #35 0x00000453229c content::LaunchTests() #36 0x000003eb6d94 LaunchChromeTests() #37 0x000003eb65d6 RunMashBrowserTests() #38 0x000003eb6487 main #39 0x7f5727660f45 __libc_start_main #40 0x0000005c98ba _start
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c096439d8f09c4fb11165dd804024e9cce9a3898 commit c096439d8f09c4fb11165dd804024e9cce9a3898 Author: James Cook <jamescook@chromium.org> Date: Fri Feb 09 22:49:16 2018 Disable mash AppViewTest/TestAppViewConnectFollowingPreviousConnect/0 Filter it out of mash_browser_tests on the mojo FYI bot. It's flaky. TBR=mcnee@chromium.org Bug: 810935 Test: mash_browser_tests Change-Id: I3ab4b650eb020f93105b90fc863b5e0125d487ba Reviewed-on: https://chromium-review.googlesource.com/912105 Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#535866} [modify] https://crrev.com/c096439d8f09c4fb11165dd804024e9cce9a3898/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter
,
Feb 12 2018
Yes, I'll remove the BrowserPlugin parameterization of these tests as well.
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ae562c46b262f3c68dbb067299ac2d9e6be96ce commit 0ae562c46b262f3c68dbb067299ac2d9e6be96ce Author: Kevin McNee <mcnee@chromium.org> Date: Mon Feb 12 21:57:06 2018 Remove BrowserPlugin parameterization of AppViewTests. AppViewTests now only run for the GuestViewCrossProcessFrames enabled case. Tests that were disabled for flaking in the BrowserPlugin case are reenabled. Bug: 533069, 810935 , 794490 , 668304 Change-Id: Ied54ca2fdafec1c15b7b68f3e8da1617c9d63a73 Reviewed-on: https://chromium-review.googlesource.com/913715 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#536203} [modify] https://crrev.com/0ae562c46b262f3c68dbb067299ac2d9e6be96ce/chrome/browser/apps/guest_view/app_view_browsertest.cc [modify] https://crrev.com/0ae562c46b262f3c68dbb067299ac2d9e6be96ce/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter
,
Feb 12 2018
AppViewTests now only test the OOPIF implementation. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jamescook@chromium.org
, Feb 9 2018