New issue
Advanced search Search tips

Issue 810930 link

Starred by 1 user
Status: Fixed
Owner:
kkhorimoto@chromium.org
Closed: Feb 2018
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove Tab's |-wasShown| and |-wasHidden|

Project Member Reported by kkhorimoto@chromium.org, Feb 9 2018 
These just call the same functions on the Tab's WebState.  These functions should be removed and the WebState should be updated directly.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74914d33c83adedd38d69ba624ec542581eba19b

commit 74914d33c83adedd38d69ba624ec542581eba19b
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Feb 14 23:26:30 2018

[iOS] Remove Tab's |-wasShown| and |-wasHidden|.

Bug:  810930 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5afa1b4bb506c7e3f21aaacb8071235596447158
Reviewed-on: https://chromium-review.googlesource.com/911823
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536876}
[modify] https://crrev.com/74914d33c83adedd38d69ba624ec542581eba19b/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/74914d33c83adedd38d69ba624ec542581eba19b/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/74914d33c83adedd38d69ba624ec542581eba19b/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/74914d33c83adedd38d69ba624ec542581eba19b/ios/chrome/browser/ui/browser_view_controller_unittest.mm

Comment 2 by kkhorimoto@chromium.org, Feb 14 2018

Status: Fixed (was: Started)
►

Sign in to add a comment