New issue
Advanced search Search tips

Issue 810923 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocked on:
issue 810951



Sign in to add a comment

Use-of-uninitialized-value in webrtc::AecState::Update

Project Member Reported by ClusterFuzz, Feb 9 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5597659231158272

Fuzzer: libFuzzer_audio_processing_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  webrtc::AecState::Update
  webrtc::EchoRemoverImpl::ProcessCapture
  webrtc::BlockProcessorImpl::ProcessCapture
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=535484:535496

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5597659231158272

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Components: Blink>WebRTC
Owner: peah@chromium.org
Status: Assigned (was: Untriaged)
peah@, this looks to be regression from your recent changes, can you please take a look.

Comment 2 by peah@chromium.org, Feb 9 2018

Blockedon: 810951

Comment 3 by peah@chromium.org, Feb 9 2018

Thanks!
I have a CL ready that fixes that issue.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 10 2018

Labels: M-66
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 10 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 10 2018

Labels: Pri-1

Comment 7 by peah@chromium.org, Feb 10 2018

The issue should now be fixed. Is there any way that I  can verify that the fixing CL has the intended effect?
Project Member

Comment 8 by ClusterFuzz, Feb 10 2018

ClusterFuzz has detected this issue as fixed in range 535958:535961.

Detailed report: https://clusterfuzz.com/testcase?key=5597659231158272

Fuzzer: libFuzzer_audio_processing_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  webrtc::AecState::Update
  webrtc::EchoRemoverImpl::ProcessCapture
  webrtc::BlockProcessorImpl::ProcessCapture
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=535484:535496
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=535958:535961

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5597659231158272

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Feb 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5597659231158272 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 10 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Labels: -ReleaseBlock-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, May 19 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment